All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Jelly Jia <Jelly.Jia@cixtech.com>
Cc: vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, robin.murphy@arm.com,
	devicetree@vger.kernel.org, Frank.Li@kernel.org,
	cix-kernel-upstream@cixtech.com, dmaengine@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] dt-bindings: dma: arm,dma-350: Document optional clocks and resets
Date: Wed, 4 Nov 2026 13:34:04 -0600	[thread overview]
Message-ID: <auuIrNTtrm7Tn4vb@SMW015318> (raw)
In-Reply-To: <20261104124411.296640-4-Jelly.Jia@cixtech.com>

On Wed, Nov 04, 2026 at 08:44:09PM +0800, Jelly Jia wrote:
> Some integrations gate the DMA-350 controller with a bus clock or hold it
> in reset. Sky1 provides a clock for both its FCH and AUDSS instances, and
> a reset for the AUDSS instance. Document these standard resources on the
> DMA controller node.
>
> Neither property is required, so existing device trees are unchanged.
>
> Signed-off-by: Jelly Jia <Jelly.Jia@cixtech.com>
> ---
>  .../devicetree/bindings/dma/arm,dma-350.yaml     | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> index 429f682f15d8..43279878207c 100644
> --- a/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> +++ b/Documentation/devicetree/bindings/dma/arm,dma-350.yaml
> @@ -9,9 +9,6 @@ title: Arm CoreLink DMA-350 Controller
>  maintainers:
>    - Robin Murphy <robin.murphy@arm.com>
>
> -allOf:
> -  - $ref: dma-controller.yaml#
> -
>  properties:
>    compatible:
>      const: arm,dma-350

Suppose you should add front compatible string and fall back to arm,dma-350

and use front compatible at if branch to restrict clocks and resets.

Frank

> @@ -36,9 +33,22 @@ properties:
>      const: 1
>      description: The cell is the trigger input number
>
> +  clocks:
> +    maxItems: 1
> +    description:
> +      Optional bus clock, where the integration gates the controller clock.
> +
> +  resets:
> +    maxItems: 1
> +    description:
> +      Optional reset line, where the integration exposes one.
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>
> +allOf:
> +  - $ref: dma-controller.yaml#
> +
>  unevaluatedProperties: false
> --
> 2.54.0
>


  reply	other threads:[~2026-11-04 19:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 12:44 [PATCH v5 0/5] dmaengine: arm-dma350: Add slave support and Sky1 integration Jelly Jia
2026-11-04 12:44 ` [PATCH v5 1/5] dmaengine: arm-dma350: Fix source trigger bit Jelly Jia
2026-11-04 12:44 ` [PATCH v5 2/5] dmaengine: arm-dma350: Add slave and cyclic transfer support Jelly Jia
2026-11-04 13:08   ` sashiko-bot
2026-11-04 19:36     ` Frank Li
2026-11-05  8:42       ` Jelly Jia
2026-11-04 12:44 ` [PATCH v5 3/5] dt-bindings: dma: arm,dma-350: Document optional clocks and resets Jelly Jia
2026-11-04 19:34   ` Frank Li [this message]
2026-11-05  8:42     ` Jelly Jia
2026-11-04 12:44 ` [PATCH v5 4/5] dmaengine: arm-dma350: Support integration " Jelly Jia
2026-11-04 19:37   ` Frank Li
2026-11-04 12:44 ` [PATCH v5 5/5] arm64: dts: cix: Describe the Sky1 FCH DMA-350 integration Jelly Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auuIrNTtrm7Tn4vb@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@kernel.org \
    --cc=Jelly.Jia@cixtech.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.