From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793825069; b=5iReYhWRfr8tc9UZKNPMRZaE/N7vnyjruLjVd5hSXErzHoB/AvVNoNqVDX0/P+AlAILI pFRsyB8S1GzrEOqrEoSAeUw60TczvHRJQ1pUxNgiwrIaPASAXnKzvzlBXgwROROzVAd1G CnoFMNC6YQJDSAX4X/7AxLbmv/HHVCGbf7/ciQM5dwOtIEKLpSp81kuHMRNkFvE8AKmiC jAcldMVNxFcUvtrN4Xn1/QhPB8W5QKomlXIrM+w3ZGI6wlnch4zEA8qvm2RCdyPnXmKW9 bGDUiUhWLMsbEjxl4C+HCerm1hfGqNJbeiz+axEXwRf82Ou/YzjRaC0+aaTW30D1euA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793825069; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=Fu3Aq2hefSzjwRV+KYEz/CG5s0UvrmJ9SoczCNw172g=; b=qDJ6ACEmQwOPC+M56vMdKXcSMvUVuCkB275UNtsoM/bKRlvL9Zxa7Ft9CQiUhcQKocGT gJ1xZ9h9nNzm3e6UgtEgNHD526Ajemrhk5JpXJ6Jfdr3JmLZTtFoNi0oLPfu49RUF5lsN Fah142f1fNAeGsFEGOVBD48R7BkSU+jjXkU1IWd5qG2OqcoBXBf4+ASNhlyXzYi+HD7lV H26Z0xcaP2jsYblEB3ejgJA9XgOtl+STbhto1ULt/AZb0j4FK3g/alD+sbZQDWmphQdr8 4whFDKOmLMCMU20C90pazWd6DrCWCJQqYrABtJIFMfV1xPKQHlnRPVyf1OsuB0NLbDA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NRcZ9DVE; arc=none smtp.remote-ip=192.198.163.18 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87142606C471; Wed, 4 Nov 2026 20:44:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 87142606C471 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NRcZ9DVE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793825069; x=1825361069; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5sRT5I+m6KfQYFE3k27dO5MxaZynzJhyPdFPDxcOiE4=; b=NRcZ9DVEyB+z8PNUWWN1k1TwNJsHkHLB0RkIhXNi8OPPaumAbXwdBusb XJ0tRswIwk/HAI3U08NCdw8gSsd3fdHfsZGvIoakFFNjw3AMbhwBsxdvZ MF+IFI3N8G6s1cU9TZ6nu2D7Quh3Bd9w77S64rw1QFG76PE3tzcAH+cza JCV/7ImeaR645m5dp2GIWnI4RcctcQ0zYSIyQaI33Sl40LNLVHUHPcJ9D cTDOV5DlxtAWFgmxbMxz9PHoa3W0Xhp07+B1RPDbNL/WVi6i07ag3i3h7 qw4i8gPp7H9DXoutExRukI4yyUua1UoY5hgyDVfZhouA34dOrNySljHLr A==; X-CSE-ConnectionGUID: NkNZdLhaT3eysPfzIT/amA== X-CSE-MsgGUID: EUMq4yy+RUeCSzBbPsUa5A== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2635153" X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="2635153" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:28 -0800 X-CSE-ConnectionGUID: EZ1+q8OlT/uYk59yq1HNAg== X-CSE-MsgGUID: icBbDpEQTOuZLO4D8LrQjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="7215296" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:16 -0800 Date: Wed, 4 Nov 2026 22:44:13 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Mukesh Kumar Savaliya , Wolfram Sang , Thierry Reding Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261104152253.3279052-1-Frank.Li@oss.nxp.com> X-Mailing-List: imx@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Nov 04, 2026 at 06:25:32PM +0100, Krzysztof Kozlowski wrote: > On 04/11/2026 16:22, Frank.Li@oss.nxp.com wrote: ... > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > > index 762a3fb0fca81..de205e04a8600 100644 > > --- a/drivers/spi/atmel-quadspi.c > > +++ b/drivers/spi/atmel-quadspi.c > > @@ -790,8 +790,7 @@ static int atmel_qspi_dma_xfer(struct atmel_qspi *aq, struct dma_chan *chan, > > } > > > > reinit_completion(&aq->dma_completion); > > - tx->callback = atmel_qspi_dma_callback; > > - tx->callback_param = aq; > > + dmaengine_desc_set_callback(tx, atmel_qspi_dma_callback, NULL, aq); > > Andy, > These three lines look correct. > > LGTM: > > Reviewed-by: Krzysztof Kozlowski As Reviewed-by: Krzysztof Kozlowski # atmel-quadspi Note, it's in your power to ask the author to split out what you maintain to a separate change. So, it's your choice what to do, Ack the full patch, give a partial Rb, ask for a split, ignore reviewing (often means silent agreement when maintainer just applies that kind of a patch) -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3DF606C474 for ; Wed, 4 Nov 2026 20:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nszRW2cQ; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NRcZ9DVE DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=XSgFM28WEbK83XajcNl0H4je97IY7upeK7w+b3Vbi0w=; b=nszRW2cQrFqd5hdkmwxGq9lGU8 2vR+RIrP3u3NzUBDJWtyYeIe/T9Yg60Hv693c2yLBpoARkrZS2Kt3QYcjRiq4XTQorOjj8LWZCUk+ kH2/gWhIhGY86Wgw94YKiP5DH56Mf8BD5/GqOjGyWAV3XnUXD3ro+KROdXAsxYwR3TCCrTiNOp2g7 EiVhvpFhwSDLpdXzaOaeoOyNygza8QVqLWcEADssv4h4wMcZIwBZHiiuCqfd6Djt0eNPLcWJBYdjM lXujGELGB7rMRKHnLryPrKIvBqRB+O0L1E9kz0i/hns0Uql6woImjXc48bpV3Tzv42qZmfoS0qjJN ZhA08qPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOhqS-00000006vwc-1tQH; Wed, 04 Nov 2026 20:44:32 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOhqO-00000006vvk-1TCJ; Wed, 04 Nov 2026 20:44:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793825069; x=1825361069; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5sRT5I+m6KfQYFE3k27dO5MxaZynzJhyPdFPDxcOiE4=; b=NRcZ9DVEyB+z8PNUWWN1k1TwNJsHkHLB0RkIhXNi8OPPaumAbXwdBusb XJ0tRswIwk/HAI3U08NCdw8gSsd3fdHfsZGvIoakFFNjw3AMbhwBsxdvZ MF+IFI3N8G6s1cU9TZ6nu2D7Quh3Bd9w77S64rw1QFG76PE3tzcAH+cza JCV/7ImeaR645m5dp2GIWnI4RcctcQ0zYSIyQaI33Sl40LNLVHUHPcJ9D cTDOV5DlxtAWFgmxbMxz9PHoa3W0Xhp07+B1RPDbNL/WVi6i07ag3i3h7 qw4i8gPp7H9DXoutExRukI4yyUua1UoY5hgyDVfZhouA34dOrNySljHLr A==; X-CSE-ConnectionGUID: AI6L03IHQYa5AAR2AWTtuA== X-CSE-MsgGUID: nphxaMpbSUuEiQ6lL+i8cg== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2635170" X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="2635170" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:28 -0800 X-CSE-ConnectionGUID: EZ1+q8OlT/uYk59yq1HNAg== X-CSE-MsgGUID: icBbDpEQTOuZLO4D8LrQjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="7215296" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:16 -0800 Date: Wed, 4 Nov 2026 22:44:13 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Mukesh Kumar Savaliya , Wolfram Sang , Thierry Reding Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261104152253.3279052-1-Frank.Li@oss.nxp.com> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_124428_421855_022CD74B X-CRM114-Status: GOOD ( 15.02 ) X-Spam-Score: -4.2 (----) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Nov 04, 2026 at 06:25:32PM +0100, Krzysztof Kozlowski wrote: > On 04/11/2026 16:22, Frank.Li@oss.nxp.com wrote: ... > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > > index 762a3fb0fca81..de205e04a8600 100644 > > --- a/drivers/spi/atmel-quadspi.c > > +++ b/drivers/spi/atmel-quadspi.c > > @@ -790,8 +790,7 @@ static int atmel_qspi_dma_xfer(struct atmel_qspi *aq, struct dma_chan *chan, > > } > > > > reinit_completion(&aq->dma_completion); > > - tx->callback = atmel_qspi_dma_callback; > > - tx->callback_param = aq; > > + dmaengine_desc_set_callback(tx, atmel_qspi_dma_callback, NULL, aq); > > Andy, > These three lines look correct. > > LGTM: > > Reviewed-by: Krzysztof Kozlowski As Reviewed-by: Krzysztof Kozlowski # atmel-quadspi Note, it's in your power to ask the author to split out what you maintain to a separate change. So, it's your choice what to do, Ack the full patch, give a partial Rb, ask for a split, ignore reviewing (often means silent agreement when maintainer just applies that kind of a patch) -- With Best Regards, Andy Shevchenko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AA76076364 for ; Wed, 4 Nov 2026 20:44:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=CLN4+JRI; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NRcZ9DVE DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=vxwd02PNdb2t4dhA7CEKhwzj2d7fEy4Tuj6zr1vgz/w=; b=CLN4+JRI9kJIbJj0iVt6u+tY/U FQVK1Ihu2v7wlltRR7A4I0QtIOmhAgsrV6yH4vJxwZByfnaGsXr8TzDH+zh0tgt5wzNowPP33+RXk l0UmkfBsKqfIYYAeKuYpViYHvO5VTd/8sy/v7keCufDVFQGq2VJRkvWHEgwqVCTdmB0Jf6v7DuPjD 3HgauxK1ye40p0/aWG8Erm8kQe6e7/hAr66FeSmLj6V7dATHDLFzXti5P4g6yKUaKzadL/rWFzVYN PXk0ebKiUN+wLvZbAIK6jHKwnhw7tRrMDWJpFpapfSBpgdCz0AZvaxxoiQncaNo/ZYQqFo0aIkAMj SJU/iw5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOhqS-00000006vwW-1bAS; Wed, 04 Nov 2026 20:44:32 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xOhqO-00000006vvk-1TCJ; Wed, 04 Nov 2026 20:44:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793825069; x=1825361069; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5sRT5I+m6KfQYFE3k27dO5MxaZynzJhyPdFPDxcOiE4=; b=NRcZ9DVEyB+z8PNUWWN1k1TwNJsHkHLB0RkIhXNi8OPPaumAbXwdBusb XJ0tRswIwk/HAI3U08NCdw8gSsd3fdHfsZGvIoakFFNjw3AMbhwBsxdvZ MF+IFI3N8G6s1cU9TZ6nu2D7Quh3Bd9w77S64rw1QFG76PE3tzcAH+cza JCV/7ImeaR645m5dp2GIWnI4RcctcQ0zYSIyQaI33Sl40LNLVHUHPcJ9D cTDOV5DlxtAWFgmxbMxz9PHoa3W0Xhp07+B1RPDbNL/WVi6i07ag3i3h7 qw4i8gPp7H9DXoutExRukI4yyUua1UoY5hgyDVfZhouA34dOrNySljHLr A==; X-CSE-ConnectionGUID: AI6L03IHQYa5AAR2AWTtuA== X-CSE-MsgGUID: nphxaMpbSUuEiQ6lL+i8cg== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2635170" X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="2635170" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:28 -0800 X-CSE-ConnectionGUID: EZ1+q8OlT/uYk59yq1HNAg== X-CSE-MsgGUID: icBbDpEQTOuZLO4D8LrQjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,195,1787036400"; d="scan'208";a="7215296" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.24]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2026 12:44:16 -0800 Date: Wed, 4 Nov 2026 22:44:13 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Mukesh Kumar Savaliya , Wolfram Sang , Thierry Reding Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261104152253.3279052-1-Frank.Li@oss.nxp.com> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261104_124428_421855_022CD74B X-CRM114-Status: GOOD ( 15.02 ) X-Spam-Score: -4.2 (----) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Nov 04, 2026 at 06:25:32PM +0100, Krzysztof Kozlowski wrote: > On 04/11/2026 16:22, Frank.Li@oss.nxp.com wrote: ... > > diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c > > index 762a3fb0fca81..de205e04a8600 100644 > > --- a/drivers/spi/atmel-quadspi.c > > +++ b/drivers/spi/atmel-quadspi.c > > @@ -790,8 +790,7 @@ static int atmel_qspi_dma_xfer(struct atmel_qspi *aq, struct dma_chan *chan, > > } > > > > reinit_completion(&aq->dma_completion); > > - tx->callback = atmel_qspi_dma_callback; > > - tx->callback_param = aq; > > + dmaengine_desc_set_callback(tx, atmel_qspi_dma_callback, NULL, aq); > > Andy, > These three lines look correct. > > LGTM: > > Reviewed-by: Krzysztof Kozlowski As Reviewed-by: Krzysztof Kozlowski # atmel-quadspi Note, it's in your power to ask the author to split out what you maintain to a separate change. So, it's your choice what to do, Ack the full patch, give a partial Rb, ask for a split, ignore reviewing (often means silent agreement when maintainer just applies that kind of a patch) -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip