From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: lirongqing <lirongqing@baidu.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf intel-pt: Free the old snapshot reference array after growing it
Date: Wed, 4 Nov 2026 18:18:05 -0300 [thread overview]
Message-ID: <auuhDZzGm-WSkw3w@phoenix2> (raw)
In-Reply-To: <cf0d3547-e4ba-474c-9a25-ef8f59225dac@intel.com>
On Wed, Nov 04, 2026 at 11:50:02AM +0200, Adrian Hunter wrote:
> On 04/11/2026 04:19, lirongqing wrote:
> > From: Li RongQing <lirongqing@baidu.com>
> >
> > Growing snapshot_refs allocates a new array and copies the old entries,
> > then overwrites the only pointer to the old array. Snapshot recording
> > with more than sixteen AUX mappings leaks that allocation on expansion.
> >
> > Free the old array after copying its entries. The reference buffers are
> > still owned by the entries copied into the replacement array.
> >
> > Fixes: 90e457f7be08 ("perf tools: Add Intel PT support")
> > Signed-off-by: Li RongQing <lirongqing@baidu.com>
>
> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
Thanks, applied for v7.4.
- Arnaldo
next prev parent reply other threads:[~2026-11-04 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 2:19 [PATCH] perf intel-pt: Free the old snapshot reference array after growing it lirongqing
2026-11-04 9:50 ` Adrian Hunter
2026-11-04 21:18 ` Arnaldo Carvalho de Melo [this message]
2026-11-06 5:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auuhDZzGm-WSkw3w@phoenix2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.