From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Yige Jiang <yigejiang86@gmail.com>
Cc: chrome-platform@lists.linux.dev,
Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, Nick Crews <ncrews@chromium.org>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Fix device reference leak on open failure
Date: Thu, 5 Nov 2026 05:27:29 +0000 [thread overview]
Message-ID: <auwTwb3iKN3td-Uh@google.com> (raw)
In-Reply-To: <rc-review-20261103-vc-85-d1e3d35e7c31@gmail.com>
On Thu, Nov 05, 2026 at 12:47:12PM +0800, Yige Jiang wrote:
> telem_open() takes a reference to dev_data->dev before allocating
> the session. If that allocation fails, it returns -ENOMEM without
> dropping the reference. Since release is not called after a failed
> open, the device data remains pinned after removal.
>
> Drop the reference on the allocation failure path, after restoring
Moving get_device() after kzalloc_obj() succeeds makes it cleaner.
> Assisted-by: LLM
The tag is no longer used; ./scripts/checkpatch.pl --strict:
WARNING: Non-standard signature: Assisted-by:
ERROR: Unrecognized email address: 'LLM'
prev parent reply other threads:[~2026-11-05 5:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 4:47 [PATCH] platform/chrome: wilco_ec: Fix device reference leak on open failure Yige Jiang
2026-11-05 5:27 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auwTwb3iKN3td-Uh@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=yigejiang86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.