Re: [Buildroot] [PATCH v3 6/6] package/mender-connect: depend on mender, drop sysvinit file

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, Oct 28, 2026 at 12:33:31PM +0100, Adam Duskett wrote:
> Much like the mender-update-modules package, have the mender-connect
> package depend on the mender package. Also, as mender no longer supports
> sysvinit, it's safe to remove S43mender-connect
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/mender-connect/Config.in         | 20 +++------
>  package/mender-connect/S43mender-connect | 53 ------------------------
>  package/mender-connect/mender-connect.mk |  5 ---
>  3 files changed, 5 insertions(+), 73 deletions(-)
>  delete mode 100644 package/mender-connect/S43mender-connect
> 
> diff --git a/package/mender-connect/Config.in b/package/mender-connect/Config.in
> index d478e468c2..b8f3770509 100644
> --- a/package/mender-connect/Config.in
> +++ b/package/mender-connect/Config.in
> @@ -1,15 +1,7 @@
>  config BR2_PACKAGE_MENDER_CONNECT
>  	bool "mender-connect"
> -	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS
> -	depends on BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS

Are you sure this dependency is no longer needed?

> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, mender
> -	depends on BR2_USE_WCHAR # libglib2 -> gettext
> -	depends on BR2_USE_MMU # dbus -> fork()
> -	select BR2_PACKAGE_DBUS # runtime
> -	select BR2_PACKAGE_HOST_GO
> -	select BR2_PACKAGE_LIBGLIB2
> -	select BR2_PACKAGE_MENDER # runtime
> -	select BR2_PACKAGE_OPENSSL

And why are all those selects gone? For the BR2_PACKAGE_MENDER select,
I understand it has been changed to a "depends on", which is a very
good idea. But since mender-connect.mk has all these other packages
(dbus, libglib2, openssl) in its DEPENDENCIES variable, then those
select should stick, and therefore perhaps the related "depends on" as
well (threads, wchar, mmu).

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot