All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] docs/devel/testing: iotests check script should be run via 'run'
Date: Thu, 5 Nov 2026 09:32:20 +0000	[thread overview]
Message-ID: <auxNJASte9kJ3OXg@redhat.com> (raw)
In-Reply-To: <66a0a4e7-3e3c-462f-9a1e-bed93e9bc3bd@oss.qualcomm.com>

On Thu, Nov 05, 2026 at 12:16:14AM -0800, Pierrick Bouvier wrote:
> On 11/3/2026 3:08 AM, Peter Maydell wrote:
> > The iotests section of the testing documentation suggests directly
> > running the "./check" script.  However if you do this then the
> > script complains:
> > 
> > WARNING: iotests is being run from outside of the configure-time python virtual environment
> > [...]
> > Please use the meson run script:
> >         /home/pm215/qemu/build/x86-tgt-san-dbg/run ./check
> >
> 
> A bit a side question,
> 
> Does it bring anything useful compared to:
> ./build/run meson test <this_test or suite>?
> If not, maybe we can remove all this, including the extra doc.

Being able to run without meson in the middle makes debugging
problematic tests simpler IME.

We have direct execution capabilities for all our tests sets
(unit, qtest, functional, block) that devs can use when debugging
an individual failing test, so retaining docs for this is worthwhile.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



      parent reply	other threads:[~2026-11-05  9:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 11:08 [PATCH] docs/devel/testing: iotests check script should be run via 'run' Peter Maydell
2026-11-03 12:22 ` Alex Bennée
2026-11-03 13:26   ` Peter Maydell
2026-11-05  9:34   ` Daniel P. Berrangé
2026-11-05 10:20     ` Peter Maydell
2026-11-05 10:25       ` Daniel P. Berrangé
2026-11-05  8:16 ` Pierrick Bouvier
2026-11-05  9:25   ` Peter Maydell
2026-11-05  9:32   ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auxNJASte9kJ3OXg@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.