From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93DE0606A328 for ; Thu, 5 Nov 2026 10:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HU9Ky5gg Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xOui8-00065j-Vz; Thu, 05 Nov 2026 05:28:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOui3-00062E-JU for qemu-arm@nongnu.org; Thu, 05 Nov 2026 05:28:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOui1-0004M2-Sn for qemu-arm@nongnu.org; Thu, 05 Nov 2026 05:28:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793874521; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=beoCTXwXgtPga18h8hkf+gkXIHVW2MJu8A4Vg/XMQo4=; b=HU9Ky5ggLARTz+4j/k2KEOLPKVkIlW11F00ioNz+wXHJpNtXbcoB2XlwNdQ5I0IoMqbOVf uGrgJMi1u2zKnBygnAcsVT1IzbEKR5NDB+8I+3307Z0dXK/+DRBHBx0YcT/zRPT6CNknh0 GMid6m+zfmfbgzwyu4k1VOy2JRS9ElA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-F6ZWGNpJMw-Pg2F3xWgSYQ-1; Thu, 05 Nov 2026 05:28:35 -0500 X-MC-Unique: F6ZWGNpJMw-Pg2F3xWgSYQ-1 X-Mimecast-MFC-AGG-ID: F6ZWGNpJMw-Pg2F3xWgSYQ_1793874510 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CCE78180120C; Thu, 5 Nov 2026 10:28:28 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B120019AC074; Thu, 5 Nov 2026 10:28:18 +0000 (UTC) Date: Thu, 5 Nov 2026 10:28:15 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: Yonggang Luo , BALATON Zoltan , qemu-devel@nongnu.org, Anthony PERARD , Felipe Balbi , Aleksandar Rikalo , Philippe Mathieu-Daude , Antony Pavlov , Daniel Henrique Barboza , Stefano Stabellini , Subbaraya Sundeep , =?utf-8?B?SGVydsOp?= Poussineau , Max Filippov , Niek Linnenbank , xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org, Jean-Christophe Dubois , qemu-ppc@nongnu.org, Alexandre Iooss , Weiwei Li , Zhao Liu , Jiaxun Yang , Strahinja Jankovic , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , =?utf-8?Q?Cl=C3=A9ment?= Chigot , Mark Cave-Ayland , Yoshinori Sato , Frederic Konrad , Palmer Dabbelt , Peter Maydell , Chao Liu , Sai Pavan Boddu , Alistair Francis , Huacai Chen , Aurelien Jarno , Gaurav Sharma , "Edgar E. Iglesias" , Richard Henderson , Alistair Francis , Artyom Tarasenko , qemu-arm@nongnu.org Subject: Re: [PATCH 00/15] hw: expand DEFINE_MACHINE to explicit TypeInfo registration Message-ID: References: <20261030151539.1872-1-luoyonggang@gmail.com> <54851326-3627-2b86-57d6-c338ed4e4b50@eik.bme.hu> <45433754-3cea-41fc-9f45-65a328d0efca@oss.qualcomm.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <45433754-3cea-41fc-9f45-65a328d0efca@oss.qualcomm.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: aSvcdhbsEqsHm2qW54bsrKxquXZRg2xEPr_TDoaqpU4_1793874510 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 05, 2026 at 12:27:18AM -0800, Pierrick Bouvier wrote: > On 11/3/2026 5:55 AM, Daniel P. Berrangé wrote: > > On Tue, Nov 03, 2026 at 09:48:44PM +0800, Yonggang Luo wrote: > >> On Tue, Nov 3, 2026 at 9:23 PM BALATON Zoltan wrote: > >>> > >>> On Tue, 3 Nov 2026, Yonggang Luo wrote: > >>> That means exposing all the boiler plate for all machines other than the > >>> simplest case. I think it would be better to keep DEFINE_MACHINE_EXTENDED > >>> but maybe rethink the existing wrappers and drop unused ones and maybe add > >>> new ones that reduce the usage of DEFINE_MACHINE_EXTENDED but still keep > >>> the boiler plate hidden. > >> > >> Thanks, I'll go this way, remove unused macros, and keep DEFINE_MACHINE_EXTENDED > >> and extend both DEFINE_MACHINE_EXTENDED DEFINE_MACHINE supports > >> "targets" or "arch_mask" parameter. > > > > Given that we don't need to do general per-arch type filtering in > > QOM, we could just move 'is_available' out of TypeInfo, and into the > > MachineClass, so it is a regular class level property, which can be > > set in the class_init methods, and thus avoid any changes to the > > DEFINE_MACHINE macros. > > > > Some cpus need it also, and it's used for filtering purpose at this time > (to avoid duplication at registration). We already depend on this behavior. Can you give me more info on the problem with the CPUs ? What cases have duplicate class names with CPUs ? With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|