From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 766A0606A328 for ; Thu, 5 Nov 2026 11:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A7vzslFr Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xOvG6-00063R-Rv; Thu, 05 Nov 2026 06:03:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOvFx-00060I-08 for qemu-arm@nongnu.org; Thu, 05 Nov 2026 06:03:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOvFv-0000QQ-30 for qemu-arm@nongnu.org; Thu, 05 Nov 2026 06:03:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793876621; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Fn6tl/YYeO1mb8JqiCmU5l6k1DX2kMyJU6DQdy4pZjM=; b=A7vzslFrO7CJzwgZnViqeYHD/n9WjTadAmillUELdXTJHNuxbAqxMAkx3MwOzJE1YRbTRZ rWC6JBbZAONFPULlAqhohy1LVTn/FvUelhMvPg2sSAtne2v4VHE2rdpLG3l5KKYS73KrLY ykVsCMORg6LmBnibZdRiWC4noOFNROc= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-zbnkrud5OF6OyRRTSrtcTA-1; Thu, 05 Nov 2026 06:03:37 -0500 X-MC-Unique: zbnkrud5OF6OyRRTSrtcTA-1 X-Mimecast-MFC-AGG-ID: zbnkrud5OF6OyRRTSrtcTA_1793876615 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7964418002E6; Thu, 5 Nov 2026 11:03:35 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D679B3001DA0; Thu, 5 Nov 2026 11:03:30 +0000 (UTC) Date: Thu, 5 Nov 2026 11:03:28 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Paolo Bonzini , qemu-arm@nongnu.org, Song Gao <17746591750@163.com>, Matthew Rosato , Philippe Mathieu-Daude , David Hildenbrand , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Fam Zheng , Max Filippov , qemu-s390x@nongnu.org, Jiaxun Yang , "Edgar E. Iglesias" , Eric Farman , Peter Maydell , Cornelia Huck , Pierrick Bouvier Subject: Re: [PATCH v2 09/12] hw/virtio: register s390x virtio-blk-pci and virtio-net-pci variants Message-ID: References: <20261031164009.2048-1-luoyonggang@gmail.com> <20261031164009.2048-10-luoyonggang@gmail.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <20261031164009.2048-10-luoyonggang@gmail.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-MFC-PROC-ID: qxmcBYRz8SNuP2K8zzK-DUqVH1ng7MEeoebMhhlHoso_1793876615 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Sun, Nov 01, 2026 at 12:40:04AM +0800, Yonggang Luo wrote: > virtio-blk-pci and virtio-net-pci added the s390x loadparm property > from class_init when target_s390x() was true. Register each > VirtioPCIDeviceTypeInfo twice. The s390x variant calls > pci_qdev_property_add_specifics(), which now always adds loadparm, > and the other variant does not. target_s390x() and target_not_s390x() select > the two. > > Signed-off-by: Yonggang Luo > --- > hw/pci/pci.c | 13 +++++-------- > hw/virtio/virtio-blk-pci.c | 27 ++++++++++++++++++++++++++- > hw/virtio/virtio-net-pci.c | 27 ++++++++++++++++++++++++++- > 3 files changed, 57 insertions(+), 10 deletions(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 2d2fe02c68e..b5ea0b049aa 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -2901,14 +2901,11 @@ void pci_qdev_property_add_specifics(DeviceClass *dc) > { > ObjectClass *oc = OBJECT_CLASS(dc); > > - /* The loadparm property is only supported on s390x */ > - if (target_s390x()) { > - object_class_property_add_str(oc, "loadparm", > - pci_qdev_property_get_loadparm, > - pci_qdev_property_set_loadparm); > - object_class_property_set_description(oc, "loadparm", > - "load parameter (s390x only)"); > - } > + object_class_property_add_str(oc, "loadparm", > + pci_qdev_property_get_loadparm, > + pci_qdev_property_set_loadparm); > + object_class_property_set_description(oc, "loadparm", > + "load parameter (s390x only)"); > } > > MemoryRegion *pci_address_space(PCIDevice *dev) Again this is the only bit that we need IMHO, as it is harmless to register these properties unconditionally. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|