From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23A10606A32E for ; Thu, 5 Nov 2026 11:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DBa418/v Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xOviv-0007uX-UG; Thu, 05 Nov 2026 06:33:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOviu-0007uH-DG for qemu-devel@nongnu.org; Thu, 05 Nov 2026 06:33:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xOvis-0004fi-RB for qemu-devel@nongnu.org; Thu, 05 Nov 2026 06:33:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793878417; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lo2Wo6IrZCjrrvi/hWWPA3HPKRjzUkvJThJQehMmsWU=; b=DBa418/viM6vRDsyiiT9bgwfJAC1g7bmiYjZrxoqxkZJOe4OtjFXntmB9JWiN0KkSVvhl4 ibc2upf7fWOsqfKtjaFYd/QOO5J453E5NhtgAHx0VL+bwePhM3QgY6RaCZ88XKcjoitlwq 8Hj8lKaqSOfqJTSWxBd7ABxXCii90Qk= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-aEr_zMKXPYiKAPFR27Lc1g-1; Thu, 05 Nov 2026 06:33:34 -0500 X-MC-Unique: aEr_zMKXPYiKAPFR27Lc1g-1 X-Mimecast-MFC-AGG-ID: aEr_zMKXPYiKAPFR27Lc1g_1793878413 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C2E71955F70; Thu, 5 Nov 2026 11:33:33 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34E4B195608B; Thu, 5 Nov 2026 11:33:30 +0000 (UTC) Date: Thu, 5 Nov 2026 11:33:27 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Yonggang Luo Cc: qemu-devel@nongnu.org, David Hildenbrand , Philippe Mathieu-Daude , Matthew Rosato , Paolo Bonzini , Pierrick Bouvier , Cornelia Huck , Fam Zheng , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , Eric Farman Subject: Re: [PATCH 0/3] hw/(pci/scsi/virtio-mem): Avoid call to target_info() in class_init Message-ID: References: <20261013200525.1340-1-luoyonggang@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261013200525.1340-1-luoyonggang@gmail.com> User-Agent: Mutt/2.4.3 (2026-10-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Oct 14, 2026 at 04:05:21AM +0800, Yonggang Luo wrote: > Now we are going to delay the target select to machine select. > So that avoid call to target_info() in class_init so that we wont > face a NULL target_info() error when do class_init. This is because > class_init is called under object_class_get_list(TYPE_MACHINE, false) > > Yonggang Luo (3): > hw/pci: Avoid guard loadparm with target_s390x() for s390x in > class_init > hw/scsi: Avoid guard loadparm with target_s390x() for s390x in > class_init > hw/virtio/virtio-mem: Avoid call to target_info() in class_init > > hw/pci/pci.c | 18 ++++++++++-------- > hw/scsi/scsi-disk.c | 18 ++++++++++-------- > hw/virtio/virtio-mem.c | 12 +++++------- > 3 files changed, 25 insertions(+), 23 deletions(-) If the commit messages are fixed up, Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|