Re: [PATCH 04/11] RDMA/cxi: add the native ABI and resource definitions

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

On Fri, Oct 30, 2026 at 09:35:32PM -0700, Doug Ledford wrote:
> +#include <linux/mod_devicetable.h>

Please drop this include. Even if there was a usage of a *_device_id
this would be wrong.

> [...]
> +struct cxiverbs_lni *cxiverbs_lni_get(struct cxiverbs_ucontext *ctx,
> +				    u32 handle);

unusual indention, please align the continuation line to the opening (.

I would expect that this declaration is added in the same commit as the
actual function.

> +void cxiverbs_lni_put(struct cxiverbs_lni *lni);
> +
> +/* -----------------------------------------------------------------------
> + * Protection domain (ib_pd)  →  shared JobID-anchored LNI + RGID (isolation)
> + *
> + * PD no longer owns its own LNI; instead it references the JobID-anchored LNI
> + * from the ucontext. The PD can optionally express a preferred_svc_id for QPs;
> + * if not set, QPs can select any service at creation.
> + * -----------------------------------------------------------------------
> + */
> +struct cxiverbs_pd {
> +	struct ib_pd    ibpd;
> +	struct cxiverbs_lni *lni_ref;
> +	struct xarray qpns;
> +
> +	u32             job_id;		/* cached from ucontext->job_id */
> +	u32             preferred_svc_id;	/* optional service preference (0 = any) */
> +
> +	u32             rgid;			/* RGID for resource isolation */
> +	u32             pd_id;			/* RGID-based PD identifier */
> +	u32             default_pidonfep;
> +	u32             pidonfep;
> +	u32             qpn_addr_mode;
> +	bool            default_pidonfep_valid;
> +	bool            pidonfep_valid;
> +	struct mutex     resource_lock;
> +};

Please make the alignment here consistent. Either align all members or
none, but not this mixture. My preference would be a single space
because these alignments tend to get annoying when they are kept during
future changes or diverge even more. Same for a few further struct
definitions further down this file.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]