Re: [PATCH 4/5] watchdog: starfive-wdt: Fix runtime PM usage count leaks in probe and remove

[Tzung-Bi Shih <tzungbi@kernel.org>]

On Wed, Nov 04, 2026 at 08:44:44AM -0800, Guenter Roeck wrote:
> When runtime PM is enabled, starfive_wdt_probe() acquires a runtime PM
> reference via pm_runtime_resume_and_get(). On subsequent probe failures,
> err_exit manually disables clocks via starfive_wdt_disable_clock() and
> calls pm_runtime_disable(), without dropping the acquired runtime PM
> reference (and leaving the hardware timer running if early_enable was
> enabled and watchdog_register_device() failed).
> 
> Similarly, when early_enable is set (or the watchdog was left running
> on close), the active runtime PM reference is retained after probe, but
> starfive_wdt_remove() never releases it before calling
> pm_runtime_disable().
> 
> Release the runtime PM reference with pm_runtime_put_sync() on probe
> error paths (stopping the watchdog first if running) and in
> starfive_wdt_remove() when watchdog_hw_running() is still set.
> 
> Fixes: db728ea9c7be ("drivers: watchdog: Add StarFive Watchdog driver")
> Cc: Xingyu Wu <xingyu.wu@starfivetech.com>
> Cc: Ziv Xu <ziv.xu@starfivetech.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>