From: Patrick Steinhardt <ps@pks.im>
To: Derrick Stolee <stolee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/10] commit-graph: several refactorings for writing commit graphs
Date: Thu, 5 Nov 2026 16:33:26 +0100 [thread overview]
Message-ID: <auyhxtMFUwrDJdHT@pks.im> (raw)
In-Reply-To: <ca5986e3-8f66-4628-9f06-eb2416378bef@gmail.com>
On Thu, Nov 05, 2026 at 10:18:51AM -0500, Derrick Stolee wrote:
> On 11/5/2026 8:57 AM, Patrick Steinhardt wrote:
> > On Wed, Nov 04, 2026 at 11:37:11AM -0500, Derrick Stolee wrote:
> >> On 11/4/2026 10:57 AM, Patrick Steinhardt wrote:
> >>> Hi,
> >>>
> >>> this patch series includes several small cleanups for the interfaces for
> >>> writing commit graphs. Most importantly, the series refactors options so
> >>> that they all get passed via `struct commit_graph_write_options`. These
> >>> cleanups are split out of a bigger change to make reading and writing
> >>> commit-graphs pluggable via the object database bakcend.
> >> These cleanups look great. They are carefully constructed to be as
> >> simple as possible at each step. It's good to bring some of these
> >> conventions into a more modern style and to simplify things in the
> >> process.
> >
> > Ah, by the way, one thing I forgot: I noticed this recently already, but
> > you don't reply-to-all and thus lose the Cc's on your replies. That made
> > me miss a couple of your replies already, so I'd appreciate it if you
> > could keep them.
> Sorry about that. I learned that Thunderbird replaced the "Reply All"
> button with a "Reply List" button that led to this unintentional
> behavior. I'll figure out how to change that default.
The joy of random UI updates.
Patrick
prev parent reply other threads:[~2026-11-05 15:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:57 [PATCH 00/10] commit-graph: several refactorings for writing commit graphs Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 01/10] commit-graph: rename `struct commit_graph_opts` Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 02/10] commit-graph: pass writer flags via options Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 03/10] commit-graph: drop `NULL` checks for write options Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 04/10] commit-graph: drop redundant flags in write context Patrick Steinhardt
2026-11-04 19:18 ` Junio C Hamano
2026-11-04 15:57 ` [PATCH 05/10] commit-graph: merge the two commit graph writers Patrick Steinhardt
2026-11-04 16:33 ` Derrick Stolee
2026-11-04 15:57 ` [PATCH 06/10] commit-graph: move remaining write parameters into options Patrick Steinhardt
2026-11-04 16:34 ` Derrick Stolee
2026-11-04 17:49 ` Kristofer Karlsson
2026-11-05 13:20 ` Patrick Steinhardt
2026-11-05 15:07 ` Kristofer Karlsson
2026-11-04 15:57 ` [PATCH 07/10] commit-graph: fix mixup of write/verify flags Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 08/10] builtin/commit-graph: set flags directly Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 09/10] odb/source-files: verify commit-graphs as part of fsck Patrick Steinhardt
2026-11-04 15:57 ` [PATCH 10/10] commit-graph: modernize function names Patrick Steinhardt
2026-11-04 16:37 ` [PATCH 00/10] commit-graph: several refactorings for writing commit graphs Derrick Stolee
2026-11-05 13:55 ` Patrick Steinhardt
2026-11-05 13:57 ` Patrick Steinhardt
2026-11-05 15:18 ` Derrick Stolee
2026-11-05 15:33 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auyhxtMFUwrDJdHT@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.