From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Rodolfo Giometti" <giometti@enneenne.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Angelo Dureghello" <adureghello@baylibre.com>,
"Tobias Sperling" <tobias.sperling@softing.com>,
"Eason Yang" <j2anfernee@gmail.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
duje@dujemihanovic.xyz, herve.codina@bootlin.com,
thomas.petazzoni@bootlin.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
Date: Thu, 5 Nov 2026 16:42:42 +0100 [thread overview]
Message-ID: <auyjgDddFs3OvnC3@monoceros> (raw)
In-Reply-To: <20261030164705.297354-3-maxime.chevallier@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On Fri, Oct 30, 2026 at 05:47:04PM +0100, Maxime Chevallier wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
Please don't include <linux/mod_devicetable.h>. <linux/i2c.h> already
provides i2c_device_id and of_device_id. <linux/mod_devicetable.h>
provides many more *_device_id and thus introduces a big list of
unnecessary dependencies.
I recommend to just drop <linux/mod_devicetable.h> here. If you insist
on full iwyu, there is <linux/device-id/i2c.h> and
<linux/device-id/of.h>.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-05 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 16:47 [PATCH v2 0/2] Add driver for the TI TLA2528 i2c ADC Maxime Chevallier
2026-10-30 16:47 ` [PATCH v2 1/2] dt-bindings: iio: adc: add Texas Instruments TLA2528 Maxime Chevallier
2026-10-30 18:34 ` Conor Dooley
2026-10-30 16:47 ` [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc Maxime Chevallier
2026-10-30 16:58 ` sashiko-bot
2026-10-31 17:30 ` Victor Chernyakin
2026-10-31 23:48 ` Jonathan Cameron
2026-11-02 7:37 ` Rodolfo Giometti
2026-11-04 11:28 ` Maxime Chevallier
2026-11-02 7:22 ` Matti Vaittinen
2026-11-05 15:42 ` Uwe Kleine-König [this message]
2026-11-08 1:32 ` Jonathan Cameron
2026-11-08 8:32 ` Uwe Kleine-König
2026-11-09 17:44 ` Andy Shevchenko
2026-11-10 9:40 ` Uwe Kleine-König
2026-11-10 9:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auyjgDddFs3OvnC3@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=adureghello@baylibre.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=duje@dujemihanovic.xyz \
--cc=giometti@enneenne.com \
--cc=herve.codina@bootlin.com \
--cc=j2anfernee@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marilene.agarcia@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tobias.sperling@softing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.