From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D2C606D80A for ; Thu, 5 Nov 2026 15:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=KXWwKFbR Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4543110E31B; Thu, 5 Nov 2026 15:46:14 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DBCB112811 for ; Thu, 5 Nov 2026 15:46:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5FBD216F2 for ; Thu, 5 Nov 2026 07:46:04 -0800 (PST) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 408393F628 for ; Thu, 5 Nov 2026 07:46:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1793893567; bh=wKC4AEsKB2DtuCnSe/7pu3714mg2y6dLky3w4oPWMs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KXWwKFbRg/6tIbItZkSHA175lkIZD6B0hIzFGcpQGNHliLPr77mZQ5RE7dksYpcpK C73hp/YLZPJk2bo3+lamzltUcrX4+JAiS15SsfA5e+XhHBz0q4sXSrr4IH/rVhVlpA MDleNj79ILoxt5srx3T8tAUXt1vbWUILdK5D2b9E= Date: Thu, 5 Nov 2026 15:46:00 +0000 From: Liviu Dudau To: Maxime Ripard Cc: David Airlie , Maarten Lankhorst , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH RESEND 04/83] drm/komeda: Switch to drm_mode_config_create_initial_state Message-ID: References: <20261105-drm-no-more-config-reset-v1-0-1f58d1e33380@kernel.org> <20261105-drm-no-more-config-reset-v1-4-1f58d1e33380@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261105-drm-no-more-config-reset-v1-4-1f58d1e33380@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 05, 2026 at 04:29:13PM +0100, Maxime Ripard wrote: > drm_mode_config_reset() has a dual role: it creates the initial KMS > state at probe time, and resets hardware and software state during > suspend/resume cycles. > > Since the two roles need different behaviors (notably for objects like > drm_private_obj that must persist across suspend/resume), > drm_mode_config_create_initial_state() was introduced to handle only > the initial state creation at probe time. > > Switch to drm_mode_config_create_initial_state(). > > Signed-off-by: Maxime Ripard Reviewed-by: Liviu Dudau Best regards, Liviu > --- > Cc: Liviu Dudau > --- > drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > index faa8b041373a..66854c6cc03f 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > @@ -310,5 +310,7 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev) > goto cleanup_mode_config; > > - drm_mode_config_reset(drm); > + err = drm_mode_config_create_initial_state(drm); > + if (err) > + goto cleanup_mode_config; > > err = devm_request_irq(drm->dev, mdev->irq, > > -- > 2.55.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯