Re: [PATCH 2/2] object-file: return error on index-pack abnormal exit

[Justin Tobler <jltobler@gmail.com>]

On 26/11/04 03:06PM, Junio C Hamano wrote:
> Justin Tobler <jltobler@gmail.com> writes:
> > -		if (ret) {
> > +		if (report_err) {
> >  			strbuf_addstr(err_msg, "index-pack failed to report pack name");
> > +			ret = -1;
> >  			goto out;
> >  		}
> 
> I guess this also does not change a behaviour?  We used to relay the
> error status returned by read_index_pack_report(), but now we force
> the error code to an explicit -1.

That is correct, there is no behavior change here. The main change is
that `finish_command()` properly reports its error and is not
overwritten by `read_index_pack_report()`.

[snip]
> 
> Will queue.  Thanks.

Thanks for the review,
-Justin