All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jelly Jia <Jelly.Jia@cixtech.com>
To: Brian Masney <masneyb@kernel.org>
Cc: vkoul@kernel.org, Frank.Li@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, robin.murphy@arm.com,
	sboyd@kernel.org, bmasney+clk@redhat.com,
	jbrunet+clk@baylibre.com, tglx@kernel.org,
	devicetree@vger.kernel.org, cix-kernel-upstream@cixtech.com,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	joakim.zhang@cixtech.com, radu@rendec.net
Subject: Re: [PATCH v4 3/5] clk: cix: Register the Sky1 AUDSS IRQ auxiliary device
Date: Fri, 20 Nov 2026 09:51:29 +0800	[thread overview]
Message-ID: <av+noTCzllh8pjJM@ubuntu> (raw)
In-Reply-To: <179505256752.187996.952601612639868708.b4-review@b4>

Hi Brian,

Thanks for the review.

> This, along with the defines should go in a separate commit.

Agreed. I'll move the INFO_AP_IRQC and INFO_SW_RESETN definitions
and their save/restore entries into a separate patch.

> I don't care which pattern you use but make it consistent within this
> driver.

I'll make the IRQ registration helper follow the existing reset
helper's #if IS_ENABLED() pattern, including the stub when disabled.

> Should this be a separate patch?

The reset_control_assert() error check is independent of the IRQ
integration. I'll drop that extra change from this series, leaving
the existing error-handling behaviour unchanged. The additional ret
variable will therefore no longer be needed.

> The IRQ driver uses the new pm_ptr(). Please use that.

The clock driver already uses pm_ptr() for its .pm pointer, but still
uses the SET_* PM macros. I'll switch to RUNTIME_PM_OPS() and
NOIRQ_SYSTEM_SLEEP_PM_OPS(), matching the IRQ driver, and remove
the unnecessary __maybe_unused annotations. The noirq suspend/resume
ordering will be retained.

I'll also remove the added bits.h include.

Best regards,
Jelly

  reply	other threads:[~2026-11-20  1:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:44 [PATCH v4 0/5] soc: cix: Add the Sky1 AUDSS DMA-350 interrupt path Jelly Jia
2026-11-17  9:44 ` [PATCH v4 1/5] dt-bindings: soc: cix: Describe the Sky1 AUDSS DMA IRQ controller Jelly Jia
2026-11-18 19:10   ` Rob Herring (Arm)
2026-11-17  9:44 ` [PATCH v4 2/5] irqchip: Add the Sky1 AUDSS auxiliary interrupt controller Jelly Jia
2026-11-17  9:44 ` [PATCH v4 3/5] clk: cix: Register the Sky1 AUDSS IRQ auxiliary device Jelly Jia
2026-11-19  1:42   ` Brian Masney
2026-11-20  1:51     ` Jelly Jia [this message]
2026-11-17  9:44 ` [PATCH v4 4/5] dt-bindings: dma: arm,dma-350: Document dma-channel-mask Jelly Jia
2026-11-17  9:44 ` [PATCH v4 5/5] dmaengine: arm-dma350: Honour dma-channel-mask Jelly Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av+noTCzllh8pjJM@ubuntu \
    --to=jelly.jia@cixtech.com \
    --cc=Frank.Li@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=joakim.zhang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masneyb@kernel.org \
    --cc=radu@rendec.net \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sboyd@kernel.org \
    --cc=tglx@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.