All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <masneyb@kernel.org>
To: Joseph Telaak <joseph@telaak.dev>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney+clk@redhat.com>,
	"Jerome Brunet" <jbrunet+clk@baylibre.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Chuanhong Guo" <gch981213@gmail.com>, "Yao Zi" <me@ziyao.cc>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] clk: siflower: Add SF19A2890 clock manager driver
Date: Thu, 19 Nov 2026 18:16:30 -0500	[thread overview]
Message-ID: <av-DThJFadNXhC0F@x1g10> (raw)
In-Reply-To: <CAPY4CJ6DjoKi9v3Bk0Pt7ePRW_yiNiUzfX1id7efK8i8cUWFaw@mail.gmail.com>

On Thu, Nov 19, 2026 at 04:31:01PM -0500, Joseph Telaak wrote:
> On Thu, Nov 19, 2026 at 02:00:06PM -0500, Brian Masney wrote:
> > Can this declared as a regular platform driver? We are trying to
> > minimize the use of CLK_OF_DECLARE.
> 
> The MIPS GIC timer runs from CLK_MUXDIV_CPU, and it probes from
> TIMER_OF_DECLARE in time_init(), before any platform driver. As a
> platform driver, the clock would not exist yet when the timer calls
> of_clk_get(), and with no clock-frequency to fall back on, the SoC would
> have no clocksource. I'll say that in a comment above CLK_OF_DECLARE in
> v4.

If possible, declare just the timer clock with CLK_OF_DECLARE, and the
rest as a platform driver.

Brian

  reply	other threads:[~2026-11-19 23:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 22:04 [PATCH v3 0/4] clk: Add the Siflower SF19A2890 clock manager and peripheral clock and reset managers Joseph Telaak via B4 Relay
2026-11-16 22:04 ` Joseph Telaak
2026-11-16 22:04 ` [PATCH v3 1/4] dt-bindings: clock: Add Siflower SF19A2890 clock manager Joseph Telaak via B4 Relay
2026-11-16 22:04   ` Joseph Telaak
2026-11-16 22:04 ` [PATCH v3 2/4] clk: siflower: Add SF19A2890 clock manager driver Joseph Telaak via B4 Relay
2026-11-16 22:04   ` Joseph Telaak
2026-11-19 19:00   ` Brian Masney
2026-11-19 21:31     ` Joseph Telaak
2026-11-19 23:16       ` Brian Masney [this message]
2026-11-16 22:04 ` [PATCH v3 3/4] dt-bindings: clock: Add Siflower SF19A2890 peripheral clock/reset managers Joseph Telaak via B4 Relay
2026-11-16 22:04   ` Joseph Telaak
2026-11-16 22:04 ` [PATCH v3 4/4] clk: siflower: Add SF19A2890 peripheral clock and reset manager driver Joseph Telaak via B4 Relay
2026-11-16 22:04   ` Joseph Telaak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av-DThJFadNXhC0F@x1g10 \
    --to=masneyb@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gch981213@gmail.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=joseph@telaak.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=me@ziyao.cc \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.