All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx+linux-man@kernel.org>
To: Tingmao Wang <m@maowtm.org>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	"Günther Noack" <gnoack3000@gmail.com>,
	linux-man@vger.kernel.org
Subject: Re: [PATCH] man/man2/landlock_add_rule.2: Add a missing EINVAL case
Date: Fri, 20 Nov 2026 00:24:58 +0100	[thread overview]
Message-ID: <av-FNlfcTNAu-yf3@devuan> (raw)
In-Reply-To: <20261119170554.224641-1-m@maowtm.org>

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi Tingmao,

> Date: 2026-11-19 17:05:53+0000
> From: Tingmao Wang <m@maowtm.org>
>
> This is another way it can return EINVAL but is not documented.  Documenting
> it is useful to help rule out errors.
> 
> This syncs this doc with the same change in the kernel [1].
> 
> Link: https://lore.kernel.org/linux-security-module/20261116233139.206924-1-m@maowtm.org/ [1]
> Signed-off-by: Tingmao Wang <m@maowtm.org>

Thanks!  I've applied the patch.


Have a lovely night!
Alex

> ---
>  man/man2/landlock_add_rule.2 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/man/man2/landlock_add_rule.2 b/man/man2/landlock_add_rule.2
> index 253498bfa..f6a812c7f 100644
> --- a/man/man2/landlock_add_rule.2
> +++ b/man/man2/landlock_add_rule.2
> @@ -206,6 +206,10 @@ .SH ERRORS
>  is not valid.
>  .TP
>  .B EINVAL
> +.I rule_type
> +is not valid.
> +.TP
> +.B EINVAL
>  The rule accesses are inconsistent (i.e.,
>  .I rule_attr\->allowed_access
>  is not a subset of the ruleset handled accesses).
> -- 
> 2.56.1
> 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2026-11-19 23:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 17:05 [PATCH] man/man2/landlock_add_rule.2: Add a missing EINVAL case Tingmao Wang
2026-11-19 23:24 ` Alejandro Colomar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av-FNlfcTNAu-yf3@devuan \
    --to=alx+linux-man@kernel.org \
    --cc=gnoack3000@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=m@maowtm.org \
    --cc=mic@digikod.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.