From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795132001; b=1mz2179GPE3BT7T/d7pxnH/l31NdI8+PBfT+K0Q4bLdK+rmuvES3+8+RtNiKl3T3jxHI SKe50FWZTVS0Fin5WRO0PbkgjdSZC9K622sI8gZxyLR0CwDcjmQtlLwX8/lEgP9SRfsOA 4MIiHEho7WoJ+xcyDeAxNzeIOqaACB/lYYxgCvB/ylfhN9+B5IMVI3OYi3XZoRhOjZ51E 1Ixhrdi9YJiEdUnkQS5v7hyRFBy/HL16MtrFsdWh/WVZBSMMfnrZbI/a/a1Eqz8k+6Spr wcrfFJCtLpUBLhD/2vilnx+B8y9rNJNOWh2jV/Fg6Cq9xWESUcsJPLrrxu2knJyYZQQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795132001; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:Message-ID:Subject:From:To:Cc:Content-Type; bh=Mmj7uiRX9ASaqnLzbDsK8IjMEcNt8OmjrVBlhYSaY/Y=; b=FlsjY2YzZ7iFVQ7ykkZd3Lw294oCRw4QK4LC30t0yYgaiNS5eKwFilbPY6Ci8JI+jHKo +748kbor4jUoZAwUlvULhGG+5IkOIdy8gok5tLpw+pae6VR6ZOIhlurYxsMUEXy8q6Lci RvD0+/BuKgxfg5daS0ySRRfE4malGael8MvCtx824ujNtbHO7pYRnS27roHOjIUDgKSgN cvD1rslbCXrfv9oSw+G8bvHvdNANWvd6mTXAySq/0QkhwofXAyswOzpoaPPsitVDpZqoh 7/hFc5Xpal0oimTeyZ2klUO3uPBWfMCBAiM/pY+1Ha1/ihx2YGemPMaTU7TKoY5W+Ig== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=PfPCB2B8; arc=none smtp.remote-ip=209.85.215.200 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CCE606A325 for ; Thu, 19 Nov 2026 23:46:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A8CCE606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=PfPCB2B8 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cdd769cc9deso162112a12.0 for ; Thu, 19 Nov 2026 15:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1795132000; x=1795736800; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Mmj7uiRX9ASaqnLzbDsK8IjMEcNt8OmjrVBlhYSaY/Y=; b=PfPCB2B8+jbTRNukEIfvY9mNcYdpPVkb7icW4/v3iBUNHJl1OOE1qUKWzozDd37S13 sjjeX8nHWD5DHa+nn1EGYsbLhtcJ4LAgbPeclqFWYNmuogs1K+ig03ihqqClRx4yBVVA uGirnnCCqpqQvpOlveAjpUKeezcO0yAWpFRC/wocIi4tpsNXdwKEorXv9uCc9Xd3Dh6r 2O4AFlC7eDx3biYhffE5Nu4LaxZh/uwAkaRq8mfhaEqjhmiFpdtDp2GhQxsEY9cVmzbN AlMJ2UHz/yfsGi/S6QsHYhN0aO4BnMS2jUDMziOlJMft+cA4DEwIxQdTLWCaHziLurHH O5hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795132000; x=1795736800; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Mmj7uiRX9ASaqnLzbDsK8IjMEcNt8OmjrVBlhYSaY/Y=; b=o0B1zfF6j548K+ZlE/oh7Ap0Mkiq8sAnr5vtPQLm7V96jzSwlhqoD1yb+AA5XjRDPj m3zqmPK89JcUUdjlgdGJwmNjlNBnphvrMJnk0a35i23EzPS/efToxKrAfmnNcMDf+iMy Zv1oz/QxssRVNPjdq/iK/rL+I2YVqYaEmG+BDuHcTQWRHnk4y2T4R1j/SP8A6yzwtS1V SLPWf2wk9k8jfHIV8yIK5a4lWgRUmR3rqnvknYHE6o2Wg7shVki+Id4SufdlyJDrk17z g/7T0ingmtKYQDaS78o0+pf9Y+x0S2qMLAV5alRHtcrQyWfEgA3fideot/Hdd0+f+Ol5 krXQ== X-Forwarded-Encrypted: i=1; AL+hErEzfz1HGhiqwXxlkFe+x4+/xujpAdqAfkBOLfjE9XPcGKGNz6E+Q7R4045Ls8xeaSVoy6U=@vger.kernel.org X-Gm-Message-State: APuU4Z/Pm3SRdyeZK8QIYwI109e/iCjycd8QxhYwR0xPpeOhuvAIjt+a MvgKwmoEf66TISFqpi2twJEol272VUyuCn7NozNtVCyPsiHIYXRXEo/bL8OmxC5014KJXpwOYyw MXRB++A== X-Received: from pjbbx13.prod.google.com ([2002:a17:90a:f48d:b0:3b1:cec2:5b9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2d88:b0:3b4:e6e:1aba with SMTP id 98e67ed59e1d1-3b41c96fdacmr908217a91.59.1795131999774; Thu, 19 Nov 2026 15:46:39 -0800 (PST) Date: Thu, 19 Nov 2026 15:46:38 -0800 In-Reply-To: <6aff732e.d9dac7f4.1ece0.0000.GAE@google.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <6aff732e.d9dac7f4.1ece0.0000.GAE@google.com> Message-ID: Subject: Re: [syzbot] [kvm-x86?] WARNING in __nested_vmx_vmexit From: Sean Christopherson To: syzbot Cc: bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, pbonzini@redhat.com, syzkaller-bugs@googlegroups.com, tglx@kernel.org, x86@kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Nov 19, 2026, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 7475ea8b5861 Linux 7.4-rc2 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=12372a4e580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=1cf189394a856f11 > dashboard link: https://syzkaller.appspot.com/bug?extid=483ee9b97423483ca602 > compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1360d4d9580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17839409580000 > > Downloadable assets: > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-7475ea8b.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/db4e8a9a4461/vmlinux-7475ea8b.xz > kernel image: https://storage.googleapis.com/syzbot-assets/2abcfcabee20/bzImage-7475ea8b.xz > > AI-generated root cause summary: > When an L1 vCPU encounters a hardware VM-Fail on VM-Entry, `vmx_handle_exit()` > processes the failure and returns KVM_EXIT_FAIL_ENTRY to userspace without > clearing the `vmx->fail` flag. If userspace then calls KVM_SET_NESTED_STATE with > KVM_STATE_NESTED_GUEST_MODE set, the vCPU enters guest mode without resetting > `vmx->fail`. If the VM is subsequently torn down without another KVM_RUN, > `vmx_leave_nested()` synthesizes a nested VM-exit where `__nested_vmx_vmexit()` > observes the stale `vmx->fail == 1` and reads VM_INSTRUCTION_ERROR from vmcs02 > (which was never launched), triggering a WARN_ON_ONCE because > VM_INSTRUCTION_ERROR is not VMXERR_ENTRY_INVALID_CONTROL_FIELD. > > full analysis: https://syzkaller.appspot.com/x/ai_root_cause?x=483ee9b97423483ca602 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+483ee9b97423483ca602@syzkaller.appspotmail.com > > kvm_intel: set kvm_intel.dump_invalid_vmcs=1 to dump internal KVM state. > ------------[ cut here ]------------ > vmcs_read32(VM_INSTRUCTION_ERROR) != VMXERR_ENTRY_INVALID_CONTROL_FIELD > WARNING: arch/x86/kvm/vmx/nested.c:5149 at __nested_vmx_vmexit+0x2734/0x4000 arch/x86/kvm/vmx/nested.c:5149, CPU#1: syz.0.17/6007 > Modules linked in: > CPU: 1 UID: 0 PID: 6007 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 > RIP: 0010:__nested_vmx_vmexit+0x2734/0x4000 arch/x86/kvm/vmx/nested.c:5149 > Code: ff ff e8 0f a0 67 00 90 bf 0e 44 00 00 e8 c4 ed f8 ff 90 31 db e9 01 ec ff ff e8 f7 9f 67 00 e8 f2 1b 48 0a e8 ed 9f 67 00 90 <0f> 0b 90 e9 6a ff ff ff e8 df 9f 67 00 90 bf 00 44 00 00 e8 94 ed > RSP: 0018:ffffc9000338f960 EFLAGS: 00010293 > RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 > RDX: ffff88802c514b00 RSI: ffffffff81a6e113 RDI: 0000000000000005 > RBP: ffffc9000338fac0 R08: 0000000000000007 R09: 0000000000000000 > R10: ffff888035f7003f R11: 0000000000000000 R12: 0000000000000001 > R13: ffff8880382442ec R14: 0000000000000000 R15: ffff888035f70000 > FS: 00005555645d0500(0000) GS:ffff8880d4571000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000055b5cc929ff0 CR3: 000000003db67000 CR4: 0000000000352ef0 > Call Trace: > > nested_vmx_vmexit arch/x86/kvm/vmx/nested.h:46 [inline] > vmx_leave_nested arch/x86/kvm/vmx/nested.c:6895 [inline] > nested_vmx_free_vcpu+0xb3/0xd0 arch/x86/kvm/vmx/nested.c:389 > vmx_vcpu_free+0x94/0x340 arch/x86/kvm/vmx/vmx.c:7519 > kvm_arch_vcpu_destroy+0x159/0x3e0 arch/x86/kvm/x86.c:9558 > kvm_vcpu_destroy virt/kvm/kvm_main.c:477 [inline] > kvm_destroy_vcpus+0x24e/0x3c0 virt/kvm/kvm_main.c:497 > kvm_arch_destroy_vm+0xc7/0x230 arch/x86/kvm/x86.c:10129 > kvm_destroy_vm virt/kvm/kvm_main.c:1313 [inline] > kvm_put_kvm+0x556/0xc00 virt/kvm/kvm_main.c:1350 > kvm_vm_release+0x65/0x80 virt/kvm/kvm_main.c:1375 > __fput+0x3fb/0xb50 fs/file_table.c:512 > fput_close_sync+0x118/0x250 fs/file_table.c:618 > filp_close_sync+0x75/0xa0 fs/open.c:1574 > __range_close+0x4a6/0x8b0 fs/file.c:919 > __do_sys_close_range fs/file.c:1003 [inline] > __se_sys_close_range fs/file.c:954 [inline] > __x64_sys_close_range+0x1f8/0x430 fs/file.c:954 > do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline] > do_syscall_64+0x123/0x7b0 arch/x86/entry/syscall_64.c:89 > entry_SYSCALL_64_after_hwframe+0x77/0x7f > RIP: 0033:0x7f5f6ab9fb19 > Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007fff0931e598 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4 > RAX: ffffffffffffffda RBX: 00007fff0931e680 RCX: 00007f5f6ab9fb19 > RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003 > RBP: 000000000000e232 R08: 0000000000000001 R09: 0000000000000000 > R10: 0000001b2fb20000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007f5f6ae25fac R14: 00007f5f6ae25fa8 R15: 00007f5f6ae25fa0 > Oh, _now_ you find it on an upstream kernel? :-D This presumably the same thing that was fixed by: #syz test https://github.com/kvm-x86/linux.git 40c0e9dd6b6dfbdbbdbf5d7936d2819b2d84d25c