From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.193 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795134724; b=k5h3KbHAr726wxu86xwm0nAuDKnUV3olya6R3z+fqMhD7RBSC/0E1cTgk8+pDgJ2bsql eV2LNNcY7bGP8ffCKWRDXvzFwTG+l13x2/BfNodhFSIUvYGB0xqyb+y29qAYhtL93SekY Nu21BvkBd446ebk7F2yc/Ns+eOF97cn4vajzVMOnKwzRHv7LiknEIEgtaK9C1N1xS5aO4 YG7QhsD2LKg/qWpiZtND5jsc6GbnGBnspMqUtt+3ZmaDLZ0tLmYhpv18ygxj3du1hbn/J 3I1BD3P1qxLApHWtLoGAijidzCWlJ6Lg2tPmOOQertneK1gZ0bKJpTtdehMmTcwD2wQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795134724; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=qHpbo38glsjEEsMsljy1CpA8VnvlF4qhosKL0SjyrSU=; b=bgw3iICXBFPEPbppYuman/XGoHmfa7P2T9M0U1+D7wG9MZ6B+BmUrABQmi/nxL+dZ16y Oeo+c0hHDu7zDM6XLoz+JWsUjOXJzpb1vtSBeTJuvFL0C8czHVrmCPHn2+3CgFGkmh30I 0bSElCE6Uj3Zs55oAgr+FWbakjLweQAledRQEZ3dVfZ3IcBjh4VR6fcifQM+vPHY2lQsw PMUxqFeNVhOjPgnzZ5opu3gdMGb3xfa9NSpMjXQqbmCX+XT8j7MkopcXZRKwh/Np81Acy 8Hw7LnmClS6IjezTxYpg5niwWLyrHGwvZF/TQu6ASnkWIF06Q3GdB4H/USFykTYSN1w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=phY967kf; arc=none smtp.remote-ip=74.125.82.193 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE1360A261F for ; Fri, 20 Nov 2026 00:32:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org ACE1360A261F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=phY967kf Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-36a315ed211so332131eec.0 for ; Thu, 19 Nov 2026 16:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795134723; x=1795739523; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qHpbo38glsjEEsMsljy1CpA8VnvlF4qhosKL0SjyrSU=; b=phY967kf9V0w4X6QO0EE5tjsrC4Tea3WS0nk6BNiGcR+p3FtIb0e9GLhbL+NMk9zMG qmfj6SqSfdH6XH/AhJsTiFEepvy7zHzzymWFflDAI6L44/pGPpmfiR5jfIOmzN7Y+PkA PhsgMlkztWXiRGkox/4ArWbKtc3xJq0ZcZ43TOZSFprhwZMVfIOVNK/RVqDrIUYkloMo HAUFx9Yx6xg37Z8tTkyJmk2MofiQ1dClNMNz6tawKx5sLyRG/hQ+SbNZE4xOMJ+8O1yb dQIrb9IMG4U2I/83GqX7E4RME7I04WEF/d9PU4W3Riz1Jhk9iATiZvURXlj2KqLotPbb osdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795134723; x=1795739523; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qHpbo38glsjEEsMsljy1CpA8VnvlF4qhosKL0SjyrSU=; b=0RahLEhv3DF+tiRpaMR1yxQ2/zU021wqZ4UH9Jzle5Nva5chbvcE40ikX8BAa05irO lh+x7hiAX5rN3eobWe6UsIdmQh/q/di6SjqTdJTzD2bSR7rohG/2AWQt9aa4Kmla5psD Fy7nUd3GzdyTjVjjWhJGLepgLhwOBWxpOrIa2m4ao+ePyR0VUqOagMtxgTcagJ9tXKUu /kTrW37trGADlJ7d2Qz1k+388z9hAmDTT47NqFQYt6nPyIVF+2foSJTPFS6oAoPXY1zg Xx2rsc70aOSSlt2Opa30zUEqGSJaxEn40QRqaSN6kZZxfL6rFdf6kvrx1LPsMvdLS7CG ug9g== X-Forwarded-Encrypted: i=1; AL+hErEWJC1VR0ZEXr+RqlycM+WbhB3zUB+2uDi48ZVt+v5DwDaheOyihlzKoZdFZ2TodY7UYTE4rFTUAuxZjtS/hQY=@vger.kernel.org X-Gm-Message-State: APuU4Z9u414OsAf1/j0v61X5qkc/aO+cmjMXgNHkfbbxvcT46Gpj2cnW AvvkO1RUq/lDE7OZxkUcJBDYVGHrByWTQkkpMwBn5zN7EqXS2fVC/o77 X-Gm-Gg: AZFdTZeOech2lRSUCUL8Q3A+zgCdeFcYLfE1HlIvAL4FZbJxgjMKzd9yS25xxDLdIsN mixwBoPV7kK58SWiU3PIJFOtdplTzSUutdIySj/9zfzlN8HzRaqWsayssBORA2V5L8kquN/0dR5 DkLKuVQJvdOP/TN2wYAt4SI7XblbQDgbFCH7G/3dJj4bQ9Ovhzd5sN3oSPoyzE4FfsdJw+1lv8S L6wv9EbCW8f/MXAvG9Miw9HifUJI9X1QHExnLMW7yWOOvgrcjRXBJt1/08d16Dn9RKYZM0D41nh y12mNjfmNm6++PQP88v92kPggDhhSfF3h9gIp/uma0lUUSwW+cK+7RFs+IgZZmjd3P29DKCnJxK iMRxhKDd4gMDhG+MN0xdqqLY5rdQxSAf0BLqXYVT1VMVG7WW8iWhdFXsuD00o6JkFHf7Ej5a3bk zY+rkRgoUOtaoU3RYycyXIl1B3P6GHoQNArwlV7vw0BNVHtJXiqrcIUrYWoS5FYCVRklc011Ak/ 7Uu73JdrCfokh/i/ARQ85auynjMK2bvb6RmntRHewX+Mc7MoPgNs+WukFmeCuRz5he0/D5/cueI cEllP+gH6YmEAq2N9uKFp30= X-Received: by 2002:a05:7300:d583:b0:384:d6eb:ec7c with SMTP id 5a478bee46e88-384d6ebf259mr2588423eec.22.1795134722796; Thu, 19 Nov 2026 16:32:02 -0800 (PST) Received: from localhost ([2a03:2880:9ff:67::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-385616f0a3fsm2195980eec.0.2026.11.19.16.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 16:32:02 -0800 (PST) Date: Thu, 19 Nov 2026 16:31:55 -0800 From: Stanislav Fomichev To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Alexander Duyck , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Jesper Dangaard Brouer , Stanislav Fomichev , Magnus Karlsson , Maciej Fijalkowski , Pavel Begunkov , netdev@vger.kernel.org, bpf@vger.kernel.org, Simon Horman , Shuah Khan , Randy Dunlap , kernel-team@meta.com, John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Weiming Shi , Nikolay Aleksandrov , David Wei , Bobby Eshleman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, io-uring@vger.kernel.org, Mina Almasry Subject: Re: [PATCH net-next 7/7] selftests: net: Test XDP on io_uring RX Message-ID: References: <20261117164700.2157816-1-bjorn@kernel.org> <20261117164700.2157816-8-bjorn@kernel.org> X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261117164700.2157816-8-bjorn@kernel.org> On 11/17, Björn Töpel wrote: > Native XDP must not access io_uring payload through normal packet > helpers. Compare ordinary page-backed RX with an io_uring RX queue. > Check header, fragment and boundary access, and verify the received > bytes through recv() and RECV_ZC. > > Probe support by binding io_uring first and attaching a frags-aware > XDP_PASS program. Skip unsupported combinations, but fail later > attach, verifier and data-path checks. Require non-linear packets on > the selected queue. Use XDP links so the test cannot replace another > program, and restore header split, RSS and the flow rule. > > An AI review found that ignoring io_uring setup errors could turn them > into capability skips. A process-local seccomp filter returning EPERM > reproduced this. The new XDP test now treats setup errors as failures. > > Signed-off-by: Björn Töpel > --- > MAINTAINERS | 2 + > .../selftests/drivers/net/hw/.gitignore | 1 + > .../testing/selftests/drivers/net/hw/Makefile | 10 +- > tools/testing/selftests/drivers/net/hw/config | 5 + > .../selftests/drivers/net/hw/iou-zcrx.c | 242 +++++++++++++++++- > .../selftests/drivers/net/hw/iou-zcrx.py | 108 +++++++- > .../selftests/drivers/net/hw/iou_zcrx.bpf.c | 111 ++++++++ > .../selftests/drivers/net/hw/iou_zcrx.h | 34 +++ > 8 files changed, 492 insertions(+), 21 deletions(-) > create mode 100644 tools/testing/selftests/drivers/net/hw/iou_zcrx.bpf.c > create mode 100644 tools/testing/selftests/drivers/net/hw/iou_zcrx.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 32e218c0fe68..ea383dd81668 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14076,6 +14076,8 @@ T: git https://github.com/isilence/linux.git zcrx/for-next > T: git git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git > S: Maintained > F: io_uring/zcrx.* > +F: tools/testing/selftests/drivers/net/hw/iou-zcrx.* > +F: tools/testing/selftests/drivers/net/hw/iou_zcrx.* > > IO_URING BPF-OPS > M: Pavel Begunkov > diff --git a/tools/testing/selftests/drivers/net/hw/.gitignore b/tools/testing/selftests/drivers/net/hw/.gitignore > index 911a9bfeaf41..085aa8b17afc 100644 > --- a/tools/testing/selftests/drivers/net/hw/.gitignore > +++ b/tools/testing/selftests/drivers/net/hw/.gitignore > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > iou-zcrx > +iou_zcrx.skel.h > ncdevmem > tls_hw_offload > toeplitz > diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile > index 429cb545a4f0..d7a1fea08ea7 100644 > --- a/tools/testing/selftests/drivers/net/hw/Makefile > +++ b/tools/testing/selftests/drivers/net/hw/Makefile > @@ -10,7 +10,8 @@ HAS_IOURING_ZCRX := $(shell \ > echo -e '#include \n' \ > 'void *func = (void *)io_uring_register_ifq;\n' \ > 'int main() {return 0;}' | \ > - $(CC) -luring -x c - -o /dev/null 2>&1 && echo y) > + $(CC) $(CFLAGS) $(CPPFLAGS) $(USERCFLAGS) $(LDFLAGS) \ > + $(USERLDFLAGS) -x c - -o /dev/null -luring 2>&1 && echo y) > > ifeq ($(HAS_IOURING_ZCRX),y) > COND_GEN_FILES += iou-zcrx > @@ -98,5 +99,10 @@ include ../../../net/ynl.mk > include ../../../net/bpf.mk > > ifeq ($(HAS_IOURING_ZCRX),y) > -$(OUTPUT)/iou-zcrx: LDLIBS += -luring -lpthread > +$(OUTPUT)/iou-zcrx: CFLAGS += -I$(OUTPUT) -I$(SCRATCH_DIR)/include > +$(OUTPUT)/iou-zcrx: LDLIBS += -luring -lpthread -lelf -lz > +$(OUTPUT)/iou-zcrx: LOCAL_HDRS += iou_zcrx.h $(OUTPUT)/iou_zcrx.skel.h > +$(OUTPUT)/iou-zcrx: iou_zcrx.h $(OUTPUT)/iou_zcrx.skel.h $(BPFOBJ) > endif > + > +$(OUTPUT)/iou_zcrx.bpf.o: iou_zcrx.h $(selfdir)/bpf/bpf_kfuncs.h > diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config > index 081155bf7847..ef77543b567f 100644 > --- a/tools/testing/selftests/drivers/net/hw/config > +++ b/tools/testing/selftests/drivers/net/hw/config > @@ -1,4 +1,6 @@ > +CONFIG_BPF_JIT=y > CONFIG_BPF_SYSCALL=y > +CONFIG_DEBUG_INFO_BTF=y > CONFIG_FAIL_FUNCTION=y > CONFIG_FAULT_INJECTION=y > CONFIG_FAULT_INJECTION_DEBUG_FS=y > @@ -9,6 +11,7 @@ CONFIG_INET6_ESP_OFFLOAD=y > CONFIG_INET_ESP=y > CONFIG_INET_ESP_OFFLOAD=y > CONFIG_IO_URING=y > +CONFIG_IO_URING_ZCRX=y > CONFIG_IPV6=y > CONFIG_IPV6_GRE=y > CONFIG_IPV6_SIT=y > @@ -20,7 +23,9 @@ CONFIG_NET_IPGRE=y > CONFIG_NET_IPGRE_DEMUX=y > CONFIG_NET_IPIP=y > CONFIG_NETKIT=y > +CONFIG_NET_RX_BUSY_POLL=y > CONFIG_NET_SCH_INGRESS=y > +CONFIG_PAGE_POOL=y > CONFIG_SYNC_FILE=y > CONFIG_TLS=y > CONFIG_TLS_DEVICE=y > diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > index 91b025a8771e..f7e909fd6840 100644 > --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -37,9 +38,13 @@ > #include > #include > > +#include > #include > #include > +#include "kselftest.h" > #include "netdev-user.h" > +#include "iou_zcrx.h" > +#include "iou_zcrx.skel.h" > > #define SKIP_CODE 42 > > @@ -89,7 +94,11 @@ static struct sockaddr_in6 cfg_addr; > static unsigned int cfg_rx_buf_len; > static bool cfg_dry_run; > static int cfg_num_threads = 1; > +static bool cfg_xdp; > +static bool cfg_pages; > > +static struct iou_zcrx *xdp_skel; > +static int xdp_link = -1; > static char *payload; > > #define MAX_CONNS_PER_THREAD 64 > @@ -154,6 +163,139 @@ static inline size_t get_refill_ring_size(unsigned int rq_entries) > return ALIGN_UP(size, page_size); > } > > +static int probe_xdp(void) > +{ > + const struct bpf_insn insns[] = { > + { > + .code = BPF_ALU64 | BPF_MOV | BPF_K, > + .dst_reg = BPF_REG_0, > + .imm = XDP_PASS, > + }, > + { .code = BPF_JMP | BPF_EXIT }, > + }; > + LIBBPF_OPTS(bpf_prog_load_opts, load_opts, > + .prog_flags = BPF_F_XDP_HAS_FRAGS); > + LIBBPF_OPTS(bpf_link_create_opts, link_opts, > + .flags = XDP_FLAGS_DRV_MODE); > + unsigned int ifindex; > + int prog_fd, link_fd; > + > + ifindex = if_nametoindex(cfg_ifname); > + if (!ifindex) { > + error(0, errno, "if_nametoindex()"); > + return EXIT_FAILURE; > + } > + prog_fd = bpf_prog_load(BPF_PROG_TYPE_XDP, "zcrx_probe", "GPL", > + insns, ARRAY_SIZE(insns), &load_opts); > + if (prog_fd < 0) { > + error(0, -prog_fd, "load XDP probe"); > + return EXIT_FAILURE; > + } > + > + /* The io_uring queue is already registered; never replace a program. */ > + link_fd = bpf_link_create(prog_fd, ifindex, BPF_XDP, &link_opts); > + close(prog_fd); > + if (link_fd >= 0) { > + close(link_fd); > + return 0; > + } > + if (link_fd == -EBUSY || link_fd == -EOPNOTSUPP) { > + printf("Native XDP with ZCRX is not supported: %s\n", > + strerror(-link_fd)); > + return SKIP_CODE; > + } > + error(0, -link_fd, "attach XDP probe"); > + return EXIT_FAILURE; > +} > + > +static void setup_xdp(void) > +{ > + LIBBPF_OPTS(bpf_link_create_opts, opts, > + .flags = XDP_FLAGS_DRV_MODE); > + unsigned int ifindex; > + int prog_fd; > + > + ifindex = if_nametoindex(cfg_ifname); > + if (!ifindex) > + error(1, errno, "if_nametoindex()"); > + xdp_skel = iou_zcrx__open(); > + if (!xdp_skel) > + error(1, errno, "iou_zcrx__open()"); > + xdp_skel->bss->port = cfg_port; > + xdp_skel->bss->queue_id = cfg_queue_id; > + xdp_skel->bss->unreadable = !cfg_pages; > + if (iou_zcrx__load(xdp_skel)) > + error(1, errno, "iou_zcrx__load()"); > + > + /* A link cannot replace another program and closes with the process. */ > + prog_fd = bpf_program__fd(xdp_skel->progs.iou_zcrx); > + xdp_link = bpf_link_create(prog_fd, ifindex, BPF_XDP, &opts); > + if (xdp_link < 0) > + error(1, errno, "attach native XDP"); > +} > + > +static void check_xdp(void) > +{ > + static const char * const locations[] = { > + "header", "fragment", "boundary", > + }; > + static const char * const ops[] = { > + "load", "store", "dynptr read", "dynptr write", > + "slice", "slice rdwr", > + }; > + struct xdp_zcrx_stats sum = {}, *all, *s; > + int ncpus, cpu, loc, op; > + __u32 key = 0; > + bool failed; > + > + close(xdp_link); > + xdp_link = -1; > + ncpus = libbpf_num_possible_cpus(); > + if (ncpus < 0) > + error(1, 0, "libbpf_num_possible_cpus(): %d", ncpus); > + all = calloc(ncpus, sizeof(*all)); > + if (!all) > + error(1, errno, "calloc XDP statistics"); > + if (bpf_map_lookup_elem(bpf_map__fd(xdp_skel->maps.stats), &key, all)) > + error(1, errno, "read XDP statistics"); > + > + for (cpu = 0; cpu < ncpus; cpu++) { > + s = &all[cpu]; > + sum.packets += s->packets; > + sum.tested += s->tested; > + sum.wrong_queue += s->wrong_queue; > + sum.bad_headers += s->bad_headers; > + sum.linear_bytes += s->linear_bytes; > + sum.frag_bytes += s->frag_bytes; > + for (loc = 0; loc < XDP_ZCRX_LOCATIONS; loc++) { > + for (op = 0; op < XDP_ZCRX_OPS; op++) > + sum.errors[loc][op] += s->errors[loc][op]; > + } > + } > + free(all); > + > + printf("XDP %s: queue=%d packets=%llu tested=%llu\n", > + cfg_pages ? "pages" : "io_uring", cfg_queue_id, > + sum.packets, sum.tested); > + printf("XDP geometry: linear=%llu frags=%llu\n", > + sum.linear_bytes, sum.frag_bytes); > + printf("XDP errors: wrong_queue=%llu bad_headers=%llu\n", > + sum.wrong_queue, sum.bad_headers); > + failed = !sum.tested || sum.wrong_queue || sum.bad_headers; > + for (loc = 0; loc < XDP_ZCRX_LOCATIONS; loc++) { > + for (op = 0; op < XDP_ZCRX_OPS; op++) { > + if (!sum.errors[loc][op]) > + continue; > + fprintf(stderr, "%s %s: %llu failures\n", > + locations[loc], ops[op], sum.errors[loc][op]); > + failed = true; > + } > + } > + iou_zcrx__destroy(xdp_skel); > + if (failed) > + error(1, 0, "XDP access checks failed"); > +} > + > static void setup_zcrx(struct thread_ctx *ctx) > { > unsigned int rq_entries = AREA_SIZE / page_size; > @@ -217,6 +359,10 @@ static void setup_zcrx(struct thread_ctx *ctx) > }; > > ret = io_uring_register_ifq(&ctx->ring, (void *)®); > + if (cfg_xdp && cfg_dry_run && ret == -EOPNOTSUPP) { > + puts("Interface-bound ZCRX is not supported"); > + exit(SKIP_CODE); > + } > if (cfg_rx_buf_len && (ret == -EINVAL || ret == -EOPNOTSUPP || > ret == -ERANGE)) { > printf("Large chunks are not supported %i\n", ret); > @@ -258,6 +404,34 @@ static void add_recvzc_oneshot(struct thread_ctx *ctx, int conn_idx, size_t len) > sqe->user_data = conn_idx; > } > [..] > +static void verify_data(struct thread_ctx *ctx, int conn_idx, > + const char *data, size_t len) > +{ > + size_t offset = ctx->received[conn_idx]; > + size_t i; > + > + for (i = 0; i < len; i++) { > + if (data[i] != payload[offset + i]) > + error(1, 0, "payload mismatch at %zu", i); > + } > + ctx->received[conn_idx] += len; > +} Move some of the refactoring/fixes out into a separate patch? But in general feels like a wrong test to extend.. Why not call ncdevmem somewhere in python wrapper (and attach xdp prog that you have in this patch)? To decouple xdp testing from the entity that generates/receives unreadable frags.