From: "Lai, Yi" <yi1.lai@intel.com>
To: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Kent Gibson <warthog618@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Herve Codina <herve.codina@bootlin.com>,
Jia Jia <physicalmtea@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v6 1/8] gpiolib: wait for pending label frees before cleaning up desc_srcu
Date: Wed, 18 Nov 2026 10:05:05 +0800 [thread overview]
Message-ID: <av0H0VfZM81smF55@ly-workstation> (raw)
In-Reply-To: <20261116-gpiolib-chip-removal-v6-1-aambrozewicz@nvidia.com>
On Mon, Nov 16, 2026 at 03:47:04PM +0200, Adrian Ambrozewicz wrote:
> desc_set_label() frees the old label with call_srcu() on
> gdev->desc_srcu, and gpiodev_release() calls synchronize_srcu() before
> cleanup_srcu_struct(). synchronize_srcu() waits for a grace period, not
> for queued callbacks. Once the srcu_struct uses per-CPU callback lists,
> a label freed by gpiochip_free_hogs() can still be pending, and
> cleanup_srcu_struct() warns:
>
> WARNING: kernel/rcu/srcutree.c:706 at cleanup_srcu_struct+0x239/0x330, CPU#0: init/1
> Call Trace:
> gpiodev_release
> device_release
> kobject_put
> devres_release_all
> device_release_driver_internal
> platform_device_unregister
> gpio_sim_device_deactivate
>
After this patch applied, the call trace can no longer be reproduced.
Tested-by: Yi Lai <yi1.lai@intel.com>
> Use srcu_barrier(), which waits for them.
>
> Reproduced with a hogged gpio-sim line, setting the chip live and back
> on a 4-CPU guest with srcutree.convert_to_big=1: it warns within 60
> cycles; with this change, 1000 cycles pass.
>
> Fixes: a86d27693066 ("gpiolib: fix the speed of descriptor label setting with SRCU")
> Cc: stable@vger.kernel.org
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> Signed-off-by: Adrian Ambrozewicz <aambrozewicz@nvidia.com>
> ---
> drivers/gpio/gpiolib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 6f8f30b767ef..ce04277a8900 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -897,7 +897,7 @@ static void gpiodev_release(struct device *dev)
> struct gpio_device *gdev = to_gpio_device(dev);
>
> /* Call pending kfree()s for descriptor labels. */
> - synchronize_srcu(&gdev->desc_srcu);
> + srcu_barrier(&gdev->desc_srcu);
> cleanup_srcu_struct(&gdev->desc_srcu);
>
> ida_free(&gpio_ida, gdev->id);
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-11-18 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:47 [PATCH v6 0/8] gpiolib: fix chip removal with lines still requested from user space Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 1/8] gpiolib: wait for pending label frees before cleaning up desc_srcu Adrian Ambrozewicz
2026-11-17 8:32 ` Andy Shevchenko
2026-11-18 2:05 ` Lai, Yi [this message]
2026-11-16 13:47 ` [PATCH v6 2/8] gpiolib: free the label of lines released after their chip was removed Adrian Ambrozewicz
2026-11-17 8:33 ` Andy Shevchenko
2026-11-16 13:47 ` [PATCH v6 3/8] gpiolib: cdev: do not free line IRQs again after the chip is removed Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 4/8] gpiolib: cdev: don't sleep in the SRCU read section in read() Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 5/8] gpiolib: cdev: don't leak the IRQ name when the chip is removed Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 6/8] gpiolib: cdev: don't report a failed line read as an edge Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 7/8] gpiolib: let the character device free its IRQs first on chip removal Adrian Ambrozewicz
2026-11-16 13:47 ` [PATCH v6 8/8] gpiolib: remove the shared GPIO proxies before freeing the remaining IRQs Adrian Ambrozewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av0H0VfZM81smF55@ly-workstation \
--to=yi1.lai@intel.com \
--cc=aambrozewicz@nvidia.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=physicalmtea@gmail.com \
--cc=stable@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.