From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Cc: tgopinath@linux.microsoft.com, ssengar@linux.microsoft.com,
michal.simek@amd.com, rajan.vaja@xilinx.com,
tejas.patel@xilinx.com, abhyuday.godhasara@xilinx.com,
gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 2/2] soc: xilinx: Fix event manager CPU hotplug state cleanup
Date: Wed, 18 Nov 2026 12:03:46 +0530 [thread overview]
Message-ID: <av1GyoUdnxMV_C2p@csail.mit.edu> (raw)
In-Reply-To: <20261103063515.679043-1-ptsm@linux.microsoft.com>
On Mon, Nov 02, 2026 at 10:35:15PM -0800, Prasanna Kumar T S M wrote:
> On driver removal, the event manager removes the CPUHP_AP_ONLINE_DYN
> CPU hotplug state instead of the its actual state. This can leave the
> event manager callbacks dangling. Use the actual CPU hotplug state
> during driver removal.
>
> Hotplug registration failures are also ignored, allowing probe to
> succeed without the callbacks needed to enable event interrupts on
> CPUs brought online later.
>
> Fixes: c7fdb2404f66 ("drivers: soc: xilinx: add xilinx event management driver")
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
> ---
> drivers/soc/xilinx/xlnx_event_manager.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c
> index f733dc42b3b1..2d8bfeab4190 100644
> --- a/drivers/soc/xilinx/xlnx_event_manager.c
> +++ b/drivers/soc/xilinx/xlnx_event_manager.c
> @@ -24,6 +24,7 @@ static DEFINE_PER_CPU_READ_MOSTLY(int, dummy_cpu_number);
>
> static int virq_sgi;
> static int event_manager_availability = -EACCES;
> +static enum cpuhp_state hp_state;
>
> /* SGI number used for Event management driver */
> #define XLNX_EVENT_SGI_NUM (15)
> @@ -625,8 +626,6 @@ static int xlnx_event_init_sgi(struct platform_device *pdev)
>
> static void xlnx_event_cleanup_sgi(struct platform_device *pdev)
> {
> - cpuhp_remove_state(CPUHP_AP_ONLINE_DYN);
> -
> on_each_cpu(xlnx_disable_percpu_irq, NULL, 1);
>
> irq_clear_status_flags(virq_sgi, IRQ_PER_CPU);
> @@ -660,8 +659,13 @@ static int xlnx_event_manager_probe(struct platform_device *pdev)
> }
>
> /* Setup function for the CPU hot-plug cases */
> - cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "soc/event:starting",
> - xlnx_event_cpuhp_start, xlnx_event_cpuhp_down);
> + hp_state = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> + "soc/event:starting", xlnx_event_cpuhp_start,
Let's change :starting to :online as per convention, as this is
associated with the ONLINE_DYN state.
Can we also edit the callback names for symmetry similar to the
suggestion for patch 1/2?
> + xlnx_event_cpuhp_down);
> + if (hp_state < 0) {
> + xlnx_event_cleanup_sgi(pdev);
> + return hp_state;
> + }
>
> ret = zynqmp_pm_register_sgi(sgi_num, 0);
> if (ret) {
> @@ -670,6 +674,7 @@ static int xlnx_event_manager_probe(struct platform_device *pdev)
> else
> dev_err(&pdev->dev, "SGI %d registration failed, err %d\n", sgi_num, ret);
>
> + cpuhp_remove_state(hp_state);
> xlnx_event_cleanup_sgi(pdev);
> return ret;
> }
> @@ -704,6 +709,7 @@ static void xlnx_event_manager_remove(struct platform_device *pdev)
> if (ret)
> dev_err(&pdev->dev, "SGI unregistration over TF-A failed with %d\n", ret);
>
> + cpuhp_remove_state(hp_state);
> xlnx_event_cleanup_sgi(pdev);
>
> event_manager_availability = -EACCES;
It looks like this patch 2/2 doesn't have the kind of bugs in the
cleanup path that affected patch 1/2, so that's good.
Regards,
Srivatsa
next prev parent reply other threads:[~2026-11-18 6:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:20 [PATCH 1/2] mailbox: zynqmp-ipi: Fix CPU hotplug state cleanup Prasanna Kumar T S M
2026-11-03 6:35 ` [PATCH 2/2] soc: xilinx: Fix event manager " Prasanna Kumar T S M
2026-11-03 12:26 ` Jay Buddhabhatti
2026-11-03 15:18 ` Prasanna Kumar T S M
2026-11-18 6:33 ` Srivatsa S. Bhat [this message]
2026-11-03 16:05 ` [PATCH 1/2] mailbox: zynqmp-ipi: Fix " kernel test robot
2026-11-04 5:53 ` Pandey, Radhey Shyam
2026-11-04 11:21 ` Prasanna Kumar T S M
2026-11-18 6:08 ` Srivatsa S. Bhat
2026-11-18 6:19 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av1GyoUdnxMV_C2p@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=abhyuday.godhasara@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=ptsm@linux.microsoft.com \
--cc=rajan.vaja@xilinx.com \
--cc=ssengar@linux.microsoft.com \
--cc=tejas.patel@xilinx.com \
--cc=tglx@linutronix.de \
--cc=tgopinath@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.