From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794988306; b=hzal86YBayaIbVuw/6VNQfoCyjB9iETONpfa9YumTtANGLQp4cqJ9OHeP7MF69+MD02h nFoNr3xw7drf15iiyH6411Y9U6swV5WZNJL5V/4O5/tSuBoJdzoHXU3+kE+6xtX+IK6ZZ eOwm+hQPzi5S4Qe8smnrRSKGOLwPLOMO82MoDazW6+eS8YzwhLH2MkZCWDFmPz38bgNpk PG49t9hF2dzNmp2IKoG8e+V+BpxF3T48Cc9bRcA5p9AvhzJ7KIhzYfOtjp1B2OsigPfTJ euD95HydoTlfFoPsxk5eWYeI7gTKOflz/M+HYUWW3M+/jMLhHjeLHNC4iuln9QTHgMg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794988306; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=O5PkKeqYb/LwHETHiLrh+1bM410DfdgOAKrYXsI05vg=; b=PzXCxr4bjVyqnEUgLedl1ZxbGxxxmd9nRgGxjaBxhqa1aW/dakkgmGWnOTGUABRT2q28 3C7N24D67gOVdzfGUrSzfgnNmLvQ++81wgAzLzWPScnUiIkGyE+++KM2oX42tDSDCv9Z8 eZqBp8SBPkW/0DuxZIPhHewv3l4F22E1xU0tK7+sGRU4FeMI6dbaXhiRa5dFzcM8+YAMu YvtxcRNQu1wMq/aUIoBshlGIS0Y60WOd7s0qIDi64FWVk6iXiSc5jRXLResZRU7YTgv41 frpWmQXFltKUy22jig6QP241dgDOYQySQSHI+S1PxIWnQ1ZNOV7tbQmGLK2kNrh9e4g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=P1ud4Uqd; arc=none smtp.remote-ip=95.215.58.43 Received: from mta1.migadu.com (out-43.mta1.migadu.com [95.215.58.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01268606A31C for ; Wed, 18 Nov 2026 07:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 01268606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=P1ud4Uqd X-Envelope-To: sashiko@lists.linux.dev DKIM-Signature: a=rsa-sha256; bh=XvAgxEjJ3OAUwu1XgsNSodkGZOpTs7Rjf0Vt5qxjVW0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794988303; v=1; x=1795593103; b=P1ud4UqdkEjF5/8kmiGXo6Je+q0eJbj2XWY1uGgq+rPJZ+hgPzvXocLCtuJ+2E3A+8R2a+lH AgdhbIapLGW1EqtTYbzxBovEueeytSWVdwk7dD80rbD7wP0BiqMRUVAAE1FgS3p0qzYbA0QLcoc ketO+IeHdxaS2beDnxuCrbQI= X-Envelope-To: sashiko@lists.linux.dev Received: by mta12.migadu.com with ESMTPS id 2217796b0058d3f6; Wed, 18 Nov 2026 07:51:43 +0000 X-Mizu-Trace-ID: 2217796b0058d3f6 X-Migadu-Flow: FLOW_OUT Date: Wed, 18 Nov 2026 15:51:35 +0800 From: Baoquan He To: Andrew Morton Cc: sashiko-reviews@lists.linux.dev, Zack Rusin , Petr Mladek , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Dave Young , Borislav Petkov , Ajay Kaher , Alexey Makhalov , x86@kernel.org, Joel Granados , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , virtualization@lists.linux.dev, bcm-kernel-feedback-list@broadcom.com, John Ogness , Steven Rostedt , Sergey Senozhatsky , Kees Cook , Jonathan Corbet , Bo Gan , Brennan Lamoreaux , kexec@lists.infradead.org, "Guilherme G. Piccoli" , Maaz Mombasawala , Shuah Khan , Randy Dunlap , Stephen Brennan , Michael Kelley , Ian Forbes , Bradley Morgan , "Michael S. Tsirkin" , Eugenio Perez , sashiko@lists.linux.dev Subject: Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Message-ID: References: <4c5de34b10f579368b890eaa9333a2755886bad3.1794980455.git.zack.rusin@broadcom.com> <20261117230201.921ec5bddf49cd459ddb8428@linux-foundation.org> X-Mailing-List: sashiko@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261117230201.921ec5bddf49cd459ddb8428@linux-foundation.org> On 11/17/26 at 11:02pm, Andrew Morton wrote: > On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He wrote: > > > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote: > > > > Allow administrators to disable host log transfer on ordinary guests or > > > > opt in on encrypted guests. Expose the boolean recording policy through > > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested. > > > > Zero disables recording, nonzero integers enable it, and reads return > > > > 0 or 1. > > > > > > > > Register the sysctl only after the logger is ready. A registration failure > > > > leaves the internal default in force. Document that the log is sent > > > > before kdump, and that disable_panic_notifiers_platform_list also skips > > > > it. > > > > > > > > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj > > > > Signed-off-by: Zack Rusin > > > > > > Sashiko has reviewed this patch and found no issues. > > > > It might be better to turn off this message if not issues found, just > > like what LKP bot has been doing. > > (+sashiko@lists.linux.dev) > > Yes please. > > These emails do have a little bit of value: they tell you that Sashiko > was able to apply the patch and to review it. I guess. Or something. In that case a message saying Sashiko can't apply the entire patchset is better. > > Me: > > :0 D: > * ^From:[ ]*sashiko-bot@kernel\.org[ ]*$ > * B ?? ^Sashiko has reviewed this patch and found no issues\.$ > /home/akpm/.nsmail-zip/Trash > > hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l > 1140 > hp2:/home/akpm> > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172A6606A31C for ; Wed, 18 Nov 2026 07:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KSxQKAc8; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=P1ud4Uqd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=O5PkKeqYb/LwHETHiLrh+1bM410DfdgOAKrYXsI05vg=; b=KSxQKAc8ru3Zk3+gmtyOsY46L2 Dzno0Vi0MKa7Re/X5dQvQBQ6ciZw65KJjWAWSx3KIB/2Ph1HhKXVKhfClkYxXVn4EgJ6L4biBpxxS a0mOairXstaBeoEVQpSth+897+hmS898ASd6OkrP1ZL9zsUMs8kr05T+rFyCs3i5NGQ+2PMvbAJNt Wlh0AOAg5as0daDm6Mw2YEH5jdy5Qdrmk0atQli8jXO54gTQQUFLiIBlOSnAwIOjPqZ3esIhUykeS V+o43hbWPSsFt5UgbdMIJC/3SF1po2kbD1/Jqro0BofCBXl1P0nweT89sBcE9BemlXIXRTcZuUGan 2pDC9gXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTaSL-000000084Ex-3KfM; Wed, 18 Nov 2026 07:51:49 +0000 Received: from out-44.mta1.migadu.com ([95.215.58.44] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTaSI-000000084CO-49Cw for kexec@lists.infradead.org; Wed, 18 Nov 2026 07:51:48 +0000 X-Envelope-To: kexec@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=XvAgxEjJ3OAUwu1XgsNSodkGZOpTs7Rjf0Vt5qxjVW0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794988303; v=1; x=1795593103; b=P1ud4UqdkEjF5/8kmiGXo6Je+q0eJbj2XWY1uGgq+rPJZ+hgPzvXocLCtuJ+2E3A+8R2a+lH AgdhbIapLGW1EqtTYbzxBovEueeytSWVdwk7dD80rbD7wP0BiqMRUVAAE1FgS3p0qzYbA0QLcoc ketO+IeHdxaS2beDnxuCrbQI= X-Envelope-To: kexec@lists.infradead.org Received: by mta12.migadu.com with ESMTPS id 2217796b0058d3f6; Wed, 18 Nov 2026 07:51:43 +0000 X-Mizu-Trace-ID: 2217796b0058d3f6 X-Migadu-Flow: FLOW_OUT Date: Wed, 18 Nov 2026 15:51:35 +0800 From: Baoquan He To: Andrew Morton Subject: Re: [PATCH v4 3/4] x86/vmware: Add the vmware_record_panic_msg sysctl Message-ID: References: <4c5de34b10f579368b890eaa9333a2755886bad3.1794980455.git.zack.rusin@broadcom.com> <20261117230201.921ec5bddf49cd459ddb8428@linux-foundation.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261117230201.921ec5bddf49cd459ddb8428@linux-foundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_235147_339326_7FE14183 X-CRM114-Status: GOOD ( 18.94 ) X-Spam-Score: -2.1 (--) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ajay Kaher , Kees Cook , Dave Hansen , Dave Young , Stephen Brennan , Bo Gan , "H. Peter Anvin" , Zack Rusin , Jonathan Corbet , Brennan Lamoreaux , x86@kernel.org, sashiko@lists.linux.dev, Joel Granados , Alexey Makhalov , Eugenio Perez , Ingo Molnar , bcm-kernel-feedback-list@broadcom.com, Thomas Gleixner , Petr Mladek , Bradley Morgan , Pasha Tatashin , John Ogness , virtualization@lists.linux.dev, Steven Rostedt , Maaz Mombasawala , Borislav Petkov , Shuah Khan , Michael Kelley , sashiko-reviews@lists.linux.dev, Randy Dunlap , kexec@lists.infradead.org, Ian Forbes , Sergey Senozhatsky , "Michael S. Tsirkin" , Pratyush Yadav , Mike Rapoport Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 11/17/26 at 11:02pm, Andrew Morton wrote: > On Wed, 18 Nov 2026 14:42:00 +0800 Baoquan He wrote: > > > On 11/18/26 at 06:14am, sashiko-bot@kernel.org wrote: > > > > Allow administrators to disable host log transfer on ordinary guests or > > > > opt in on encrypted guests. Expose the boolean recording policy through > > > > kernel.vmware_record_panic_msg using proc_dobool(), as Joel suggested. > > > > Zero disables recording, nonzero integers enable it, and reads return > > > > 0 or 1. > > > > > > > > Register the sysctl only after the logger is ready. A registration failure > > > > leaves the internal default in force. Document that the log is sent > > > > before kdump, and that disable_panic_notifiers_platform_list also skips > > > > it. > > > > > > > > Link: https://lore.kernel.org/r/4e73yd2ofpdzl6rptzvd74no3hnyfblknoq7wzxlw7f3zjbz7c@srfabx6lsusj > > > > Signed-off-by: Zack Rusin > > > > > > Sashiko has reviewed this patch and found no issues. > > > > It might be better to turn off this message if not issues found, just > > like what LKP bot has been doing. > > (+sashiko@lists.linux.dev) > > Yes please. > > These emails do have a little bit of value: they tell you that Sashiko > was able to apply the patch and to review it. I guess. Or something. In that case a message saying Sashiko can't apply the entire patchset is better. > > Me: > > :0 D: > * ^From:[ ]*sashiko-bot@kernel\.org[ ]*$ > * B ?? ^Sashiko has reviewed this patch and found no issues\.$ > /home/akpm/.nsmail-zip/Trash > > hp2:/home/akpm> grep "From:.*sashiko-bot" .nsmail-zip/Trash | wc -l > 1140 > hp2:/home/akpm> >