From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794995023; b=kpYSmppFW6e3pPAoIOt76YOMTwfcyVXxkiqKtRo42NYhwFDQ9xta0Z+UwUTZ/hGkmn9q kZlRY702rylxfj1rHYaa7d8HeRFtEd459mgmPSLJKmhBkYhwbiUB4aAI8xqnDNpKlanS9 nAGBr3GqBtdidjtNWcj7ckLuqDiDkEe4mcdAamYNw1Esca1i4PXiAJ9BKHJqdITAjEqSF 9mzbRp4EbvnD+5vhzNASjm6MOL3VNZgsJ+PvqtQv0MonWGbFZT6PhsNhJHOpizEsIGd7o cwyU1Q1hekG+4wBJAKkmwtMwT96dCzTh1Be4SIcTcJaPPv7DwazhL4zs7VneJ7UmMaA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794995023; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Date:From: To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Authority-Analysis: X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=AUnrIqYg5oO/8dWsnNZrU8gC3RoY4sAX8r+6bIRiQzU=; b=ytIVbEn6jHrnvtFcVqCqq8cKyMdmi5YVZJ0mRdiQlZkVtjCQkf2FOO5ERAhx3u6N7bXk wIgxyqV+IeNfp+LTq28J8VgMB2PX2pWpKJh9rlbPsm8/RI13N1FE2PMN9CBIRc4QcX0/a H/I4qWZEepZCA83ZuZO2UdlQuaAh6GchozpiG6KtAVuhEGFVXA2xPWmbaZSW1fgKMXUzI reqStqU7IK/f/PZnvjWhhs6/b8j8TBy9ZA8Fbr40N7+tFnZ+e8hFp2EWi6hi5PVh+UfRi UBxFUVRVKGpxRGhZUeObiVRrrDcxSVfRopgCZrZbP8BG2MZdtZ1n5Nter3kynTzelng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=C3AM7ma5; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PIw5MLxt; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC23606A325 for ; Wed, 18 Nov 2026 09:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2BC23606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=C3AM7ma5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PIw5MLxt Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AI8Y6gu4059958 for ; Wed, 18 Nov 2026 09:43:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=AUnrIqYg5oO/8dWsnNZrU8gC 3RoY4sAX8r+6bIRiQzU=; b=C3AM7ma5b7fxMT9qvM40GoiEHIniEOXV5+aCbCYH wJGk7imQK3QM2W3lWYYtco0s7LmAVfO5LQPJao/v/fHyYigkAR2/KsMwOEoBbFbd F68H7vQ73gJLQ65ph7zygPqbPyQq0HW+yuwjvu3LFJyebvK7oMGzAxWOOqs7D1ev vS7/nZgpZOL1jLaaZNvXcpNVyPEZTQuonB9Z19hnSRefqK4kZfzUUnzoIeiiA3WH v4Ich2uHdHhBjRlaE8nAbjLPKTsY6ECcJLL1hbHEqaMVkT4/M31E9CakIaDynlCH wRUUbWkKpMcJqu8uUcBAUqdK9oJkHgs0nHGDvzkYIYO5mA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0yvcjd9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Nov 2026 09:43:41 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93e92aad34aso154167885a.0 for ; Wed, 18 Nov 2026 01:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794995021; x=1795599821; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=AUnrIqYg5oO/8dWsnNZrU8gC3RoY4sAX8r+6bIRiQzU=; b=PIw5MLxt5nnUKf+HorXMNmUhdInSiZiRqtc1xJV0OwZ4rHcbSbemHhMUriNPMkexZ8 9xs3dVzfoeRMsy/61Wx5Pf5vx2Lxrr7h9CoEp7PoGCf0IxuO/tsdoaVTCcgUHRICJGX0 Uu7jTrqn5AmReCJUmXxa8PqeZNQ9h+P+t2qP1j98pixlwsZ3bL9HZKzZGxOehbMMiKbd 2qzeEN0PuwLBQir4jQyD+d4FHnrIAaK5eOr0Z4U0bZN8E3kaMXyK+e9AcD/ixVOMul6N 4deEFg9kqsI0XIM4kTlxYbzG03FTuD9VI8bLMGBvlPEeWQ+QASAKroYYv89ddFO/c8lB sVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995021; x=1795599821; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AUnrIqYg5oO/8dWsnNZrU8gC3RoY4sAX8r+6bIRiQzU=; b=uSVqmNyAIPCqO5SCKgUZvTKz3p30nDfINgRhXky8BklxFr/v00X0CQr5pEWYtcjotR 9aqhBx+XVZVtseHTfJYPRmeEK6a3BhBlSK/ty4ngyThfyJLZnP6/en0qf+Dv2PmDee8x KKPRvA/N+IcxuziGRU9VcscflkpXYE7DN7UtQSVACF7sucPfLtIbf/bVLtIFOmqP0VZu IWdDcHdrlQiT4lV/0Ec0nhP8643OZkdYw5XjBrs5ib9wLu2ifo0UXhGIw6WCZfI/FbfJ yNPDFj/882YnGdhTBrRlmYq30SsYD+RaLJJtSeLt6PxZ39ES/+XLsG+D9haenzfT+FWD 9WTA== X-Forwarded-Encrypted: i=1; AL+hErGfE7KIS8RrQQ/t/n1giQzujMMjauIGauY5zVpEgbKO5CP6oHI5ExXeC/AWzfbG/+LYjp/9CpF5HwyxB3Hd@vger.kernel.org X-Gm-Message-State: APuU4Z/KJMd/p/YoCBIlKb58LeUiNt/QRsnCMshtpIyRSFdAtxe7NBIF vHr3leH1oIV0gFX+fpTCL7zzqyG1OC6QAlcFBDWxKaOFqyqhZFJo7/ll1TkkV7lAPLnSYeeZTZm QkLA6Ofm8hXbddYbuS29Gz2bXfCU55haO2iCmk3xaTvrt+UVd1nmoiMJFsyQxoILLsrLo X-Gm-Gg: AYBFou3BCjfE43f/8DeREusOnZmqn8Wqw2pRspzDOM2lDWhpbUOeJL4TF7/PJhQ4YTP EAAlRUwKUYUjHk7MtKCfyGxB0AP0GSeMJ3mtgwnsSbXLOC9bDbEdnmUswaRwdhecPPo9GBUOKsh Y5yN4+EnGC8EGxQau5hnTNDIR5bVIylMosksL9KXILeK8Hi4Z91gRTr1ctNBi9nd3RLb7FkFI4B s6HKTbda23rP7qcFhrW/5Z8GUjknvmfuM95XHaWradkjCYh+PiOLGRHUop23u47Tfn0oAihaj3Z PoMeBMzz+k4m8cX1euyjkQyyGGG20oOZrZf8uI0eyHYXNdptbJAuU/c9czLJxTeDN/IqYzVJHEP 0nBk7GbKdNVyt5h7uphnlaz7/MXm4iRZQXqhwmpROBcUo+6j31Wwvupz3eQR6idM= X-Received: by 2002:a05:620a:178d:b0:949:3066:5569 with SMTP id af79cd13be357-949995b2d4amr398313185a.46.1794995020947; Wed, 18 Nov 2026 01:43:40 -0800 (PST) X-Received: by 2002:a05:620a:178d:b0:949:3066:5569 with SMTP id af79cd13be357-949995b2d4amr398308985a.46.1794995020335; Wed, 18 Nov 2026 01:43:40 -0800 (PST) Received: from localhost ([195.50.164.66]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a656095e98sm3435347f8f.42.2026.11.18.01.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:43:39 -0800 (PST) Date: Wed, 18 Nov 2026 10:43:38 +0100 From: Lorenzo Bianconi To: Mohd Ayaan Anwar Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v4 09/10] net: stmmac: qcom-ethqos: add Shikra EMAC support Message-ID: References: <20261117-shikra_ethernet-v4-0-c41902e5f2fa@oss.qualcomm.com> <20261117-shikra_ethernet-v4-9-c41902e5f2fa@oss.qualcomm.com> X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ETxtsn8fYdG6F01d" Content-Disposition: inline In-Reply-To: <20261117-shikra_ethernet-v4-9-c41902e5f2fa@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=R5OWitRX c=1 sm=1 tr=0 ts=6afd734d cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Jk2/TV77q6/E6wQq2oQJxQ==:17 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=LGXQo2T9AS_8CfUs2oAA:9 a=CjuIK1q_8ugA:10 a=AOVp3MrtItf36BpiwHAA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: fi7o5ZTOJkB8yP7rFojLIGPcvjiK8M_B X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE4MDAzOCBTYWx0ZWRfX1fk8nP719FWt YYptA9Fn93zqmXto3AA2M1VK/C7JrUMxItTgmI+3bBeqmRY3S1BP5NmJwqW5bP2kesQDtqgMK/w 9SHnkjpyZ25ms7ufycxfNWlLiMEkoPI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE4MDAzOCBTYWx0ZWRfX7XDiYFfrV/bJ ZErMsSKYZ1k28DI1LtoBLHBxTgVj3pxZRdYS7ZZg7Qdny0TXIw3+EsAdcaFovRdmcubScaQ+rkK MUiOyxV4JB5lIoGvnZKwOk7h74KPA/d5nI8Wf0TylYrlQ0/1z1y+VXoMrkHwZ1j5kuGYOuQ6Fkw PsvkNTwnw7szGTmmGGw5HpIUpKZ/T+wk9Ma2fXPRTBF0lL5aRdqfaRsDYS8Xa3IttVG8ub8A/c8 POZg/gi83MUZg7Szjv35h9yMLZ5LOWOxn+ia3QLdLWoTnx8bpAzBGXWwz/9F41x6QHVikJNsL+p l2up6FeYCk2a7Adl0EcdXU8xPI0IiyeQdtV4MqTOVdsNfLr6rYYB8YlcvYZ2Ip24JvvtM6dxwrM zCTE4D2lOznZuNODYFPp4+y4UmctK/+hsmgZBBroPwKoHM5m4XKqTk98lTIckGhfdITrFWe/kJz b8A/SleEy0HPkOWBwJg== X-Proofpoint-ORIG-GUID: fi7o5ZTOJkB8yP7rFojLIGPcvjiK8M_B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-18_01,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611180038 --ETxtsn8fYdG6F01d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Nov 17, Mohd Ayaan Anwar wrote: > Shikra integrates two Qualcomm ETHQOS controllers based on the Synopsys > GMAC IP, similar to previous platforms. Register qcom,shikra-ethqos > backed by a new shikra_data descriptor that enables the three NOC clocks > required for DMA memory access (stmmaceth, axi-noc, pcie-tile-axi-noc), > and the 36-bit DMA address width. >=20 > Set the NOC clock rates through an OPP table to ensure proper voting of > the VDD_CX power domain. The stmmac core enables stmmaceth before the > glue driver applies the OPP vote, both at probe and on resume. This is > safe because VDD_CX only needs to be voted while DMA traffic is > ongoing, which cannot start until the glue driver applies the vote. >=20 > Shikra's intended rgmii-id configuration supplies both TX and RX delays > in the PHY. Therefore, enable phy_managed_delays to select the > DLL-bypass sequence. No POR table is needed for this intended bypass > operation. >=20 > Signed-off-by: Mohd Ayaan Anwar > --- > v4: set phy_managed_delays to true for Shikra and reworded the commit > message to clarify concerns raised by Sashiko. > --- > .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 19 +++++++++++++= ++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/dr= ivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 15385750b3e6..a7fdba73da2b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -332,6 +332,24 @@ static const struct ethqos_emac_driver_data emac_v4_= 0_0_scmi_data =3D { > .setup =3D ethqos_scmi_setup, > }; > =20 > +static const char * const shikra_noc_clk_names[] =3D { > + "stmmaceth", > + "axi-noc", > + "pcie-tile-axi-noc", > + NULL, do you really need it? Regards, Lorenzo > +}; > + > +static const struct ethqos_emac_driver_data shikra_data =3D { > + .dma_addr_width =3D 36, > + .has_emac_ge_3 =3D true, > + .noc_clk_names =3D shikra_noc_clk_names, > + .num_noc_clks =3D ARRAY_SIZE(shikra_noc_clk_names) - 1, > + .rgmii_config_loopback_en =3D false, > + .phy_managed_delays =3D true, > + .dwmac4_addrs =3D ðqos_dwmac4_addrs, > + .setup =3D ethqos_hlos_setup, > +}; > + > static int ethqos_dll_configure(struct qcom_ethqos *ethqos) > { > struct device *dev =3D ðqos->pdev->dev; > @@ -1101,6 +1119,7 @@ static const struct of_device_id qcom_ethqos_match[= ] =3D { > { .compatible =3D "qcom,sa8255p-ethqos", .data =3D &emac_v4_0_0_scmi_da= ta}, > { .compatible =3D "qcom,sa8775p-ethqos", .data =3D &emac_v4_0_0_data}, > { .compatible =3D "qcom,sc8280xp-ethqos", .data =3D &emac_v3_0_0_data}, > + { .compatible =3D "qcom,shikra-ethqos", .data =3D &shikra_data}, > { .compatible =3D "qcom,sm8150-ethqos", .data =3D &emac_v2_1_0_data}, > { } > }; >=20 > --=20 > 2.34.1 >=20 --ETxtsn8fYdG6F01d Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCav1zSgAKCRA6cBh0uS2t rPbRAP9BOltPilAtM/l/jP103hZDb2bBRLwQa1hr5OhxYjxr7QD/e4//9SJ8S8YW RN03Uozs6Lfhs9Mz/3nOHiTwyhZ/zQ0= =rI6r -----END PGP SIGNATURE----- --ETxtsn8fYdG6F01d--