All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
	 akpm@linux-foundation.org, riel@surriel.com, liam@infradead.org,
	vbabka@kernel.org,  harry@kernel.org, jannh@google.com,
	lance.yang@linux.dev, rppt@kernel.org,  surenb@google.com,
	mhocko@suse.com, linux-mm@kvack.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: use memory barriers for non PMD-sized folios to sync
Date: Wed, 18 Nov 2026 12:25:55 +0000	[thread overview]
Message-ID: <av2Y7v-PQ0vVZLSP@gremlin> (raw)
In-Reply-To: <430c6b67-76a2-4f67-abb6-e28d07a84bd4@linux.alibaba.com>

On Wed, Nov 18, 2026 at 02:19:56PM +0800, Baolin Wang wrote:
> > Do we have any way to measure the benefit of this? I think we'll need that to
> > convince reviewers (like Lorenzo :) )
>
> As I replied to Lorenzo, I will try, though it is hard to measure the
> performance for this uncommon race case.

I mean it's not a race unless you stop taking the PMD lock (I think the commit
message has to be a lot clearer about that), and I'm not really happy to move
from easy-to-reason-about PMD lock to hard-to-reason-about and fragile memory
barriers unless we have a _really_ good reason.

I'd say given what you've said that we don't have a really good reason :)

--
Cheers, Lorenzo


      reply	other threads:[~2026-11-18 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:00 [PATCH v2] mm: use memory barriers for non PMD-sized folios to sync Baolin Wang
2026-11-17 13:53 ` Lorenzo Stoakes (ARM)
2026-11-18  6:17   ` Baolin Wang
2026-11-17 21:19 ` David Hildenbrand (Arm)
2026-11-18  6:19   ` Baolin Wang
2026-11-18 12:25     ` Lorenzo Stoakes (ARM) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2Y7v-PQ0vVZLSP@gremlin \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=harry@kernel.org \
    --cc=jannh@google.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=riel@surriel.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.