From: Patrick Steinhardt <ps@pks.im>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 4/4] pack-check: use size_t for the size passed to verify callbacks
Date: Wed, 18 Nov 2026 14:34:11 +0100 [thread overview]
Message-ID: <av2pUyAwTA7e2eOj@pks.im> (raw)
In-Reply-To: <00939c7f1b144fb9dbbc1745e60f7baa18217742.1794984184.git.gitter.spiros@gmail.com>
On Wed, Nov 18, 2026 at 07:56:38AM +0100, Elia Pinto wrote:
> verify_pack() in pack-check.c passes each object to a verify_fn callback
> (defined in pack.h) taking the object size as an "unsigned long", even
> though pack-check already handles it as a size_t. This signature is also
> replicated in struct odb_fsck_options (odb.h) and implemented by
> fsck_obj_buffer() in builtin/fsck.c.
>
> On platforms where "long" is 32 bits while size_t is 64, such as
> 64-bit Windows, running "git fsck" on packs with objects of 4GiB or
> more passes a truncated size to fsck_obj_buffer(), causing
> parse_object_buffer() and fsck_object() to inspect only a prefix.
The more interesting question to me is: if they only inspect a prefix,
do they actually notice that something is off and report the error? If
not that certainly sounds like a bug to me.
Patrick
next prev parent reply other threads:[~2026-11-18 13:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-31 11:39 [PATCH 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-10-31 11:39 ` [PATCH 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-10-31 11:39 ` [PATCH 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-10-31 11:39 ` [PATCH 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18 6:56 ` [PATCH v2 0/4] use size_t when receiving and verifying packs Elia Pinto
2026-11-18 6:56 ` [PATCH v2 1/4] unpack-objects: use size_t for object sizes Elia Pinto
2026-11-18 13:33 ` Patrick Steinhardt
2026-11-18 16:59 ` Junio C Hamano
2026-11-19 10:09 ` Patrick Steinhardt
2026-11-19 6:05 ` Elia Pinto
2026-11-19 10:12 ` Patrick Steinhardt
2026-11-19 17:48 ` Elia Pinto
2026-11-18 6:56 ` [PATCH v2 2/4] index-pack: use size_t in write_compressed() Elia Pinto
2026-11-18 13:33 ` Patrick Steinhardt
2026-11-19 6:05 ` Elia Pinto
2026-11-18 6:56 ` [PATCH v2 3/4] index-pack: use size_t for object sizes Elia Pinto
2026-11-18 6:56 ` [PATCH v2 4/4] pack-check: use size_t for the size passed to verify callbacks Elia Pinto
2026-11-18 13:34 ` Patrick Steinhardt [this message]
2026-11-19 6:05 ` Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2pUyAwTA7e2eOj@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.