From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27FD606A320 for ; Wed, 18 Nov 2026 14:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uBggcQGz; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=a7OWiBHH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=RNm2s1z9CWk9uaBWmq07fRoJtn4UwlzPGuJn6tJk+rQ=; b=uBggcQGzOM86Df35T5kDrqSOQj cKI94iWsuob3lwHh04vabNRaiPJQTa745Ro6DwjnLo79jh/eZqYZ3Tw/2WxrFPaNY+VwKqIPOwdPA P81qiP1uSwAcy9OvXOT47SMLliFVH1HReiEQcwrLq5z9UYWRpqEv6Q0ya91Cz9yKlJP4sxnFG/gfU 7G3K6e5p/40kADlzVpzAZfwwgl7ki3Owf3/zosiQfRg4C6N9fh8hil7p0jrnfJ7m7K3nRDSYqv9ck ZEv9d/MGgxUNpmkMwykjbWS4hS3Z39jSqChrDrvyY0sDmInvdJ4hPOdRitEinfetzhdOewjwRYOtf IjNciRcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJF-00000009392-3oSo; Wed, 18 Nov 2026 14:06:49 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJC-0000000936Z-0iz6 for linux-amlogic@lists.infradead.org; Wed, 18 Nov 2026 14:06:48 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4bb6886d30aso9014695e9.3 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=a7OWiBHHeBpBKtUK3YqsZwYROT3IvgmEwhlPetuS3hbUlbRr10imUpHdv6Dpp+R+wT KisRdOfJX0VF6DabLD35EFA7Dui7hBEV6T74DFHVSHKTnC6bNPb3AqpLJL6WxQUzy9eW o46uMoRW/+HvWciMAq3Mel5tp/M52RDky/6heoKBFRcfJqg2/nYFG2NDy+4XndV4ye9a QWm7RfulzKFt1uWqtft6CanEwUoMrKppKO1/y1pVW73bPzoHJh/i3GJ3c+cpJxyZpCwE bFErBKRMhS1T/x0cnLX3y2jGeKTryHHkifoYXmPkVSqhfIIhbnnxtx3mUHBjxhMPlGM8 xpmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=cBMEKY4kpfb5coA4HhOs/iTl22vxG9NRWTcFm8nLlUWKv6LeJdXdhR4lnBXR0YtrBO syu2rXUqMwax0Nc5tRjwM+TnuBTnr2gfCWXb5JMQ7HR5k9PIk+Q7Va8QG4ioQxMBDO71 TVeES353wngNTxsRaqFIIFQm9zzDs5dsSkLZIwZKHwklDcFrGSUrUR3kZWj/pBKgsc2/ skE3rV5byTAqv55mZjIyOmfHMN2f7wBu15tZ4nsc3Tf6rNf3z7SfsVJMgnl5U05PT7J/ tj0Fl5pSwQ5UOpXBZ7NaN1fnUGYdtABWwvUXeLqcwhhkr7K78KBf1MJ/LkhCBlschiVq 0nmQ== X-Forwarded-Encrypted: i=1; AL+hErFUS1ItV0UN73yAIaj1DQ+IDjq8wrYi1/HWrHOVpYK2TQ5e7MEkPObxPXrJ4EHzOcHS5UEwV4UDr65YB+OQ@lists.infradead.org X-Gm-Message-State: APuU4Z8whyvNiOv37BFnmQrxleYAe9s8F+Bg7Ie/PgGu2quGXWEiT3c5 2Ft3y8bLu8Ic14X0NXTofxty0HXvQprQ1+ec3uEdF8rqCuaZKjZJsuGEP6rY7/563shUsAPTY/m Oewo33ZE= X-Gm-Gg: AYBFou2SmEC+eJ0VjU4o+562uXb+2L9+5T0IlkZ8ziWYf9+qnNvSNi+y+mAYgp6fjsd YDqiqTAzn3Eatw1geun9HCKef9TT56a8FpVmFNzCHECOVrAqUJWeLR+qew5QaVSbOcCQsgUT4o/ hX2BO3eVwe1Qge5DRxlkfXgGHRZEzNMWqlerDP7CvmixKqPI+h7/XvQ6KzrFpLMEEk/Hf73XT0H QQqFt5HIuPhGWOy+o8MIMgTr4VMzqeyBlOEEs3QMaJSmSJZ8Q6jvhok6PUODM8N67dPvWHzGFXl K8B+VAcxA5nmS2KQU6SXR+JSRStIsW0NvwINH8YSE3OFO3bdcA1S8vnaa5RERv8vqsUJBLRUSwc bQ4JiMpLDIyiDfdKqVwu+/4lCqA1+U6dGcMmZZBRccaKZojpNBzkqBvWHkZXC8m85SBOMKTNcEO dZipRXJrQqd2Vr+OpkY9xzc0OShajqHuuyAlCyoNJdXY9HXe9dJT89c89HFrOYlTjGtbeHjaXtL fu0A2QTQJeArTAcLmxbkgN40QmTWVwe77ylaUFg9qIHvvkamx/zynWADsOy2LQKjQzMUOIo0Mpn 25TUnTMgBPUAxs4sNZZ1as3Yo1HQunekW2A= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_060646_602179_1C3493CE X-CRM114-Status: GOOD ( 18.81 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4553960179982383113==" Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --===============4553960179982383113== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko-- --===============4553960179982383113== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============4553960179982383113==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795010806; b=IzESiccH2mUvx+qaadgPH/lg3y/KtUIf06H76l00yg1NNGcbVSPETxbS8a0VpsGEKBTL keYQtJkxmIw001JGAG6oDWOvzREb8U51jmtZFmcIjf7ln41RH4VY2MCsJzfgBmokuf8wy 5EG57pqJJm2TJWVba37ccTH9OyJNxwZc4+hBCYcxRL75xXfKiu4z3IP/eARsZ+h74w6ED 29chwQ33ap30JVusgfKmTJespNb8C1eCj8+c/hx+Qf65zYoQiTlDgVa4EiBuS1qlEhqlX T7f6AcGzPJQYmqQS3GjipEtjT+YEx6dT8zP8ZTnPA2a1EYkJk03cYzc2K8y7TkWHijw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795010806; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=UgCcP5OkmauQVD2kPCIWUqYXnkCcEpsTP9xPF+Bw+r1zUFA6fS9GMyF8scwpG0XHz7vp pzlvE4q0HrmhxpWfznnmmrK3N9gndUspENU/dRKaHPWMEpwVwEnzYh6QyJFtgQd6K/Amk Qk3gML548sGFsecazTBghkb+wP/mS/EPRUCM5Uo1UUKIDZeN7739jX/IXN419Pr3OG741 TW188wm1UvgoLkSCMZmJJaX1lSmPCnmnWyK4mJ1LxSHUemfVeSStb0Lh7tbJ76C8uBDQ6 nQAEmCJwl+mBcN0XGog6qMBBm0Ct9cpMV54MnJ8KkFAdFpShK6G93b10Y+Bw+XhIUbA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=hvB4iIuS; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BF32606A320 for ; Wed, 18 Nov 2026 14:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9BF32606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=hvB4iIuS Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4bb6886d30aso9014665e9.3 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=hvB4iIuS8DtMM18Ur596rOV7xllkzUpzo4bnzWY5k0fD7sJ/BrV+0/KQ18Tb6pH2GQ Nn2XziESA7mgE+1ydj355M2ewaMPCB3cmzRLaf+4expSmHER9hyZhW0nCxUr2loegpzU v2vTQH5dENOkhb4kscIg+aakWJcGbF9MAAkh4SZJI6rGEXhJQVQlImPEQVZy9D/uWfuh lDrFchgZk3gMfEELQRtJ9+u3oShBMhztuAghg2t6cw5GK+Z0k/4AVTMUC4iL1yw8I5bG i/Xdt4P+65LHR2xp+JkHPJ1b0MAuBhDHUI3DZNZG14O9PuuXWHSk3/UrorTKJtCBmPfK xItw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=QgmtI+7VftwLx8xM2k+cnlSmvyOogWH/tsZFLKHOIm+jTonpvGYzxvKBgYW87GXxYO cm6gSWTw+6i6AzarNtooUWiQg9F+dNRsKDarw56Pd59veG5c2xGzHy5be/JV9e8ZCKpw cSvYUCrqWE+Gj+C7RCulhcDnuV8CXePDO1IcnDR1utTLYTYVN66qu5Unb8pO2axv6PGc 5NGnDwLXsOvNI4nmj2KEGpYMfCQRdIxuFR5tfFDv6bDHw/3IrH5/ahnhEgsBKLghTUun /z0WIGIE2uQTopGEonEIyZ0Qi6o466e0vkDq6yvvoLH0+25S4HaQbslFz/jWktzPQSiB I0uw== X-Forwarded-Encrypted: i=1; AL+hErGWQ8/t0rIJFy7lbP0WxjWj4tR8Z436crMuD/xZEfX5K9dqY7PZDUacru85TsFe+MyGv46TqHYIgv6DJJ7P@vger.kernel.org X-Gm-Message-State: APuU4Z/iFnA64sZBufXBRX3cd+UJnn0wx8hdBlxwDR408nuODCQ5jPJ5 A+7DisHZefA/SDsYhAck+g2oLgfgTYRTxJXRbuW0fahOE6JI3WdXIyDrp15KqtKl6Wk= X-Gm-Gg: AYBFou0GQzJ/fps5dzzOqJZWSqsV8z8g3Jc1b6JRu8MvFv6S8PjhwwBlw0M98TM6B28 aFVdXVtQ+nadN3WH8oxo2HYCaeji+ZcSAhJz43nGMsMncDWtMlYfzFEUUtHRJLhc38ZXFj/YgE4 2MvodR2KraeevN0GZ/tPld0mG3e8t7LkrM+sJnLqDl2N3CpHoPGUM5mesBF7NDyDxTXp0C3zOF+ 9TyjBCgCmUNZ8M+BZndHZsXdE0x7Gs8uqmrJDLECJmGj6SZ7wjT+1kUJX32+h9OhFJtknuHzeE6 4x8qiS6W+bRMU2d8Wqj9LVTPQH713eu1EuCx5GVhOgXKLy/rFE+u9CZlbxpTBLSw5tRdayRj61n SKvErg9fvxUhxUEgTCj4EjbaOu+mK1pxvTlYGdc0Ky7GxD5gSJ4NhrWBl2lJwY+SKebhZnJJwGF +HYS9k2ZWZCZMsw8HfQBIwN7irPV91MrAkldLsFqu+/lwvmfX5kW9RfQ/ab0Lnj2f0NLw+mikp5 fGKCCfGMwoSWuXUmU+7VYkeZoJVyagxmgv/Lobig5AunyF/LBinmhkIkKg9f9ucV1XiPwLRtOcB oxLVAsJtwcuLxxaK7Qdp+9iG9ZhA12iuPo4= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8985606A32C for ; Wed, 18 Nov 2026 14:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=k0h1brjL; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=a7OWiBHH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=7+yyUnHygqco6Wva9mujXjYIzboHjDOMGneh/NK/Cw8=; b=k0h1brjLg9Y47gFUsZnPdb5p49 wuYeG0lwPpyrUpcgCMfUgAIx6ZSUywilin4NmIcoTntZQ7y7aRmF/+XNG2BCF/Lp1jo1hUIpWCWpD J6Sdr/lzgNtEYpdbe/vxEUIXpipWFSM/ZgVAzGJOt8j1JG5JUX8jvxf1Ybl0pgyqhmAfxyROqaUog zdgjLz8hPMnRQyGDCbTv93kH58QQkxSe1yU1fANMt1u+aO7j5xaSFjClEYYl8NMagx+OhzgmqW//S DnanZszrXwIdxTF6pkVAUrPOlrLxTq063AVddSKcXlFmYNqxsTG1xS2VIQk5QVCwHRfbu3CCRM3XJ 7Euh3yOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJH-0000000939r-3KxN; Wed, 18 Nov 2026 14:06:51 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJC-0000000936Y-0jr8 for linux-riscv@lists.infradead.org; Wed, 18 Nov 2026 14:06:49 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4bb6886d30aso9014715e9.3 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=a7OWiBHHeBpBKtUK3YqsZwYROT3IvgmEwhlPetuS3hbUlbRr10imUpHdv6Dpp+R+wT KisRdOfJX0VF6DabLD35EFA7Dui7hBEV6T74DFHVSHKTnC6bNPb3AqpLJL6WxQUzy9eW o46uMoRW/+HvWciMAq3Mel5tp/M52RDky/6heoKBFRcfJqg2/nYFG2NDy+4XndV4ye9a QWm7RfulzKFt1uWqtft6CanEwUoMrKppKO1/y1pVW73bPzoHJh/i3GJ3c+cpJxyZpCwE bFErBKRMhS1T/x0cnLX3y2jGeKTryHHkifoYXmPkVSqhfIIhbnnxtx3mUHBjxhMPlGM8 xpmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=1kwQ14Kmo3PXmPc/FbOVbuN9RsxpbNa6izZrqcdm3FkEva1UKadoadM2uDy6t1fPc9 7OY/KEjOjp5dUF/GYDWzisCnkLjxCxCA3uC681QdHzbTJk/A+o1FGKW69V83It3X9pNX xgccqd8xgeq6rNQm5xrq5PBJi3ecTVvtywl1NzrtW50jGgqsVW+KES6gsSugNZ5kTv2m MHrsZw4BrAi8LVUtWaksgLBjbFOOtSkmU/GmvDoUWaTXbpsnzJAz4RDKGcofiW4tDPPC NZhMJM4xBI7H9Dz+9EaTuD5HVAsA0g0KP+Xo674tCzEKvQYjzuWLZwBhSDrPpEGc52Zn +o0A== X-Forwarded-Encrypted: i=1; AL+hErG/xTArMgvG3q0qkMW3YFnV6ub/nSCZOEu/Xog+frcLjFxa6I5i+wvA7H/EyW5c1hUDrNcqm/IrHMENWA==@lists.infradead.org X-Gm-Message-State: APuU4Z+lzojVFi124MHnI1zEnM3dtg44gN2nt8XAkU/60T7rf/5oYO97 EDqClQvPFRfMzr68WC6DGdBQILFxX7GLZFHhd9ig8/FPh1oTKUvrJfU4iZzgH8VOXUw= X-Gm-Gg: AYBFou1yi7Pqjgt6H0F2O1JKtmaiyzW9NxtsnjlnLrrAHsOSy4U5YefFcegpHNuHzeY X6IjIollFABtwMG8/ydGlYwMb0l6nwqOZZlXItRqjF3e5AsFIX3ZXBicSkZ7NI/I87EjdN2mtim wB0uEHkR9+QZFlPt6piX2TNoqXY9lr0Ud6Tq/zXz/1ye0DrAZ16bxHIImwZzHh2ppw2PY9jYi7t OzQ4KdiDOiFs0A6DIOGZm/nOA47f1gWgseUnsY8sylaEXTUsjiYPo5wrs5Ez7hRDUXWGSqAlsEK XIAHaefo2wQmL9e/tXnLI3+og4An+gMgZKkPukF82a19it0WTQPgr/Qy6HnbE0HIdaewhy60XXY swYMTiEdlQuQXbv8P7e3CdicXVi5eUCacGvDGmkJ4lcGk0DA0ZrmQ+nwOIxoLxeMYsbAx5Gpzs1 7ug7lk9kAEExc+1zfdtwmeGjHO5dlmsEUYxmrt95+GFiRGY9qE+3VxixazI1jHX+q9yRUljgk2z LsiU0qTxwKtmHU4C+MqmxDlWisLj/Yw37XB3lAKVK7L7dJ83oj8pH/ZNP1KRTr0jPtdMun31syq +BtWXqHlp6aByB8fy2WmsDvxhWUJfW2gIcY= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_060646_613683_0CF61421 X-CRM114-Status: GOOD ( 18.81 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9203006732088308653==" Sender: "linux-riscv" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --===============9203006732088308653== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko-- --===============9203006732088308653== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============9203006732088308653==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920A0606A31C for ; Wed, 18 Nov 2026 14:06:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=VMF5yKiX; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=a7OWiBHH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=8uOatzdYUvNBX/0Zrec8IbDDvCCknNq4uZ2UuU4nLBQ=; b=VMF5yKiXCD3XMqhQx3Lfx3/a4Y PAucAixbqDUpnvTcG9vcP3x/qS0mv20sWPU8Tszi/e3RV/7OTTlmF86VRZU8JdSgWfrL28covCMaC NwyPDGZWDvJYGTXOmU42uQ4pkd+uLQrfSfWmmfGxOXyu8+CdKQ4Wyv2FtC45JShfsd86WvKpAd4Zb vE99OiT3HPRB5sogOq7eVSY9hflPmjFwuRU+E+uZBXBmXiWBre2fZv8Hedf9SevWj0/MEm+U9/onu HFJ428uoaKO2KhTYvxYZzKG7aaZ69CeTxGrSM1wAGLn1DJLQsqllwxuwxffX7GqaLH+MZNta8I1LQ ozwaDQmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJF-0000000938p-3Vub; Wed, 18 Nov 2026 14:06:49 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTgJC-0000000936X-0iyv for linux-rockchip@lists.infradead.org; Wed, 18 Nov 2026 14:06:48 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4bb68c197c7so14096855e9.1 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=a7OWiBHHeBpBKtUK3YqsZwYROT3IvgmEwhlPetuS3hbUlbRr10imUpHdv6Dpp+R+wT KisRdOfJX0VF6DabLD35EFA7Dui7hBEV6T74DFHVSHKTnC6bNPb3AqpLJL6WxQUzy9eW o46uMoRW/+HvWciMAq3Mel5tp/M52RDky/6heoKBFRcfJqg2/nYFG2NDy+4XndV4ye9a QWm7RfulzKFt1uWqtft6CanEwUoMrKppKO1/y1pVW73bPzoHJh/i3GJ3c+cpJxyZpCwE bFErBKRMhS1T/x0cnLX3y2jGeKTryHHkifoYXmPkVSqhfIIhbnnxtx3mUHBjxhMPlGM8 xpmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=XXMuL81YoeoDs2+X7juKpWmOcCC33Uf06qkkCjPdUA1QxH8oWXz0ejdTt8oi9aW2/G 2zYz+QAepLGjD2S/GNchU7bZJvuM8gx8U5v8d7S0pZyH8ulPah1fYtEwMIKzScu4TfUb 3yfzRNCJ88X5HMncnkIGY8l4epRe7tvPcXKSCmHQFu6YwAr8ATL4M9KWN5Szm1UpPcdt kl/Dxr6xCEZhe0nXYmoSqHbVoHxfs8AbBF4ZPC3oQd5k0MtHPjKPn9tWsRDuFuqFS/Kh Gc9msJ5iforShKY75eASIan2S5qaOpIA0FO6nMeVcVdIwAc4E/DAM/WVF//VxvxsvoDi 48Vg== X-Forwarded-Encrypted: i=1; AL+hErFXw4kBw0iL6SuQWUIfF4l/4lvXCarlETYU6+C+4FwJAX+zjhdawR47LEE/qYzkyu086Z/siZyk5RRcp5Xg5g==@lists.infradead.org X-Gm-Message-State: APuU4Z9f/rFjXEfUwDdXH1c4xeVZXCHsIMfhs0+S5gmj5FGG0EMtHXCp p2356WAobCnhox2xkR/dbOtBrHRrWhQ26Lz7O3y4ViqOzkR/7WMwVQPK5r5apF1QFDo= X-Gm-Gg: AYBFou1/cDD3ZG7QxXGD4HnRO7BrWfMOIJPVvX6c7pxzhzXgRpyngGKx+CJpB8iJCS3 wpmo5RR4IuR+l8C0ywdXoH9Ddg5FfxmHTyxcO+VyonR+LCyjv/krw9E9+062ZzxlnEF4261cbs7 OSIIuesUHtbGjhwjjYGNG9f3RihDxDwShignnzRBWAMao/Cua76gtRy14NPYy2gjuvueDitoRzg AxOFSbTe3meimall4xllroa9gBK/kJ3znnAZpNRZG1DKH90lke/9aPTnrnk3yDrU02kZavSyJoO sbPDI9/90HRGqeFbZJUhMH5wFf3UOOQD8agkSjZJ69GddopENfkVjTmy+w+Qxme+2kkItqqTb5A sIiiF7Klp65wgs0tTpuZyo9TBv17WUg7TEqZbTDqAm1CzJq81YuzyhZpvUdvFd9lpgB3nJZQY+B zOYdi+mn0K1dKdvPuhfQtQ7CTUhUzcFZEF2WQ7Ae0ppGJgoBRUfNyTqlbtSTN4EVlzvIyAPmPuw eKyEJ6ZRSnHG5yc6/01YHCPfbEBMDFldrJwAemhS9jVyx1HayuTVlwV7dAe11qkJnZg5FqcgnEg YpUiiFkIa6hkHUNq+PQagHYQuplFj+lSiQs= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Archived-By: MIME-Version: 1.0 In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_060646_608777_EA99E5A5 X-CRM114-Status: GOOD ( 19.03 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6845975769402555631==" Sender: "Linux-rockchip" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --===============6845975769402555631== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko-- --===============6845975769402555631== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============6845975769402555631==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A68606A320 for ; Wed, 18 Nov 2026 14:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=I2c9NUvq Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD75110FCC7; Wed, 18 Nov 2026 14:06:54 +0000 (UTC) Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 6AD394951B; Wed, 18 Nov 2026 13:47:00 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1795009620; b=XUP78lJgh9G27Mb+eh5rkwFnqF9JShkEMDGjxpGEZ1SheMlownEEny7H1SKB7ZYobXk2N ZJKKR2goxHFr1zXTCB6hF61oy1ouQp0JuIU2HZMRuEI+l72qBiCSEDiC/+mjHPdT8+Xqcz4 3xZVnuQIAJ2mdHzAQtfRWtwjEY1lcYB1wBhXGPhIn+CV6NMmFFh2iSK9i8DbNYQ7kQAtRoA xMUqsGhY+RTot7J3DnxG1MmR/iWneG92wcOy2diDeOZ2tScq6gnR8aabTiRPlNYZ2AbvAun jcxrTVzOc8r3HtyhXxkHYBV4CRS6foho9Sj1IQNt0q3tZicFmug1BkaNbiBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1795009620; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=OLYOoJSII5CdqtG2UgLrW/qjJCN/cxS++DEy/FIez32VFr4arjVGdfQJqQhbmSLDo+Sl6 KU8sV9FpqqG8GDvfaLdZzMH9fSq46pDKNmw6HfaAehS4MspIUXCydhNzk/mYuVf/LINH7dk klig49t4dxFhDCo4qsfhz9JAbNdh6DjD2Mw8dRVqtMKc0a5TXrWWGWlkX3QEcLvr5YTcv73 ciQwsA9WIbpBWOCZXrgWbkqYc/r6dc0vbgXiPMIEjRIzUhNXiFHi4cJlPCiuQqm5IeELYuc 5iKycTYX1gSGVDQo3JgugeO2F/F4lURHfWNZDg/L5DuSpW5AWoUHJlQ1K1lw== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=baylibre.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=baylibre.com policy.dmarc=none Authentication-Results: mail.freedesktop.org; dkim=pass header.d=baylibre.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=baylibre.com policy.dmarc=none Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id C9C89494A2 for ; Wed, 18 Nov 2026 13:46:56 +0000 (UTC) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id E366710EC10 for ; Wed, 18 Nov 2026 14:06:45 +0000 (UTC) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4bb68c197c7so14096835e9.1 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=I2c9NUvq+C5FWl6oDgcyVl2svEUbTiDltKnvnXOJUTtS5VF8lE4PF4TXnpIfmKhhLc FePg2dHSUPMK1ZfSD2kd42QnFIq0u0XYarUdIiwFma6iJF4p7lt1no6qF0A1CODDLXrH VCfGF4h8mlr2vkDNeRdryTV2j8W245lGCJlr+4ZCDUaolWRTZLANpx1Gt9a8lzqbVeWx oNgmr4XPecY3ySeavDFfDyMc8mKcP050Q3WCxdLiklx2DRMGDHYrxxr14kI2XXmCxxfs 92bwsUeDezBQsgUGfwY8TR+fvQ/Hn87fwEIk9OWrAdPaTjSc2o8MwjvEo3nbnm0DJ0w6 ZXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=NDlnC9FEJ0kA57AAdqdGbND07L+F2Ft86jYonqBRkmXyXvGG0uZ9qwodmHEuBH1bIC snwEYxiOn+ilsBAHZgVSLwIGp1HgrwyETLAxmzISuYET8mxuapBFgTPeOxd49sqeI6vk 1Rxt3ZjAmSQmRx0LQLegIj6QGsWClc3V6YseCuammCupPNoV7UgtZf3ys/c8BwAKk4OU 1t7+QxjYpAdTUrRbIPA59NrdaQ5u+KUFMKaCQt6G9pgJ8oniQ09nIBiu6GAWHY0pfsEB 1NsKLaVImZLLTR3SFbQWjWLZ88oY6YGtpCDeKaJZvb8p405FGtU50672H2Aaboym3a4P p87A== X-Forwarded-Encrypted: i=1; AL+hErFRmlgpDJR7VYWUTBLZhoprJbBpbZORLfNGZAVY3D4zU5idKvGLKhBKiN1FEeEvzagDbh77Zswn@lists.freedesktop.org X-Gm-Message-State: APuU4Z/VZX9x5Bv9AzB5Z+1b70H5JrTTs9kz3cKEbKEZXLqeg/4Vxi+o eoJShh96lOSZ+kGxqjAGUCXcLaofjcW/IoG37y5AZnUdkkBKCqdMcw3VWYrVZhladSI= X-Gm-Gg: AYBFou3WN+kyDw2PHTslHKeGV+NxoorS+dpXcmZ5A4NDT9epOqeDX2uvK1QiXFrXN5q SpVZDJibnupwl28M3rbl2aPWrG8lqXlv8vd5Of5S/Smw0bA1HHXZUJOIcbEK41bb7NOliFlq61K 5oPSZP7HqBmlCUcBOVt2FBlNKMqXuGbhgNadUSGFln2HsyTTUfPwUKdaLfjQRdKaNFiCyIStt2/ w+FmBW8h69aLygGoiDbyKc7DOfOGFwP8KA3uRGkeeoFnd0l2v/Pv/b0t9JYXr0O/Z1nHtHKIYgQ ux9bMOTK140KAUJJ4lPXW99MEAIUGbeqB3+rvlNmB1DpEftGzkxMcnRxFQG2N1kc+GHxBs2oK92 uSXjojc4w2KHs4O46rpu5Td9UwkcYInhV2cLVGcTt6ffbKAzC21Z7yDgvFOFiVpm0xnsWCfrGk6 8yvf9x1em27T6d/ZsEcVFgAW3SSOkSyL0yPx49mVzsgVLb1BNMA//h5yZPs6B/4q1vkvjboRJQ6 DsMDLn23jnNTswa4L7ojSwdEcnO1hxhIJrtqMssrnR17AvmYVbiO2xXlfv/qdbdacPtyPa0fj8l 3oTTey4B0PHuwwCh4mgOLzecnGe4PDw1aMU= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> Message-ID-Hash: 5UQ6PJP2EOJ76UXS27PB7N6W4KXRUJSM X-Message-ID-Hash: 5UQ6PJP2EOJ76UXS27PB7N6W4KXRUJSM X-MailFrom: ukleinek@baylibre.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko--