From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org, bea1e@proton.me,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: Re: [PATCH 4/4] nbd: Add iotest exposing previous CVE fix
Date: Wed, 18 Nov 2026 07:58:28 -0600 [thread overview]
Message-ID: <av2uZOoMR8EPh5z9@redhat.com> (raw)
In-Reply-To: <20261117220308.GA437212@shajnocz.csb>
On Tue, Nov 17, 2026 at 05:03:08PM -0500, Stefan Hajnoczi wrote:
> The new policy is not in effect yet. There are maintainers who wanted to
> discuss it at QEMU Summit but we ran out of time, so it was deferred to
> the next KVM Community Call (November 24th).
>
> If we merge this before there is a consensus, then we are overruling
> those who are not in agreement yet. I think it's too early.
Indeed, that's why I'm okay with not using patch 4 until the policy is
actually upstream, whether that's on November 24th or after 11.2 is
released.
>
> Eric: is there a way to implement the tests in
> tests/qemu-iotests/nbd-fault-injector.py? At least that already contains
> the NBD server logic and it would just be a question of adding the
> specific server responses needed to exercise the block/nbd.c code paths.
I'll play with the idea. If I can get it working, it would be a bit
stronger than my current approach of documenting a two-line hack patch
to nbd/server.c that will trigger one instance of the behavior, in
that it would be usable in a unit test rather than requiring the
reader to take additional steps to do a one-off build.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
next prev parent reply other threads:[~2026-11-18 13:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 22:34 [PATCH for-11.2 0/4] Another NBD CVE fix: incomplete read Eric Blake
2026-11-13 22:34 ` [PATCH 1/4] nbd: Refactor structured payload interpretation Eric Blake
2026-11-17 18:06 ` Stefan Hajnoczi
2026-11-13 22:34 ` [PATCH 2/4] nbd: Pass back offset/length for all structured read replies Eric Blake
2026-11-17 18:06 ` Stefan Hajnoczi
2026-11-13 22:34 ` [PATCH 3/4] nbd/client: Don't leak uninitialized memory on malicious server Eric Blake
2026-11-17 18:06 ` Stefan Hajnoczi
2026-11-13 22:34 ` [PATCH 4/4] nbd: Add iotest exposing previous CVE fix Eric Blake
2026-11-17 18:06 ` Stefan Hajnoczi
2026-11-17 20:07 ` Eric Blake
2026-11-17 20:51 ` Philippe Mathieu-Daudé
2026-11-17 22:03 ` Stefan Hajnoczi
2026-11-18 13:58 ` Eric Blake [this message]
2026-11-18 22:06 ` Eric Blake
2026-11-19 19:21 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2uZOoMR8EPh5z9@redhat.com \
--to=eblake@redhat.com \
--cc=bea1e@proton.me \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.