From: Jarkko Sakkinen <jarkko@kernel.org>
To: Henri Roosen <henri.roosen@ginzinger.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org,
Martin.Kepplinger-Novakovic@ginzinger.com
Subject: Re: [PATCH 1/1] tpm_tis_spi: add reset handling for SLM/SLB9670
Date: Wed, 18 Nov 2026 17:31:04 +0200 [thread overview]
Message-ID: <av3EuJE7vaj6NzkG@kernel.org> (raw)
In-Reply-To: <20261118151029.1259673-1-henri.roosen@ginzinger.com>
On Wed, Nov 18, 2026 at 04:10:29PM +0100, Henri Roosen wrote:
> On an i.MX8MP board, the SLM9670 could not always be successfully
> probed at boot time. The first call to tpm_tis_read32() returned with
> timeout.
>
> This turned out to be related to no reset-line handling of the chip.
> Although a reset-gpio was provided in the dts, the tpm_tis_spi driver
> didn't use it.
>
> This patch implements reset-line handling for SLM/SLB9670 when a
> reset-line is provided and uses the timings from the datasheet [1].
>
> Tested with SLM9670.
>
> [1] https://www.infineon.com/assets/row/public/documents/30/49/infineon-slb-9670vq2.0-datasheet-en.pdf
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Looks good to me! Thank you.
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Br, Jarkko
prev parent reply other threads:[~2026-11-18 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:10 [PATCH 1/1] tpm_tis_spi: add reset handling for SLM/SLB9670 Henri Roosen
2026-11-18 15:31 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av3EuJE7vaj6NzkG@kernel.org \
--to=jarkko@kernel.org \
--cc=Martin.Kepplinger-Novakovic@ginzinger.com \
--cc=henri.roosen@ginzinger.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.