All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Christian Brauner <brauner@kernel.org>
Cc: Jori Koolstra <jkoolstra@xs4all.nl>,
	viro@zeniv.linux.org.uk,  jack@suse.cz, neil@brown.name,
	cyphar@cyphar.com, jlayton@kernel.org,  amir73il@gmail.com,
	gregkh@linuxfoundation.org, tj@kernel.org,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 00/12] vfs: add O_CREAT|O_DIRECTORY to open*(2)
Date: Wed, 18 Nov 2026 08:42:47 -0800	[thread overview]
Message-ID: <av3U2jLO8Q01swyg@linux.dev> (raw)
In-Reply-To: <20261118-moment-gehhilfe-gefangen-ce4618af6b54@brauner>

On Wed, Nov 18, 2026 at 05:30:20PM +0100, Christian Brauner wrote:
> On Sat, Oct 24, 2026 at 11:35:27PM +0200, Jori Koolstra wrote:
> > This series implements new semantics for the O_CREAT|O_DIRECTORY flag
> > combination for open*(2): perform a mkdir and open the resulting
> > directory; return a pinning fd (which mkdir does not).
> 
> I've applied this to vfs-7.5.directory and folded a bunch of fixes into
> it. Each fixup is attached as a git note to the commit I folded it into
> so you can see what I massaged:
> 
> git fetch https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git \
>     +vfs-7.5.directory:refs/remotes/vfs/vfs-7.5.directory \
>     +refs/notes/vfs-7.5.directory:refs/notes/vfs-7.5.directory
> git log --notes=vfs-7.5.directory v7.4-rc1..vfs/vfs-7.5.directory
> 
> The biggest change is kernfs. kernfs_iop_mkdir() now just looks up the
> new node by name so the kernfs_syscall_ops change is gone and cgroup and
> resctrl aren't touched at all anymore.
> 
> The kernfs patches are in vfs-7.5.kernfs as "kernfs: instantiate the
> dentry in kernfs_iop_mkdir()". I'll sent that out soon.
> 
> I split out of 09/12, your kernfs_iattr_rwsem fix and the kernfs part of
> 11/12. vfs-7.5.directory is based on the first one.
> 
> I dropped "vfs: move ->create check in lookup_open() to before
> try_break_deleg()". vfs_create_no_perm() does that check itself now.
> 
> Let me know if I messed something up.

Just a heads up from my side. I will be sending couple of kernfs series over the
next couple of weeks. First one will be removing kernfs_iattr_rwsem from
mkdir/rmdir paths and later ones will be trying to make open, lookup, stat and
readdir operations lockless for kernfs.

The kernfs_iattr_rwsem one, I will send out later today.

thanks,
Shakeel

  reply	other threads:[~2026-11-18 16:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 21:35 [PATCH v8 00/12] vfs: add O_CREAT|O_DIRECTORY to open*(2) Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 01/12] fs/namei.c: use trailing_slashes() Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 02/12] vfs: prepare vfs_creat|mkdir_no_perm for reuse in lookup_open() Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 03/12] vfs: lookup_open(): move setting FMODE_CREATED down Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 04/12] vfs: move ->create check in lookup_open() to before try_break_deleg() Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 05/12] vfs: lookup_open(): use vfs_create_no_perm() Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 06/12] vfs: lookup_open(): lock the parent as I_MUTEX_PARENT Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 07/12] vfs: short-circuit MAY_WRITE access for O_DIRECTORY opens Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 08/12] kernfs: hold kernfs_iattr_rwsem when initializing a new inode Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 09/12] vfs: add O_CREAT|O_DIRECTORY to open*(2) Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 10/12] vfs: use finish_lookup() helper in __lookup_slow() and lookup_open() Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 11/12] vfs: change ->create/->mkdir operations unavailable errno Jori Koolstra
2026-10-24 21:35 ` [PATCH v8 12/12] selftest: add tests for open*(O_CREAT|O_DIRECTORY) Jori Koolstra
2026-11-04 23:44 ` [PATCH v8 00/12] vfs: add O_CREAT|O_DIRECTORY to open*(2) John Ericson
2026-11-06 14:33 ` Christian Brauner
2026-11-18 16:30 ` Christian Brauner
2026-11-18 16:42   ` Shakeel Butt [this message]
2026-11-20  8:59     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av3U2jLO8Q01swyg@linux.dev \
    --to=shakeel.butt@linux.dev \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=cyphar@cyphar.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=jkoolstra@xs4all.nl \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.