All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH] arm64: cpufeature: Check the override in __read_sysreg_by_encoding()
Date: Wed, 18 Nov 2026 18:21:00 +0000	[thread overview]
Message-ID: <av3sjKa4g6-pRE-K@arm.com> (raw)
In-Reply-To: <20261113095701.2042858-1-fuad.tabba@linux.dev>

On Fri, Nov 13, 2026 at 09:57:01AM +0000, Fuad Tabba wrote:
> __read_sysreg_by_encoding() backs the capability checks a secondary
> runs before its cpuinfo is stored, and folds an ID register override
> into the value it reads without checking it against that CPU. A
> secondary whose field is below an override the boot CPU accepted
> passes verification and comes online without the feature.
> 
> Apply the override through arm64_ftr_reg_override(), as the cpuinfo
> store does, so that it only applies where it is safe against that CPU's
> value.
> 
> Fixes: b3341ae0efa2 ("arm64: cpufeature: Use IDreg override in __read_sysreg_by_encoding()")
> Reported-by: Catalin Marinas <catalin.marinas@arm.com>
> Link: https://lore.kernel.org/all/abwXl35xQ2ze1XwJ@arm.com/
> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>

Patch looks fine but I don't think it's worth adding Fixes tag (or, if
we do, we shouldn't add cc stable; my commit hook does this
automatically).

I'd leave it for 7.5, so:

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

      reply	other threads:[~2026-11-18 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  9:57 [PATCH] arm64: cpufeature: Check the override in __read_sysreg_by_encoding() Fuad Tabba
2026-11-18 18:21 ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av3sjKa4g6-pRE-K@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=fuad.tabba@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.