From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29247606A31C for ; Wed, 18 Nov 2026 22:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ap7nC0un Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xTnny-0002t2-Oy; Wed, 18 Nov 2026 17:07:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xTnnr-0002sQ-CG for qemu-devel@nongnu.org; Wed, 18 Nov 2026 17:06:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xTnnp-0003oM-Nj for qemu-devel@nongnu.org; Wed, 18 Nov 2026 17:06:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795039611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iy4Ltp7tkXPswGY8mpjdFdIRZ1NxgI2b5RsKQGtCRiU=; b=ap7nC0unUlX77ofiqe/Y/q/u/CWyOZN8BZOfYWV2/g8aFtwNeC71SETw0DvWXN0F87jI3p CeYScI3N/2pEKowo3lYTbyhF5VyBwNV17iwXQye1wfvEtSoDVRkVgslUdTR6yvHWFwhnhF Yf9iT5IjwHruyTqpN/aUB9/rOgPm0A8= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-ngsPMUmDO3ONzachleqDVw-1; Wed, 18 Nov 2026 17:06:49 -0500 X-MC-Unique: ngsPMUmDO3ONzachleqDVw-1 X-Mimecast-MFC-AGG-ID: ngsPMUmDO3ONzachleqDVw_1795039608 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C5D511800361; Wed, 18 Nov 2026 22:06:47 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EAC06195B3C6; Wed, 18 Nov 2026 22:06:44 +0000 (UTC) Date: Wed, 18 Nov 2026 16:06:42 -0600 From: Eric Blake To: Stefan Hajnoczi Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org, bea1e@proton.me, Vladimir Sementsov-Ogievskiy , Kevin Wolf , Hanna Reitz Subject: Re: [PATCH 4/4] nbd: Add iotest exposing previous CVE fix Message-ID: References: <20261113223742.2546619-6-eblake@redhat.com> <20261113223742.2546619-10-eblake@redhat.com> <20261117180601.GA391996@shajnocz.csb> <20261117220308.GA437212@shajnocz.csb> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Nov 18, 2026 at 07:58:33AM -0600, Eric Blake wrote: > > Eric: is there a way to implement the tests in > > tests/qemu-iotests/nbd-fault-injector.py? At least that already contains > > the NBD server logic and it would just be a question of adding the > > specific server responses needed to exercise the block/nbd.c code paths. > > I'll play with the idea. If I can get it working, it would be a bit > stronger than my current approach of documenting a two-line hack patch > to nbd/server.c that will trigger one instance of the behavior, in > that it would be usable in a unit test rather than requiring the > reader to take additional steps to do a one-off build. It turns out the bug is only triggered by structured replies, while nbd-fault-injector.py is currently only producing simple replies, so it is a bigger task to improve that file to the point of doing structured replies; and it is going to be faster for me to provide a one-off patch that makes a one-off build of QEMU non-compliant than to add features to a python script. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org