From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 19/20] drm/nouveau: Allow platform driver build with COMPILE_TEST=y
Date: Thu, 19 Nov 2026 00:28:26 +0200 [thread overview]
Message-ID: <av4miu_2zQEDnBJx@intel.com> (raw)
In-Reply-To: <sashiko-outbox-222062@kernel.org>
On Wed, Nov 18, 2026 at 09:57:31PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Medium] drm/nouveau: build failure in nouveau_platform_resume() when
> PM_DEVFREQ=n
> --
>
> commit 7f3a768f8ef913fb90efb9c01241f3d8714fc297
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> drm/nouveau: Allow platform driver build with COMPILE_TEST=y
>
> This commit allows NOUVEAU_PLATFORM_DRIVER to be enabled when COMPILE_TEST=y
> even on non-Tegra architectures.
>
> > diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> > index 3b5757aed9c84..d7b432c839e5f 100644
> > --- a/drivers/gpu/drm/nouveau/Kconfig
> > +++ b/drivers/gpu/drm/nouveau/Kconfig
> > @@ -34,7 +34,7 @@ config DRM_NOUVEAU
> >
> > config NOUVEAU_PLATFORM_DRIVER
> > bool "Nouveau (NVIDIA) SoC GPUs"
> > - depends on DRM_NOUVEAU && ARCH_TEGRA
> > + depends on DRM_NOUVEAU && (ARCH_TEGRA || COMPILE_TEST)
> > default y
> > help
> > Support for Nouveau platform driver, used for SoC GPUs as found
>
> [Severity: Medium]
> Does this break the build in nouveau_platform_resume() when
> CONFIG_PM_SLEEP=y and CONFIG_PM_DEVFREQ=n?
>
> DRM_NOUVEAU only has "select PM_DEVFREQ if ARCH_TEGRA", so when
> ARCH_TEGRA=n and COMPILE_TEST=y, CONFIG_PM_DEVFREQ can remain disabled.
> The fallback stub for gk20a_devfreq_resume() in
> drivers/gpu/drm/nouveau/nvkm/subdev/clk/gk20a_devfreq.h is missing the
> pointer asterisk on its parameter:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/clk/gk20a_devfreq.h:
> #if defined(CONFIG_PM_DEVFREQ)
> int gk20a_devfreq_init(struct nvkm_clk *base, struct gk20a_devfreq **devfreq);
> int gk20a_devfreq_resume(struct device *dev);
> int gk20a_devfreq_suspend(struct device *dev);
> #else
> static inline int gk20a_devfreq_init(struct nvkm_clk *base, struct gk20a_devfreq **devfreq)
> {
> return 0;
> }
>
> static inline int gk20a_devfreq_resume(struct device dev) { return 0; }
> static inline int gk20a_devfreq_suspend(struct device *dev) { return 0; }
> #endif
>
> Passing struct device *dev from nouveau_platform_resume() to
> gk20a_devfreq_resume() then fails to compile with an incompatible type
> error.
Ack. Fix is now on my local branch. I'll include it if/when I resend.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-11-18 22:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 21:44 [PATCH v4 00/20] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
2026-11-18 21:44 ` Ville Syrjala
2026-11-18 21:44 ` [PATCH v4 01/20] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
2026-11-18 21:44 ` [PATCH v4 02/20] drm/tilcdc: Drop volatile from the mmio pointer in tilcdc_write64() Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 03/20] drm/tilcdc: Use __le64 for the fallback 64bit write Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 04/20] drm/tilcdc: Fix endpoint node names in the legacy panel overlay Ville Syrjala
2026-11-19 9:32 ` Kory Maincent
2026-11-18 21:45 ` [PATCH v4 05/20] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 06/20] drm/armada: Fix printk arguments Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 07/20] drm/armada: Fix armada_debugfs_crtc_reg_write() return type Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 08/20] drm/armada: Fix sparse __iomem address space warnings Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 09/20] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 10/20] drm/fsl-dcu: " Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 11/20] drm/adp: Include linux/bitfield.h Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 12/20] drm/adp: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 13/20] drm/imagination: Include io-64-nonatomic-lo-hi.h Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 14/20] drm/imagination: Use rcu_access_pointer() for dma_fence::ops Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 15/20] drm/imagination: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:58 ` sashiko-bot
2026-11-18 22:30 ` Ville Syrjälä
2026-11-18 21:45 ` [PATCH v4 16/20] drm/imagination: Drop stale kernel-doc for pvr_mmu_backing_page.pvr_dev Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 17/20] drm/imagination: Fix kernel-doc for pvr_mmu_op_context anonymous structs Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 18/20] drm/ingenic: Allow ingenic-dw-hdmi build with COMPILE_TEST=y Ville Syrjala
2026-11-19 9:31 ` Paul Cercueil
2026-11-18 21:45 ` [PATCH v4 19/20] drm/nouveau: Allow platform driver " Ville Syrjala
2026-11-18 21:45 ` Ville Syrjala
2026-11-18 21:57 ` sashiko-bot
2026-11-18 22:28 ` Ville Syrjälä [this message]
2026-11-20 5:33 ` kernel test robot
2026-11-20 5:33 ` kernel test robot
2026-11-18 21:45 ` [PATCH v4 20/20] drm/rcar-du: Allow VSP and writeback " Ville Syrjala
2026-11-18 22:11 ` Laurent Pinchart
2026-11-18 22:32 ` Ville Syrjälä
2026-11-18 22:39 ` Laurent Pinchart
2026-11-18 22:57 ` Ville Syrjälä
2026-11-18 23:14 ` Laurent Pinchart
2026-11-19 7:38 ` Geert Uytterhoeven
2026-11-19 8:16 ` Laurent Pinchart
2026-11-19 8:23 ` Geert Uytterhoeven
2026-11-19 7:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av4miu_2zQEDnBJx@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.