From: "Oscar Salvador (SUSE)" <osalvador@kernel.org>
To: Nilay Vaish <nilayvaish@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Zi Yan <ziy@nvidia.com>, Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/page_owner: fix double decrement of stack count on unpoison
Date: Thu, 19 Nov 2026 14:23:26 +0100 [thread overview]
Message-ID: <av74TpCUPQkXFkOH@localhost.localdomain> (raw)
In-Reply-To: <20261118212819.403059-1-nilayvaish@google.com>
On Wed, Nov 18, 2026 at 01:28:19PM -0800, Nilay Vaish wrote:
> page_owner counts, for each allocation stack, how many pages allocated
> from that stack are still in use. The count is incremented when a page
> is allocated and decremented in __reset_page_owner() when it is freed.
>
> A page that is hwpoisoned while in use and later unpoisoned passes
> through free_pages_prepare() twice:
>
> 1. On poisoning, the last reference is dropped. free_pages_prepare()
> calls reset_page_owner() but, because the page is PageHWPoison(),
> keeps it off the free lists.
>
> 2. On unpoisoning, unpoison_memory() drops the poison reference and
> free_pages_prepare() calls reset_page_owner() again, this time
> really freeing the page.
>
> __reset_page_owner() decrements the stack count both times, although
> the page was allocated only once. The first call clears
> PAGE_EXT_OWNER_ALLOCATED, but the second call never checks it.
>
> If this drives the count to zero while the stack is still in use,
> stackdepot treats the record as freed and warns on every later
> allocation or free that uses the same stack:
>
> dec_stack_record_count: refcount went to 0 for 92274844 handle
> WARNING: lib/stackdepot.c:517 at depot_fetch_stack+0x5c/0x70
> Call Trace:
> __set_page_owner+0x110/0x290
> get_page_from_freelist+0x1225/0x1440
> __alloc_frozen_pages_noprof+0x1fc/0x1b00
> __folio_alloc_noprof+0x12/0xa0
> alloc_migration_target+0x81/0x1e0
> migrate_pages_batch+0x1f2/0x14c0
> migrate_pages+0x9c3/0xca0
> soft_offline_page+0x189/0x570
>
> A single soft offline followed by an unpoison is enough to trigger it,
> because the migration-target stack that the offlined page is accounted
> to usually has very few pages.
>
> Fix it by decrementing the stack count only if PAGE_EXT_OWNER_ALLOCATED
> was still set, i.e. only the first time the page is freed.
>
> To reproduce, boot with page_owner=on and CONFIG_HWPOISON_INJECT, soft
> offline anonymous pages with madvise(MADV_SOFT_OFFLINE), and unpoison
> each old PFN through debugfs hwpoison/unpoison-pfn. Without this patch
> the first cycle prints the message above and 2200 cycles produce 6597
> warnings. With it, the same run is clean and all stack counts return
> to their initial values.
>
> Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nilay Vaish <nilayvaish@google.com>
Reviewed-by: Oscar Salvador (SUSE) <osalvador@kernel.org>
Nit below:
> ---
> mm/page_owner.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 02bb304b53cf..0793a460d615 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -320,11 +320,13 @@ void __reset_page_owner(struct page *page, unsigned short order)
> depot_stack_handle_t alloc_handle;
> struct page_owner *page_owner;
> u64 free_ts_nsec = local_clock();
> + bool allocated;
>
> page_ext = page_ext_get(page);
> if (unlikely(!page_ext))
> return;
>
> + allocated = test_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags);
> page_owner = get_page_owner(page_ext);
> alloc_handle = page_owner->handle;
> page_ext_put(page_ext);
> @@ -339,7 +341,7 @@ void __reset_page_owner(struct page *page, unsigned short order)
> __update_page_owner_free_handle(page, handle, order, current->pid,
> current->tgid, free_ts_nsec);
>
> - if (alloc_handle != early_handle)
> + if (allocated && alloc_handle != early_handle) {
> /*
> * early_handle is being set as a handle for all those
> * early allocated pages. See init_pages_in_zone().
> @@ -348,6 +350,7 @@ void __reset_page_owner(struct page *page, unsigned short order)
> * their refcount either.
> */
I would expand this comment to integrate the allocated logic.
Because someone might think that every page hitting this function should have
been previously allocated.
--
Oscar Salvador
SUSE Labs
prev parent reply other threads:[~2026-11-19 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 21:28 [PATCH] mm/page_owner: fix double decrement of stack count on unpoison Nilay Vaish
2026-11-19 11:53 ` Jose A. Perez de Azpillaga
2026-11-19 13:23 ` Oscar Salvador (SUSE) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av74TpCUPQkXFkOH@localhost.localdomain \
--to=osalvador@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=brendan.jackman@linux.dev \
--cc=elver@google.com \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=nilayvaish@google.com \
--cc=osalvador@suse.de \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.