From: Patrick Steinhardt <ps@pks.im>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Matthew E. Luallen" <m@sph3r3.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 0/2] archive, apply: do not truncate files of 4GiB or more
Date: Thu, 19 Nov 2026 10:53:53 +0100 [thread overview]
Message-ID: <av7HMbnylHiz_MVz@pks.im> (raw)
In-Reply-To: <20261119065711.827536-1-gitter.spiros@gmail.com>
On Thu, Nov 19, 2026 at 07:57:11AM +0100, Elia Pinto wrote:
> Hi,
>
> A gentle ping on this two-patch series, which has had no comments so
> far. It still applies cleanly to current master (e1ec09b23c) and
> merges cleanly with 'seen'.
>
> 1/2 (archive) stands on its own. 2/2 (apply) has a question I should
> have raised in the cover letter. It fixes the file written to the
> working tree, but with --index, and so with "git am", the result still
> goes through odb_write_object(), whose length is an "unsigned long"
> until "use size_t for a few more object and buffer sizes" [1] lands.
> Where "long" has 32 bits while size_t has 64, the blob written to the
> index is then still truncated, while the working tree file is now
> complete.
>
> I see two ways to handle that:
>
> - pass the size through cast_size_t_to_ulong() in add_index_file(),
> so that "git apply --index" dies instead, as 5/5 of the loose object
> series [2] does for notes, and drop the cast once [1] is in;
>
> - hold back 2/2 until [1] lands, as Patrick suggested for a similar
> case in the pack-receive series [3].
>
> Which one would you prefer?
I'd prefer the latter. So how about you send a new, rebased version of
this series once it has landed?
Patrick
next prev parent reply other threads:[~2026-11-19 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 9:19 [PATCH 0/2] archive, apply: do not truncate files of 4GiB or more Elia Pinto
2026-11-01 9:19 ` [PATCH 1/2] archive: use size_t for the size of archive entries Elia Pinto
2026-11-01 9:19 ` [PATCH 2/2] apply: use size_t for the size of the result written out Elia Pinto
2026-11-19 6:57 ` [PATCH 0/2] archive, apply: do not truncate files of 4GiB or more Elia Pinto
2026-11-19 9:53 ` Patrick Steinhardt [this message]
2026-11-19 17:48 ` Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7HMbnylHiz_MVz@pks.im \
--to=ps@pks.im \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gitter.spiros@gmail.com \
--cc=l.s.r@web.de \
--cc=m@sph3r3.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.