All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, crosa@redhat.com,
	marcandre.lureau@redhat.com
Subject: Re: [PATCH] python/qemu: Don't choke on unknown members in QMP replies
Date: Thu, 19 Nov 2026 11:36:16 +0000	[thread overview]
Message-ID: <av7fMIyo2kBS9azb@redhat.com> (raw)
In-Reply-To: <20261118182005.1066151-1-armbru@redhat.com>

On Wed, Nov 18, 2026 at 07:20:05PM +0100, Markus Armbruster wrote:
> The recent addition of @qapi-type to ObjectPropertyInfo and
> ObjectPropertyValue broke the corresponding classes in
> qemu/utils/qom_common.  Reproducer:
> 
>     $ bld/run qom-list -s qmp-socket /chardevs
>     Traceback (most recent call last):
>       File "/work/armbru/qemu/bld/pyvenv/bin/qom-list", line 8, in <module>
>         sys.exit(QOMList.entry_point())
>                  ~~~~~~~~~~~~~~~~~~~^^
>       File "/work/armbru/qemu/python/qemu/utils/qom_common.py", line 230, in entry_point
>         return cls.command_runner(args)
>                ~~~~~~~~~~~~~~~~~~^^^^^^
>       File "/work/armbru/qemu/python/qemu/utils/qom_common.py", line 215, in command_runner
>         return cmd.run()
>                ~~~~~~~^^
>       File "/work/armbru/qemu/python/qemu/utils/qom.py", line 179, in run
>         rsp = self.qom_list(self.path)
>       File "/work/armbru/qemu/python/qemu/utils/qom_common.py", line 192, in qom_list
>         return [ObjectPropertyInfo.make(x) for x in rsp]
>                 ~~~~~~~~~~~~~~~~~~~~~~~^^^
>       File "/work/armbru/qemu/python/qemu/utils/qom_common.py", line 52, in make
>         assert value.keys() <= {'name', 'type', 'description', 'default-value'}
>                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     AssertionError
> 
> This asserts "no members we don't know".  There are two more like it.
> 
> Adding @qapi-type broke them.
> 
> docs/devel/qapi-code-gen.rst section "Compatibility considerations"
> stipulates that "clients are expected to ignore [members] they don't
> know."

Yes, that is critical as we want to retain the right to add new
members at any time without breaking apps.

> 
> Delete / relax these assertions.
> 
> Fixes: 0eee31cf1085 ("qapi/qom: add qapi-type to qom-list, qom-list-properties, qom-list-get")
> Fixes: c750c02891a8 ("python/qmp: Add qom script rewrites")
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  python/qemu/utils/qom_common.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  reply	other threads:[~2026-11-19 11:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:20 [PATCH] python/qemu: Don't choke on unknown members in QMP replies Markus Armbruster
2026-11-19 11:36 ` Daniel P. Berrangé [this message]
2026-11-19 18:11 ` John Snow
2026-11-20  4:35   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7fMIyo2kBS9azb@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.