From: Nicolas Schier <n.schier@fritz.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: "Sasha Levin" <sashal@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Harald Freudenberger" <freude@linux.ibm.com>,
"Holger Dengler" <dengler@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-kbuild@vger.kernel.org, linux-s390@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
"kernelci.org bot" <bot@kernelci.org>,
"Nicolas Schier" <nsc@kernel.org>
Subject: Re: [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
Date: Thu, 19 Nov 2026 16:24:47 +0100 [thread overview]
Message-ID: <av8Uv7EV3sLqUBfr@derry.ads.avm.de> (raw)
In-Reply-To: <179424040477.1704532.18231793404479518924.b4-ty@b4>
Hi,
I have a question regarding best-practise:
On Mon, Nov 09, 2026 at 05:07:05PM +0100, Nicolas Schier wrote:
> On Mon, 09 Nov 2026 09:14:41 -0500, Sasha Levin wrote:
> > Since commit cdfdbc11552b ("Move struct cpu_feature to
> > <linux/cpufeature.h>"), devicetable-offsets.c includes
> > <linux/cpufeature.h>, which includes <asm/cpufeature.h> on architectures
> > that select GENERIC_CPU_AUTOPROBE. On loongarch and mips that header
> > pulls in <asm/elf.h>, and from there <linux/fs.h> and <linux/mmzone.h>,
> > which need <generated/bounds.h>. devicetable-offsets.c is built before
> > that header is generated, so even defconfig fails on both:
> >
> > [...]
>
> Applied to kbuild/linux.git (kbuild-next-unstable), thanks!
>
> [2/2] devicetable-offsets: Get struct cpu_feature from a device-id header
> https://git.kernel.org/kbuild/c/50ccc340
I applied this fix on kbuild-next-unstable (and rebased today [1]), two
commits after "Move struct cpu_feature to <linux/cpufeature.h>" [2],
which is being "fixed" by this patch.
If we keep it this way, a bisect may hit the issue; folding does not
look correct to me as that would mix-up related but different things.
So my questions:
* Shall we keep it the way it is to keep the original patch order
(bisect might fail on the two commits before this patch)?
* Or shall the patch be moved before Uwe's (removing the 'Fixes' tag,
and rewriting the commit msg)?
I am in favor of the latter. Are there any objections?
[1]: https://git.kernel.org/kbuild/c/f1dc66c38b7eb4b2fb946a2fd6929250ecd2d85a
[2]: https://patch.msgid.link/bc9fbf5784f6788e10c749a05d56c42bdb68f3d9.1792144769.git.u.kleine-koenig@baylibre.com
--
Nicolas
next prev parent reply other threads:[~2026-11-19 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 10:09 [PATCH v2 0/3] <linux/mod_devicetable.h> deprecation continues Uwe Kleine-König (The Capable Hub)
2026-10-16 10:09 ` [PATCH v2 1/3] Move struct cpu_feature to <linux/cpufeature.h> Uwe Kleine-König (The Capable Hub)
2026-10-16 10:09 ` [PATCH v2 2/3] devicetable-offsets: Include the needed device-id headers instead of the catch-all Uwe Kleine-König (The Capable Hub)
2026-10-16 10:09 ` [PATCH v2 3/3] file2alias: " Uwe Kleine-König (The Capable Hub)
2026-11-08 19:20 ` [PATCH v2 0/3] <linux/mod_devicetable.h> deprecation continues Nicolas Schier
2026-11-09 14:14 ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Sasha Levin
2026-11-09 14:14 ` [PATCH 2/2] devicetable-offsets: Get struct cpu_feature from a device-id header Sasha Levin
2026-11-09 15:57 ` Uwe Kleine-König
2026-11-09 16:07 ` Nicolas Schier
2026-11-19 15:24 ` Nicolas Schier [this message]
2026-11-19 19:47 ` Nathan Chancellor
2026-11-20 11:25 ` Uwe Kleine-König
2026-11-20 20:21 ` Nicolas Schier
2026-11-20 20:27 ` [PATCH] Move struct cpu_feature to a <linux/device-id/cpu_feature.h> Nicolas Schier
2026-11-09 15:48 ` [PATCH 1/2] s390/pkey: Include <linux/device-id/ap.h> for struct ap_device_id Uwe Kleine-König
2026-11-13 13:38 ` Harald Freudenberger
2026-11-09 16:07 ` Nicolas Schier
2026-11-13 13:30 ` Harald Freudenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8Uv7EV3sLqUBfr@derry.ads.avm.de \
--to=n.schier@fritz.com \
--cc=agordeev@linux.ibm.com \
--cc=bot@kernelci.org \
--cc=chenhuacai@kernel.org \
--cc=dengler@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kernel@xen0n.name \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=sashal@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.