All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: Tianyi Gao <tianyi@cloudflare.com>
Cc: netdev@vger.kernel.org, magnus.karlsson@intel.com,
	 maciej.fijalkowski@intel.com, sdf@fomichev.me,
	davem@davemloft.net, edumazet@kernel.org,  kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, ast@kernel.org,
	 daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
	 yoong.siang.song@intel.com, kerneljasonxing@gmail.com,
	bpf@vger.kernel.org,  linux-kernel@vger.kernel.org,
	kernel-team@cloudflare.com, tianyi.gao@linux.dev,
	 Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH net] xsk: reject TX checksum requests that overflow skb->csum_start
Date: Thu, 19 Nov 2026 08:51:11 -0800	[thread overview]
Message-ID: <av8o-Egamsxv-uWn@devvm16445.scu0.facebook.com> (raw)
In-Reply-To: <20261116162834.30087-1-tianyi@cloudflare.com>

On 11/16, Tianyi Gao wrote:
> xsk_skb_metadata() sets the u16 skb->csum_start to hr + csum_start. With
> 64K pages, csum_start can be close to U16_MAX, so the sum can overflow.
> The checksum offset then becomes negative. With XDP_UMEM_TX_SW_CSUM,
> skb_checksum_help() triggers a warning. Without it, the device gets a
> CHECKSUM_PARTIAL skb with a negative offset.
> 
> Reject this with -EINVAL. Use the limit of skb_partial_csum_set(), which
> also rejects U16_MAX, the "not set" value of transport_header. That
> helper cannot be used here, as the skb built for an IFF_TX_SKB_NO_LINEAR
> device has no linear data.
> 
> Fixes: 48eb03dd2630 ("xsk: Add TX timestamp and TX checksum offload support")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/all/sashiko-outbox-203545@kernel.org/
> Signed-off-by: Tianyi Gao <tianyi@cloudflare.com>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

  parent reply	other threads:[~2026-11-19 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:28 [PATCH net] xsk: reject TX checksum requests that overflow skb->csum_start Tianyi Gao
2026-11-16 16:32 ` netdev-bot+sinfo
2026-11-16 17:03   ` Tianyi Gao
2026-11-19 16:51 ` Stanislav Fomichev [this message]
2026-11-19 23:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8o-Egamsxv-uWn@devvm16445.scu0.facebook.com \
    --to=sdf.kernel@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@cloudflare.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sdf@fomichev.me \
    --cc=tianyi.gao@linux.dev \
    --cc=tianyi@cloudflare.com \
    --cc=yoong.siang.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.