From: Nicolin Chen <nicolinc@nvidia.com>
To: John Garry <john.garry@arm.com>
Cc: <will@kernel.org>, <jgg@nvidia.com>, <robin.murphy@arm.com>,
<joro@8bytes.org>, <praan@google.com>, <kevin.tian@intel.com>,
<smostafa@google.com>, <linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<jamien@nvidia.com>, <kas@kernel.org>,
Cristian Prundeanu <cpru@amazon.com>,
Breno Leitao <leitao@kernel.org>, <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v13 07/12] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for kdump kernel
Date: Thu, 19 Nov 2026 08:49:03 -0800 [thread overview]
Message-ID: <av8ofzh/uhpBjmxC@nvidia.com> (raw)
In-Reply-To: <bbe0db50-acd2-4fb2-a0a4-8fb80e85fb29@arm.com>
On Thu, Nov 19, 2026 at 10:55:59AM +0000, John Garry wrote:
> On 11/17/26 19:21, Nicolin Chen wrote:
> > + if (fmt == STRTAB_BASE_CFG_FMT_2LVL) {
> > + /*
> > + * Both kernels run on the same hardware, so it's impossible for
> > + * kdump kernel to see the support for linear stream table only.
> > + */
> > + if (WARN_ON(FIELD_GET(IDR0_ST_LVL, idr0) != IDR0_ST_LVL_2LVL)) {
> > + ret = -EINVAL;
> > + } else {
> > + smmu->features |= ARM_SMMU_FEAT_2_LVL_STRTAB;
> > + ret = arm_smmu_kdump_adopt_strtab_2lvl(smmu, cfg_reg,
> > + base);
> > + }
> > + } else if (fmt == STRTAB_BASE_CFG_FMT_LINEAR) {
> > + /*
> > + * The kdump kernel need not match the crashed kernel. An older
> > + * crashed kernel that predates two-level stream table support
> > + * may have used a linear table on 2-level-capable hardware, so
> > + * enforce the same format here to match the adopted table.
> > + */
>
> The mainline kernel has always supported and favoured a 2-level table, no?
Yes. But here are just a few extra lines to support the kdump from
a modified kernel to a mainline code. I believe we can afford it.
Nicolin
next prev parent reply other threads:[~2026-11-19 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 19:21 [PATCH v13 00/12] iommu/arm-smmu-v3: Adopt the crashed kernel's stream table for kdump Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 01/12] iommu: Pass in NULL old_domain when attaching a deferred device Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 02/12] iommu/arm-smmu-v3: Init the vmid_map ida before the stream table setup Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 03/12] iommu/arm-smmu-v3: Make the ASID space per SMMU instance Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources Nicolin Chen
2026-11-19 10:55 ` John Garry
2026-11-19 16:50 ` Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 05/12] iommu/arm-smmu-v3: Add ARM_SMMU_FEAT_EVTQ for the event queue Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 06/12] iommu/arm-smmu-v3: Disable the EVTQ and the PRIQ in a kdump kernel Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 07/12] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for " Nicolin Chen
2026-11-19 10:55 ` John Garry
2026-11-19 16:49 ` Nicolin Chen [this message]
2026-11-17 19:21 ` [PATCH v13 08/12] iommu/arm-smmu-v3-kexec: Reserve crashed kernel's ASIDs and VMIDs Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 09/12] iommu/arm-smmu-v3-kexec: Implement is_attach_deferred() Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 10/12] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 11/12] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption Nicolin Chen
2026-11-17 19:21 ` [PATCH v13 12/12] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP_ADOPT in probe() Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8ofzh/uhpBjmxC@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=cpru@amazon.com \
--cc=iommu@lists.linux.dev \
--cc=jamien@nvidia.com \
--cc=jgg@nvidia.com \
--cc=john.garry@arm.com \
--cc=joro@8bytes.org \
--cc=kas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=leitao@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.