All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dmaengine@vger.kernel.org, Frank Li <Frank.Li@kernel.org>,
	Vinod Koul <vkoul@kernel.org>, Viresh Kumar <vireshk@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
Date: Thu, 19 Nov 2026 19:36:08 +0200	[thread overview]
Message-ID: <av8ziPUCh4wZPyr6@ashevche-desk.local> (raw)
In-Reply-To: <c5e756c6-2449-4079-a924-15a6bfdef848@web.de>

On Thu, Nov 19, 2026 at 06:27:40PM +0100, Markus Elfring wrote:
> >> Reuse existing functionality from devm_clk_get_optional_enabled()
> >> instead of keeping duplicate source code.
> >>
> >> The source code was transformed by using the Coccinelle software.
> > 
> > Something is wrong with your tools or scripts. It now brings a regression.
> Would you like to extend background information?

You are not the first year in this project, find the answer yourself.
Hint: what devm_*() actually do and when?

> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/clk.h#L680-L699
> …
>  * devm_clk_get_optional_enabled - devm_clk_get_optional() +
>  *                                 clk_prepare_enable()
> …

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-19 17:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:06 [PATCH] dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe() Markus Elfring
2026-11-19 16:12 ` sashiko-bot
2026-11-19 16:53   ` Frank Li
2026-11-19 17:22     ` Markus Elfring
2026-11-19 17:41       ` Frank Li
2026-11-19 18:09         ` Markus Elfring
2026-11-19 17:16 ` [PATCH] " Andy Shevchenko
2026-11-19 17:27   ` Markus Elfring
2026-11-19 17:36     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8ziPUCh4wZPyr6@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Frank.Li@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vireshk@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.