From: Eric Blake <eblake@redhat.com>
To: Guillaume Vincke <guillaume.vincke@ovhcloud.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com,
stefanha@redhat.com, fam@euphon.net
Subject: Re: [PATCH 1/5] block/nbd: Extract request slot access and reconnection
Date: Thu, 19 Nov 2026 16:16:19 -0600 [thread overview]
Message-ID: <av90YxzbatWpzCf9@redhat.com> (raw)
In-Reply-To: <20261119144632.232457-2-guillaume.vincke@ovhcloud.com>
On Thu, Nov 19, 2026 at 03:46:28PM +0100, Guillaume Vincke wrote:
> The number of concurrent requests in the NBD block driver is bounded by
> MAX_NBD_REQUESTS. When reaching that level of concurrency, we park
> coroutines in a queue and, on completion, we resume the first. That
> logic is implemented in nbd_co_send_request().
> Coroutines also get queued when the channel is disconnected to make
> sure only one request triggers reconnection.
>
> This patch extracts nbd_co_acquire_slot(), nbd_co_release_slot() and
> nbd_co_reconnect() out of the request sending. This will help use
> nbd_reconnect_attempt() outside of the request sending logic in a later
> patch of the series.
>
> No functional change.
>
> Signed-off-by: Guillaume Vincke <guillaume.vincke@ovhcloud.com>
> ---
> block/nbd.c | 56 ++++++++++++++++++++++++++++++++++++++---------------
> 1 file changed, 40 insertions(+), 16 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
next prev parent reply other threads:[~2026-11-19 22:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 14:46 [PATCH 0/5] block/nbd: Fix block resize on idle device Guillaume Vincke
2026-11-19 14:46 ` [PATCH 1/5] block/nbd: Extract request slot access and reconnection Guillaume Vincke
2026-11-19 22:16 ` Eric Blake [this message]
2026-11-19 14:46 ` [PATCH 2/5] block: Refresh the connection before block_resize Guillaume Vincke
2026-11-19 22:32 ` Eric Blake
2026-11-20 10:40 ` guillaume vincke
2026-11-19 14:46 ` [PATCH 3/5] block/nbd: Refresh the connection on block_resize Guillaume Vincke
2026-11-19 16:25 ` Eric Blake
2026-11-20 10:12 ` guillaume vincke
2026-11-19 14:46 ` [PATCH 4/5] iotests: Add coverage for NBD resize Guillaume Vincke
2026-11-19 22:51 ` Eric Blake
2026-11-20 10:17 ` guillaume vincke
2026-11-19 14:46 ` [PATCH 5/5] block: Add refresh connection support to raw and luks Guillaume Vincke
2026-11-19 16:20 ` [PATCH 0/5] block/nbd: Fix block resize on idle device Eric Blake
2026-11-20 10:04 ` guillaume vincke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av90YxzbatWpzCf9@redhat.com \
--to=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=guillaume.vincke@ovhcloud.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.