From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A894606A320 for ; Thu, 19 Nov 2026 19:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=a/xkwJ7E Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xU81O-0005RW-10; Thu, 19 Nov 2026 14:42:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xU81L-0005R7-OW for qemu-devel@nongnu.org; Thu, 19 Nov 2026 14:42:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xU81K-00041i-AU for qemu-devel@nongnu.org; Thu, 19 Nov 2026 14:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795117329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D/wFHmOxSxMOfuYu1fa178IWltzDVNQ2Xgb6O8sgT0c=; b=a/xkwJ7EPnDwOjHz64rcLkZzcj9eyXa5AdcHq3XyMRbE9dtoBFr9F8tRvCkQQ4BdHAn8qz y4ZJBwdi5zk7x+1rbLsbApufaTGQsObG23zYLb5InsN1N/tZ8A9MslBx3SqS7MN1jhqNXj eDI2BKfCSVfdGzrd2uqlVSURFtDtWOo= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-F0tuvSYQO8u3_HA8kmiKDQ-1; Thu, 19 Nov 2026 14:42:05 -0500 X-MC-Unique: F0tuvSYQO8u3_HA8kmiKDQ-1 X-Mimecast-MFC-AGG-ID: F0tuvSYQO8u3_HA8kmiKDQ_1795117324 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 00BAA1801347; Thu, 19 Nov 2026 19:42:04 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 353201801971; Thu, 19 Nov 2026 19:42:00 +0000 (UTC) Date: Thu, 19 Nov 2026 13:41:58 -0600 From: Eric Blake To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf , Hanna Reitz Subject: Re: [PATCH for-11.2 2/2] tests/qemu-iotest: Add test for qcow2 image with empty reftable Message-ID: References: <20261119140338.2918386-1-peter.maydell@linaro.org> <20261119140338.2918386-3-peter.maydell@linaro.org> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261119140338.2918386-3-peter.maydell@linaro.org> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 19, 2026 at 02:03:38PM +0000, Peter Maydell wrote: > This test creates a qcow2 image, manually zeroes out its entire > reftable, and then runs 'qemu-img amend -o refcount_bits=64" on it. > This used to cause qemu-img to crash; now we will report that the > image can't be opened because it's corrupted. > > Signed-off-by: Peter Maydell > --- > tests/qemu-iotests/315 | 59 ++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/315.out | 9 ++++++ These days, it seems better to create named tests under qemu-iotests/tests, rather than as a new three-digit number. But a file rename is trivial enough that I fine with giving my review, whether or not we adjust the patch. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org