Re: [PATCH v3 0/4] arm64: dts: qcom: nord: Add USB support

[Bjorn Andersson <andersson@kernel.org>]

On Tue, Oct 13, 2026 at 01:34:45PM +0200, Bartosz Golaszewski wrote:
> Note: This is v7.4 material and depends on several patches that are
> still not in linux-next. Sending it out to solicit reviews.
> 
> This series enables USB on the Qualcomm Nord platform which has three
> USB controllers:
> 
>   usb_0 (0xa600000)  eUSB2 + USB3/DP combo PHY
>   usb_1 (0xa400000)  eUSB2 + USB3/DP combo PHY
>   usb_2 (0xa200000)  eUSB2 only, high-speed
> 
> The first patch is a fix for the i2c9/i2c10 pin functions, which is a
> prerequisite because the eUSB2 repeaters and the Type-C controller all
> sit on i2c9.
> 
> Patch 2 adds the three DWC3 controller nodes to nord.dtsi.  They are
> kept as far as possible free of anything variant specific, so the
> clocks, resets, power domains, interconnects and PHY references are
> added separately in patch 3 for the "embedded" variant, alongside the
> five PHY nodes (three eUSB2, two QMP combo).  Adding the QMP PHYs also
> lets the two pipe clock placeholders in negcc be filled in.
> 
> Patches 4 and 5 wire the ports up per board.
> 
> Nord RRD:
> 
>   usb_0  OTG, USB-C, FUSB15201 Type-C/PD controller
>   usb_1  host, Genesys GL3590 HS/SS onboard hub pair
>   usb_2  left disabled, not routed on this board
> 
> Nord Ride Embedded:
> 
>   usb_0  OTG, USB-C port 0 of a dual-port FUSB15201
>   usb_1  OTG, USB-C port 1 of the same FUSB15201
>   usb_2  host, USB Type-A, VBUS from a PMIC GPIO controlled
>          fixed regulator
> 
> Both boards use NXP PTN3222 eUSB2 repeaters, one per enabled port.
> 
> Dependencies:
> - PMIC DTS: https://lore.kernel.org/all/20260929155152.1898666-1-shengchao.guo@oss.qualcomm.com/
> - FUSB15201: https://lore.kernel.org/all/20260916135918.1017527-1-shengchao.guo@oss.qualcomm.com/
> - USB PHY clock fix: https://lore.kernel.org/all/20261008015017.3359804-1-shengchao.guo@oss.qualcomm.com/
> 

Figured you resubmitted this because the external dependencies was
settled. Apparently not, so I had to back this out again after applying
it.

Please resubmit once the dependencies are in linux-next.

Thanks,
Bjorn

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Changes in v3:
> - fix eUSB2 PHY reset assignment
> - add AHB2PHY clock to USB PHYs (Shawn)
> - fix regulator node ordering
> - remove code leftover from a rebase
> - Link to v2: https://patch.msgid.link/20260922-nord-usb-dwc-dts-v2-0-ba2b39f1a843@oss.qualcomm.com
> 
> Changes in v2:
> - Drop pin control fix that was applied upstream
> - "otg" mode is the default dr_mode so drop it from nodes
> - move the usb-mode-switch to the SoC level .dtsi
> - Add hs_phy_irq to DWC3 nodes
> - Wire-up the USB2 type A connector
> - Extend the list of quirks in DWC3 nodes
> - Remove stray comments
> - Link to v1: https://lore.kernel.org/all/20260911142040.100263-1-shengchao.guo@oss.qualcomm.com/
> 
> ---
> Bartosz Golaszewski (2):
>       arm64: dts: qcom: nord: Add the USB controller nodes
>       arm64: dts: qcom: nord-embedded: Add USB resources and PHYs
> 
> Shawn Guo (2):
>       arm64: dts: qcom: nord-rrd: Enable USB ports
>       arm64: dts: qcom: nord-ride-embedded: Enable USB ports
> 
>  arch/arm64/boot/dts/qcom/nord-embedded.dtsi     | 311 +++++++++++++++++++++++-
>  arch/arm64/boot/dts/qcom/nord-ride-embedded.dts | 222 +++++++++++++++++
>  arch/arm64/boot/dts/qcom/nord-rrd.dts           | 166 +++++++++++++
>  arch/arm64/boot/dts/qcom/nord.dtsi              | 100 ++++++++
>  4 files changed, 797 insertions(+), 2 deletions(-)
> ---
> base-commit: 3ce5d3ff6659394e56a7ef0cb2c9982a5c39148e
> change-id: 20260921-nord-usb-dwc-dts-c2ff685d8219
> 
> Best regards,
> -- 
> Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>