From: Hangbin Liu <hangbin.liu@linux.dev>
To: Jin Li <jinli@lanxincomputing.com>
Cc: dsahern@kernel.org, idosch@nvidia.com, shuah@kernel.org,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: net: forwarding: replace bash brace expansion with seq
Date: Mon, 9 Nov 2026 09:57:23 +0800 [thread overview]
Message-ID: <avEogwUP8hr4IXpS@fedora> (raw)
In-Reply-To: <20261107133416.212677-1-jinli@lanxincomputing.com>
On Sat, Nov 07, 2026 at 09:34:16PM +0800, Jin Li wrote:
> {1..16384} is bash-specific brace expansion and will not work with POSIX
> shells like dash or busybox ash. This breaks the flowlabel test when
> /bin/sh is not bash.
>
> Use $(seq 1 16384) for portable iteration. Fix the same issue in
> custom_multipath_hash.sh, gre_custom_multipath_hash.sh and
> ip6gre_custom_multipath_hash.sh.
>
As Sashiko suggested, I think it makes sense to add
Fixes: 555e5531635a ("selftests: net/forwarding: spawn sh inside vrf to speed up ping loop")
> Signed-off-by: Jin Li <jinli@lanxincomputing.com>
> ---
> .../selftests/net/forwarding/custom_multipath_hash.sh | 8 ++++----
> .../selftests/net/forwarding/gre_custom_multipath_hash.sh | 8 ++++----
> .../net/forwarding/ip6gre_custom_multipath_hash.sh | 8 ++++----
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
> index 5dbfab0e2..92940370e 100755
> --- a/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
> +++ b/tools/testing/selftests/net/forwarding/custom_multipath_hash.sh
> @@ -224,10 +224,10 @@ send_dst_ipv6()
> send_flowlabel()
> {
> # Generate 16384 echo requests, each with a random flow label.
> - ip vrf exec v$h1 sh -c \
> - "for _ in {1..16384}; do \
> - $PING6 -F 0 -c 1 -q 2001:db8:4::2 >/dev/null 2>&1; \
> - done"
> + ip vrf exec v$h1 sh -c '
> + for _ in $(seq 1 16384); do
> + '"$PING6"' -F 0 -c 1 -q 2001:db8:4::2 >/dev/null 2>&1
> + done'
> }
>
> send_src_udp6()
> diff --git a/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
> index b4f17a5bb..19384be4b 100755
> --- a/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
> +++ b/tools/testing/selftests/net/forwarding/gre_custom_multipath_hash.sh
> @@ -319,10 +319,10 @@ send_dst_ipv6()
> send_flowlabel()
> {
> # Generate 16384 echo requests, each with a random flow label.
> - ip vrf exec v$h1 sh -c \
> - "for _ in {1..16384}; do \
> - $PING6 -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1; \
> - done"
> + ip vrf exec v$h1 sh -c '
> + for _ in $(seq 1 16384); do
> + '"$PING6"' -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1
> + done'
> }
>
> send_src_udp6()
> diff --git a/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh b/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
> index b24acfa52..d848e82d4 100755
> --- a/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
> +++ b/tools/testing/selftests/net/forwarding/ip6gre_custom_multipath_hash.sh
> @@ -321,10 +321,10 @@ send_dst_ipv6()
> send_flowlabel()
> {
> # Generate 16384 echo requests, each with a random flow label.
> - ip vrf exec v$h1 sh -c \
> - "for _ in {1..16384}; do \
> - $PING6 -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1; \
> - done"
> + ip vrf exec v$h1 sh -c '
> + for _ in $(seq 1 16384); do
> + '"$PING6"' -F 0 -c 1 -q 2001:db8:2::2 >/dev/null 2>&1
> + done'
> }
>
> send_src_udp6()
> --
> 2.53.0
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
prev parent reply other threads:[~2026-11-09 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 13:34 [PATCH net] selftests: net: forwarding: replace bash brace expansion with seq Jin Li
2026-11-09 1:57 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avEogwUP8hr4IXpS@fedora \
--to=hangbin.liu@linux.dev \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jinli@lanxincomputing.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.