All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: Sana Sharma <sansshar@redhat.com>
Cc: linux-rt-users@vger.kernel.org, jkacur@redhat.com
Subject: Re: [PATCH] rteval: Changed logic for when stress-ng is absent
Date: Mon, 9 Nov 2026 12:56:13 +0100	[thread overview]
Message-ID: <avG03ec8EXEVWZgY@lx-t490> (raw)
In-Reply-To: <au4xNH5aozR5P2MD@sansshar-thinkpadp1gen4i.boston.csb>

On Fri, 06 Nov 2026, Sana Sharma wrote:
>
> Changed the failure in case stressng it not found from a sys exit
> to return an empty list so as to make it more graceful
>
> Signed-off-by: Sana Sharma <sansshar@redhat.com>
> ---

Same problematic passive language here as well.

Beside that, commit changelogs should focus more on the "why" of things,
not just the "what."

Thanks,
Ahmed

      reply	other threads:[~2026-11-09 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 19:57 [PATCH] rteval: Changed logic for when stress-ng is absent Sana Sharma
2026-11-09 11:56 ` Ahmed S. Darwish [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avG03ec8EXEVWZgY@lx-t490 \
    --to=darwi@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sansshar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.