All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Daejun Park <daejun7.park@samsung.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	 "linux-nvme@lists.infradead.org"
	<linux-nvme@lists.infradead.org>
Subject: Re: [PATCH blktests] nvme/071: test reservation preempt with multiple hosts
Date: Mon, 9 Nov 2026 21:00:42 +0900	[thread overview]
Message-ID: <avG1szpxkIL-Sj8x@shinmob> (raw)
In-Reply-To: <as9W9E4gkBjhZ9sK@shinmob>

On Oct 14, 2026 / 19:25, Shin'ichiro Kawasaki wrote:
> On Oct 02, 2026 / 16:08, Daejun Park wrote:
> > nvme/054 covers the reservation commands with a single host, so its
> > preempt step can only exercise a reservation holder preempting itself.
> > 
> > Add a test that connects three hosts to one namespace and sends the
> > Preempt and the Preempt and Abort actions of the Reservation Acquire
> > command from the reservation holder and from a non-holder registrant,
> > with PRKEY set to the key of another registrant, to the key of the
> > holder, and to 0h.  After each command the test checks the reservation
> > type and, for every registrant, its reservation key and whether it
> > holds the reservation, as reported by the Reservation Report command.
> > 
> > The steps in which the reservation holder preempts another registrant
> > or sends PRKEY 0h fail without the kernel patch "nvmet: fix preempt of
> > another registrant by the reservation holder".
> 
> Thanks for the patch. I ran the new test case and confirmed it fails. Also, I
> confirmed the kernel patch noted above avoids the failure. Good.
> 
> I think the patch is good enough to apply. Said that, I will wait for the kernel
> side fix patch lands on the Linus master branch to avoid confusion by the test
> case failure. I think the test case number 071 will need renumbering. I will do
> that modification when I apply the patch.

FYI, I applied the patch. Please note that I renumbered the test case to
nvme/076, and added a note about the kernel side commit. Thanks!

      reply	other threads:[~2026-11-09 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20261002070851epcms2p85765994ffe5ee25f97ff522c29b04b6a@epcms2p8>
2026-10-02  7:08 ` [PATCH blktests] nvme/071: test reservation preempt with multiple hosts Daejun Park
2026-10-14 10:25   ` Shin'ichiro Kawasaki
2026-11-09 12:00     ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avG1szpxkIL-Sj8x@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=daejun7.park@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.