All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Mark Brown <broonie@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: arizona-jack: Fix runtime PM leak in arizona_start_mic()
Date: Mon, 9 Nov 2026 11:22:44 +0000	[thread overview]
Message-ID: <avGtBFkyGtKOfSs3@opensource.cirrus.com> (raw)
In-Reply-To: <20261108114629.3205150-1-vulab@iscas.ac.cn>

On Sun, Nov 08, 2026 at 11:46:29AM +0000, Wentao Liang wrote:
> Hi Charles,
> 
> Sorry for the very late reply, and for the time you spent on a patch
> that should not have been sent.

No problem :-)

> You are right, and I am withdrawing it. By that point the function has
> already taken the runtime PM reference, enabled MICVDD and pulsed
> micbias, so a bare put would drop the reference without the rest of the
> teardown; and as you say, a failed MICD enable most likely only means
> the headset buttons are dead while the mic still records. Tearing all
> of that down properly would need the regulator and DAPM side too, which
> I cannot validate without hardware. Please disregard the patch; I will
> not send a v2.
> 
> I take the general point about these HPDET and MIC sequences, and I will
> not touch them again until I can test on hardware. I am also going
> through the outstanding review comments by hand, and I will not send
> patches in bulk any more.

Just take a little care with them, lot of subtlety there.

Thanks,
Charles

      reply	other threads:[~2026-11-09 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 16:46 [PATCH] ASoC: arizona-jack: Fix runtime PM leak in arizona_start_mic() Wentao Liang
2026-09-18 15:05 ` Charles Keepax
2026-11-08 11:46   ` Wentao Liang
2026-11-09 11:22     ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avGtBFkyGtKOfSs3@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.