From: Florian Westphal <fw@strlen.de>
To: xujiahao <xujiahao@cmss.chinamobile.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: xt_nat: allow IP_CT_RELATED_REPLY in DNAT targets
Date: Mon, 9 Nov 2026 15:15:10 +0100 [thread overview]
Message-ID: <avHVbkTbMxfJi9kR@strlen.de> (raw)
In-Reply-To: <20261109025392.reply@cmss.chinamobile.com>
xujiahao <xujiahao@cmss.chinamobile.com> wrote:
> a) nf_ct_attach(new, skb, bool tcp_rst) -- changes the exported symbol, or
> b) keep nf_ct_attach() as is and add a separate helper for the reject path?
Why not nf_ct_attach(new, skb, u8 l4proto) ?
This makes things easier to read, instead of
nf_ct_attach(new, skb, true)
readers see
nf_ct_attach(new, skb, IPPROTO_TCP).
> Either way ICMP keeps IP_CT_RELATED/_REPLY, and only the RST built by
> nf_reject_ipv4.c / nf_reject_ipv6.c would get IP_CT_ESTABLISHED/_REPLY.
Makes sense to me.
next prev parent reply other threads:[~2026-11-09 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 6:56 [PATCH nf] netfilter: xt_nat: allow IP_CT_RELATED_REPLY in DNAT targets xujiahao
2026-11-06 7:32 ` Florian Westphal
2026-11-09 4:35 ` xujiahao
2026-11-09 14:15 ` Florian Westphal [this message]
2026-11-10 2:18 ` [PATCH nf v2] netfilter: conntrack: attach generated TCP resets as ESTABLISHED xujiahao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avHVbkTbMxfJi9kR@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=xujiahao@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.