Re: [PATCH 4/9] device property: provide fwnode_property_get_names()

[Alejandro Colomar <alx+linux-hardening@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi Bartosz,

> Date: 2026-11-09 13:59:05+0100
> From: Bartosz Golaszewski <brgl@kernel.org>
>
[...]
> > > > > +int fwnode_property_get_names(const struct fwnode_handle *fwnode, char ***props)
> > > > 
> > > > Triple indirection is rare. Do we really need it?
> > > > 
> > > 
> > > I don't have a better alternative. Having two functions: one for
> > > counting the names and another for retrieving them into a
> > > caller-provided array is IMO the worse alternative, so I'd keep it.
> > 
> > Would it be possible to return the pointer, and then pass the count as
> > a parameter?
> > 
> 
> Is this really better? I think it's less intuitive than just passing a
> pointer to an array of strings.

Returning allocated pointers has a benefit for static analysis: the
function could be marked with __attribute__((__malloc__(deallocator))).


Cheers,
Alex

> 
> My personal preference is what I did in v1. Unless there are strong
> objections, I'd prefer to keep it this way.
> 
> Bart

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]