All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Masney <bmasney@redhat.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: max77843: convert to subsys_platform_driver()
Date: Mon, 9 Nov 2026 09:48:26 -0500	[thread overview]
Message-ID: <avHdOsFVStOYtOm2@redhat.com> (raw)
In-Reply-To: <10aacc3f-9ac9-413b-9216-ee166b1c6bef@kernel.org>

On Sat, Nov 07, 2026 at 11:46:57AM +0100, Krzysztof Kozlowski wrote:
> On 07/11/2026 02:07, Brian Masney wrote:
> > Reduce boilerplate code in this driver and convert it over to use
> > the macro subsys_platform_driver().
> > 
> > Note that this driver is configured in the Kconfig to be a tristate,
> > the driver doesn't have suppress_bind_attrs set, and there is no __exit
> > function defined. This change will add an __exit function that
> > unregisters the platform driver.
> > 
> > Signed-off-by: Brian Masney <bmasney@redhat.com>
> > ---
> >  drivers/extcon/extcon-max77843.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> I am 99% sure that this driver can function as module platform driver,
> because it has necessary MODULE_DEVICE_TABLE() and device is not needed
> for early boot.

I agree and I'll post a v2 that converts it use module_platform_driver()
instead.

> Nevertheless, this change itself is also correct.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Thanks!

Brian


      reply	other threads:[~2026-11-09 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  1:07 [PATCH] extcon: max77843: convert to subsys_platform_driver() Brian Masney
2026-11-07 10:46 ` Krzysztof Kozlowski
2026-11-09 14:48   ` Brian Masney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avHdOsFVStOYtOm2@redhat.com \
    --to=bmasney@redhat.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.